89ad25405e
userhelper: only notify failed login for actual logins
2021-02-25 18:26:37 +03:00
8915bd1b21
fix crash caused by non-numeric non-null _SESSION[uid] passed to sql logger
2021-02-25 18:21:48 +03:00
34c74400a4
enforce some stricter type checking for loggers
2021-02-25 17:10:03 +03:00
dcf0135285
logger: shorter syntax
2021-02-25 15:49:30 +03:00
59c14e9c00
api: remove base64 encoded passwords (wtf), log all authentication failures in userhelper
2021-02-25 15:39:46 +03:00
efd196839a
stop caching schema version entirely, fix some session_start() related warnings
2021-02-25 15:28:27 +03:00
1464abbbfc
prefs cleanup
2021-02-25 14:59:02 +03:00
c96172fa04
use constants in get_pref()/set_pref()
2021-02-25 14:49:58 +03:00
5aa05c90e1
pref-prefs: use constants instead of hardcoded strings
2021-02-25 14:45:11 +03:00
011e318947
prefs: don't try to do anything on schema < 141
2021-02-25 14:38:29 +03:00
6f02b1afd0
cleanup a bunch of old prefs code
2021-02-25 14:25:37 +03:00
7f18e8c33b
updater: show owner login instead of just uid
2021-02-25 14:23:56 +03:00
7869378436
deal with feed update scheduling w/ new prefs
2021-02-25 14:20:54 +03:00
2f2642bbd4
add fallback for feed_language on edit-feed-saving
...
Feed_language is only included in the form if running on pgsql, failing
the not null constraint on mysql setups.
2021-02-25 12:06:25 +01:00
00d0cb8c81
remove unused data from schema files
2021-02-25 12:58:00 +03:00
2621fe7955
fix get_pref always using default profile; remove unneeded code from db_prefs
2021-02-25 12:53:20 +03:00
bd2314170d
implement prefs UI based on new prefs class and a few more things
2021-02-25 12:46:13 +03:00
49a9afadce
add prefs caching
2021-02-25 10:34:59 +03:00
8026f3c3bd
initial (wip) for new prefs: add missing
2021-02-25 09:34:03 +03:00
988eb3ac91
initial (wip) for new prefs
2021-02-25 09:33:36 +03:00
2f14fa1bc3
add a hack to position labels on a dijit toolbar better
2021-02-24 15:53:47 +03:00
7f41228a71
decouple runtime-info object from counters
2021-02-24 15:40:19 +03:00
553548b689
request label counters conditionally
2021-02-24 15:07:31 +03:00
9313ebf2e7
fix warning in counters::get_feeds()
2021-02-24 13:25:26 +03:00
8b09e653e0
pass array to setScore
2021-02-24 12:10:09 +03:00
155e4f6125
pass a bunch of related arrays properly to backend
2021-02-24 12:07:25 +03:00
e468e5a589
cats_of: enforce owner_uid
2021-02-24 10:09:08 +03:00
6ea1430a04
no special counter handling for catchupAll
2021-02-24 10:01:39 +03:00
e6505b7d83
_cats_of: only request parents if needed
2021-02-24 09:56:59 +03:00
d6203bf350
try to calculate counters conditionally based on feed ids
2021-02-24 09:47:26 +03:00
a42e8aad97
add Errors.php
2021-02-23 22:31:43 +03:00
8d2e3c2528
drop errors.php and simplify error handling
2021-02-23 22:26:07 +03:00
85095f8a53
rename TTRSS_SESSION_NAME to SESSION_NAME
2021-02-23 17:01:25 +03:00
ab4dafa4be
config: add a type hint system
2021-02-23 16:58:48 +03:00
2ae0b7059f
cleanup some defined-stuff
2021-02-23 09:01:27 +03:00
77e6d589ff
allow adding custom config options
2021-02-22 23:20:52 +03:00
445ac1213c
finalize config:: migration; make config.php optional
2021-02-22 22:51:12 +03:00
211f699aa0
migrate the rest into Config::
2021-02-22 22:35:27 +03:00
383f4ca04a
add config.php
2021-02-22 21:49:09 +03:00
e4107ac952
wip: initial for config object
2021-02-22 21:47:48 +03:00
42173386b3
dirname(__FILE__) -> __DIR__
2021-02-22 17:38:46 +03:00
3f00502305
Merge pull request 'Let 'RSSUtils::check_feed_favicon' update existing favicons.' ( #6 ) from wn/tt-rss:check-feed-favicon into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/6
2021-02-22 17:25:02 +03:00
6fbf7ef368
Remove check against the old file in 'RSSUtils::check_feed_favicon'.
2021-02-22 12:06:27 +00:00
be4e7b1340
fix several issues reported by phpstan
2021-02-22 14:41:09 +03:00
33fff26869
reinstate HOOK_RENDER_ENCLOSURE
2021-02-22 10:00:50 +03:00
02a9485966
Try to limit max favicon size, don't store current/old in a var.
2021-02-21 23:30:31 +00:00
f6bfb89b29
pref-prefs: switch to new control shorthand in a few places
2021-02-21 23:18:32 +03:00
cb401af6f6
Let 'RSSUtils::check_feed_favicon' update existing favicons.
2021-02-21 19:01:40 +00:00
861a632ac7
move published opml JS code to pref helpers
2021-02-21 18:04:44 +03:00
521d0b65c7
batch feed editor: use tab layout, cleanup
2021-02-21 16:02:57 +03:00
d1328321be
move published OPML endpoint to public.php
2021-02-21 15:16:39 +03:00
2843b99171
minor filter UI layout fix
2021-02-21 13:08:34 +03:00
810afdaf5a
prevent creation of filter rules matching no feeds
2021-02-21 12:28:25 +03:00
3b8d69206c
deal with filter actions UI
2021-02-21 10:28:59 +03:00
94560132dd
for the most part, deal with filter rules UI
2021-02-21 09:35:07 +03:00
b4e96374bc
more filter stuff
2021-02-20 21:48:05 +03:00
590b1fc39e
a few more methods shuffled around
2021-02-20 18:21:36 +03:00
be91355c20
first for filter frontend overhaul
2021-02-20 18:15:08 +03:00
39be169f0b
also disable Article.completeTags
2021-02-20 13:39:17 +03:00
5c7416458f
rpc: disable completeLabels for now
2021-02-20 13:37:21 +03:00
22fe9b54d2
feed editor: use client dialog
2021-02-20 13:32:09 +03:00
9586c72a17
wip: feed editor client-side
2021-02-20 10:26:09 +03:00
545bcc3e4b
bookmarklets: cleanup some more markup
2021-02-20 08:49:40 +03:00
ce3e1756b3
Fix an undefined array key warning in 'catchupFeed'.
2021-02-19 21:46:30 +00:00
053b262aa7
rename public.php/cached_url to cached
2021-02-19 20:28:15 +03:00
fc0ebf0891
move bookmarklet-related methods out of public.php into the plugin
2021-02-19 20:21:36 +03:00
cf249d7e8c
modify classname helpers to use element.classList; fix feed debugger & share--get
2021-02-19 19:29:43 +03:00
737cffc241
render feed icon markup on the client
2021-02-19 17:40:11 +03:00
d445530fa0
format note on the client
2021-02-19 17:15:22 +03:00
4fa8450d38
setArticleTags: always return tags from the db
2021-02-19 15:50:42 +03:00
e73779fec1
render tags on the client
2021-02-19 15:31:50 +03:00
131f34648d
render headline labels on the client
2021-02-19 15:03:48 +03:00
660a1bbe01
* switch to xhr.post() almost everywhere
...
* call App.handlerpcjson() automatically on json request (if possible)
* show net/log indicators in prefs
2021-02-19 13:44:56 +03:00
bb4e4282f4
migrate a bunch of xhrPost invocations
2021-02-19 11:28:14 +03:00
00310d2d23
cleanup some unused code, fix App.byId() invoked by wrong name
2021-02-19 06:58:50 +03:00
dcfea9baac
properly validate feed editor dialog
2021-02-19 06:51:15 +03:00
c088e9d9d8
get rid of a few more prototype-isms
2021-02-18 22:23:06 +03:00
70fa423026
initial for RIP prototype/scriptaculous
2021-02-18 21:51:18 +03:00
75435aa960
user details: cleanup
2021-02-18 13:00:20 +03:00
39c0fe3697
shorten many invocations of Ajax.Request in inline form methods
2021-02-18 12:27:26 +03:00
466cba39d8
Merge branch 'master' of git.fakecake.org:fox/tt-rss
2021-02-18 11:54:29 +03:00
1adb9bb6b6
profiles: use client dialog; move related methods to pref-prefs
2021-02-18 11:54:22 +03:00
e4609c18ef
* add (disabled) shortcut syntax for plugin methods
...
* add controls shortcut for pluginhandler tags
* add similar shortcut for frontend
* allow plugins to selectively exclude their methods from CSRF checking
2021-02-17 21:44:21 +03:00
b16abc157e
* App: rename hidden to hidden_tag
...
* search: use client dialog
* add some form field helpers
2021-02-17 19:34:54 +03:00
92cb91e2e2
search dialog: bring back id of language dropdown
2021-02-17 16:33:28 +03:00
7be1e3ed38
pluginhandler: reject method requests without CSRF
2021-02-17 15:04:39 +03:00
e9c3118ddd
don't show E_USER_DEPRECATED on the frontpage
2021-02-17 14:14:10 +03:00
d439685895
pluginhandlers: post notice if pluginmethod is requested without CSRF token
2021-02-17 14:05:12 +03:00
273ada7353
* implement shortcut syntax for exposed plugin methods
...
* move shared article rendering code to share plugin
2021-02-17 09:59:14 +03:00
91e7969383
replace a few more controls to new style
2021-02-16 18:57:06 +03:00
24c79d91c2
controls_compat: comment out most of them
2021-02-16 18:53:56 +03:00
f58c49beaa
replace a few more controls to new style
2021-02-16 18:50:18 +03:00
9d7ba773ec
move session-related functions to their own namespace
2021-02-16 17:13:16 +03:00
7fad6ce651
move rgb/hsl functions to their own namespace
2021-02-16 17:07:23 +03:00
bdbbdbb0ed
rework controls to accept parameters as array
2021-02-16 16:59:21 +03:00
627af2c236
amend previous to fix actual underlying problem (double escaping)
2021-02-16 15:36:40 +03:00
1f5d81b77c
use a few more control helpers for checkboxes
2021-02-16 15:19:42 +03:00
22fc6871e8
remove backend helper and move its only function to rpc for the time being
2021-02-16 14:51:42 +03:00
d7127cead3
feed debugger: use hidden helpers; add button helpers
2021-02-16 14:42:27 +03:00
1f43d7916c
replace print_hidden with hidden_tag
2021-02-16 14:32:06 +03:00
26d6b84a57
add namespaced controls with unified naming; deprecated old-style control shortcuts
2021-02-16 14:23:00 +03:00
cb6b3584ce
pref-labels: remove unused code
2021-02-16 14:19:06 +03:00
cca84aedfd
_format_enclosures: always return entries array
2021-02-16 10:18:50 +03:00
88f7c4f1a5
feeds/view: fix php8 warning
2021-02-16 10:11:58 +03:00
5c4223992f
db-prefs: minor cleanup, add warnings if unknown prefs are requested
2021-02-15 22:01:11 +03:00
70e293bccb
pref-filters: fix some warnings
2021-02-15 17:07:50 +03:00
d4157b9e4e
counters: just merge everything at once
2021-02-15 17:01:05 +03:00
39604bedef
move reset_password to UserHelper
2021-02-15 16:59:54 +03:00
5d42ce553f
drop legacy DB interface and related sanity checks
2021-02-15 16:55:55 +03:00
9f55454f63
remove the rest of db.php; rename some leftover methods in feeds
2021-02-15 16:51:35 +03:00
bd3c38de84
move bookmarklet-related subscribe_to_feed_url to bookmarklet plugin
2021-02-15 16:41:52 +03:00
91285e3868
router: add additional logging for refused requests; reject requests for methods starting with _
2021-02-15 16:34:44 +03:00
d1c83fad14
api: unify naming
2021-02-15 16:18:17 +03:00
71f2f4288f
counters: one more
2021-02-15 16:14:48 +03:00
6426ae559a
dbupdater: unify naming
2021-02-15 16:14:00 +03:00
166f2d4666
diskcache: unify naming
2021-02-15 16:11:30 +03:00
8e79f1717d
prefs: unify naming
2021-02-15 16:07:22 +03:00
5704deb460
counters: unify naming
2021-02-15 16:00:54 +03:00
257efb43c6
article: unify naming
2021-02-15 15:52:28 +03:00
020f062a76
feeds: unify naming
2021-02-15 15:43:07 +03:00
6b006a18e7
subscribe to feed: use client dialog
2021-02-15 15:21:41 +03:00
ecb36b6354
edit tags: use client dialog
2021-02-15 14:50:40 +03:00
82adb01307
render enclosures on the client
2021-02-15 14:10:46 +03:00
916c21fe60
Merge pull request 'Lazy load image attachments' ( #2 ) from verifiedjoseph/tt-rss:lazy-load-image-attachments into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/2
2021-02-15 11:55:12 +03:00
868b9b476e
api: rewrite article urls at the very end to prevent plugins which expect source URLs from breaking
2021-02-15 09:40:43 +03:00
52a86c5e38
Revert "api: get flavor image from plugin-processed content"
...
This reverts commit a4604e892c
2021-02-15 08:49:12 +03:00
a4604e892c
api: get flavor image from plugin-processed content
2021-02-15 08:28:46 +03:00
9f31381bb6
renderToolbar: support empty data i.e. dashboard feed
2021-02-15 07:46:24 +03:00
a2e688fcb2
render headline-specific toolbar on the client
2021-02-14 22:17:13 +03:00
68e2ccb354
Lazy load image attachments
2021-02-14 17:31:01 +00:00
4996d8ccfe
pref-users edit: use client dialog
2021-02-14 16:44:41 +03:00
0b7377238a
add Handler_Administrative
2021-02-14 15:50:46 +03:00
33ea46c2bc
pref-users/add: remove unused variable
2021-02-14 15:42:12 +03:00
0fbf109912
* remove users/filters toolbar edit button (just click on it)
...
* fix title of edit filter dialog always showing create filter
2021-02-14 15:38:45 +03:00
a8cc43a0ff
move logout_user() to UserHelper
2021-02-14 15:31:03 +03:00
2547ece0ca
pref-users: cleanup index
2021-02-14 14:59:22 +03:00
1c7e4782aa
prefs system: load phpinfo using inline method
2021-02-14 12:29:08 +03:00
6b5c9c781b
pref prefs: load secondary tabs when needed
2021-02-14 12:25:41 +03:00
e5cedc7d5f
appPasswordList: markup cleanup
2021-02-14 11:39:26 +03:00
8e75551f95
pref prefs: split index into manageable chunks
2021-02-14 11:29:38 +03:00
15fd23c374
use shortcut echo syntax for php templates
2021-02-14 09:15:51 +03:00
d4c925819b
pref-feeds: load error button via xhr
2021-02-13 23:12:49 +03:00
43d8a1f2ff
remove getinactivefeeds (duplicate functionality)
2021-02-13 23:08:20 +03:00
103d30ad3f
batch subscribe: use client dialog
2021-02-13 22:16:17 +03:00
c36b2adf84
feeds with errors: use client dialog
2021-02-13 21:57:02 +03:00
8464c619e4
inactive feeds: use client dialog
2021-02-13 21:41:38 +03:00
17413078a7
pref feeds: index cleanup, split into several methods, use tabs to maximize space for feed tree, persist feed tree state
2021-02-13 18:32:02 +03:00
9684ce5c4b
minor fixes re: previous
2021-02-13 16:07:52 +03:00
b112198991
pref filters index: markup cleanup
2021-02-13 14:05:25 +03:00
5127c29297
prefs system: markup cleanup
2021-02-13 13:50:53 +03:00
aa63014073
pref-labels index: use cleaner markup
2021-02-13 13:37:57 +03:00
46f6d7c11a
pref-labels/index: cleanup
2021-02-13 13:26:17 +03:00
e7924c6dac
label editor: use client dialog
2021-02-13 13:17:34 +03:00
eec5871f5f
fail better if requested article URL is blank
2021-02-13 10:10:44 +03:00
d3940b6259
fix a bunch of warnings related to generated feeds
2021-02-12 22:00:33 +03:00
481bd76100
pref helpers: move some methods to their own sections
2021-02-12 21:51:32 +03:00
6af83e3881
drop ENABLE_GZIP_OUTPUT; system prefs: load php info only if needed
2021-02-12 21:43:38 +03:00
e6624cf631
fix a few more session-related warnings
2021-02-12 21:24:49 +03:00
157675d9fd
prefs: fix published shared URL dialog
2021-02-12 19:17:50 +03:00
ad7842c98a
RIP tag cloud: last of the vanilla popup dialog system
2021-02-12 18:43:30 +03:00
03b85248e6
move some dialogs to xhr loading
2021-02-12 18:38:26 +03:00
71dfc83466
force _ENABLED_PLUGINS to string when passed to pluginhost
2021-02-12 17:20:37 +03:00
3268364693
more dialog-related cleanup
2021-02-12 15:50:06 +03:00
3d11c61f32
* OPML import: don't reload everything, just feed tree
...
* dialogs: use auto-destroying dialog for almost all dialogs instead of destroying them manually
* some general dialog-related cleanup
2021-02-12 15:22:10 +03:00
8f8675a26a
* filters: remove duplicate code, overall cleanup
...
* check if some tres exist before trying to reload them
2021-02-12 14:31:36 +03:00
699186f430
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-02-12 14:08:34 +03:00
a718b692a0
Merge pull request 'Add defaults to api.php variables' ( #1 ) from klempin/tt-rss:fix/undefined-content into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/1
2021-02-12 13:25:24 +03:00
ace19c0790
Add defaults to api.php variables
2021-02-12 10:59:30 +01:00
0f7af07c6e
edit filter dialog: cleanup
2021-02-12 12:12:47 +03:00
20fb056323
remove customizecss from csrf-ignored methods
2021-02-12 10:37:14 +03:00
bf6d0f2817
various dialog-related fixes; stop referring to many dialogs by name; move filter test initial dialog to client side
2021-02-12 10:35:13 +03:00
72e38bfe1f
rework a few more dialogs to use App.dialogOf()
2021-02-12 09:56:27 +03:00
d466284fab
* customizeCSS: client dialog
...
* remove hardcoded width from most dialogs (move to css)
* add helper to easily get dialog from its widget
* rework some dialog buttons to use current object instead of calling dialog by name
2021-02-12 09:02:44 +03:00
83b0738b04
opml import: no more iframe, use client dialog
2021-02-12 08:22:00 +03:00
3134d71b8f
fix typo introduced by 4182018cb7
2021-02-12 08:15:30 +03:00
eac7ad5d34
remove explainError server-side dlg
2021-02-12 08:00:25 +03:00
4182018cb7
generated feed: use client dialog
2021-02-11 22:04:39 +03:00
1a680d4eae
publishedOPML: use client dialog
2021-02-11 21:42:38 +03:00
848bc57f29
disable themes in safe mode; rework safe mode warning/login prompt
2021-02-11 21:19:57 +03:00
74986d1ac6
shorten pref tab names; make log-alert clickable
2021-02-11 15:49:32 +03:00
09e9f34bb4
add UserHelper::find_user_by_login() and rewrite some user checks to invoke it instead of going through PDO
2021-02-11 10:22:27 +03:00
7af8744c85
authentication: make logins case-insensitive (force lowercase)
2021-02-11 09:57:57 +03:00
e7e73193fe
fix warning in profile edit dialog (2)
2021-02-10 22:06:01 +03:00
2505ae43a9
fix warning in profile edit dialog
2021-02-10 22:03:08 +03:00
9e1459d5db
pref/prefs: fix warning when in non-default profile
2021-02-10 21:40:43 +03:00
d630a92c40
fix 2 warnings in feed editor
2021-02-09 15:04:01 +03:00
2f8efab275
api: one more php8 warning
2021-02-09 12:04:59 +03:00
a5819569f2
pluginhost: a few more warnings and type hints
2021-02-09 10:20:58 +03:00
6a25bc53ef
api: pass hook object payload by reference
2021-02-09 08:57:23 +03:00
3655e7aaf1
api: fix some php8 warnings (4)
2021-02-09 08:50:51 +03:00
aba028a375
api: fix some php8 warnings (3)
2021-02-09 08:47:41 +03:00
f6f0f21664
make ARTICLE_KIND_ constants class members
2021-02-09 08:24:46 +03:00
0871a51cb4
api: fix some php8 warnings (2)
2021-02-09 08:16:04 +03:00
63a90d26f3
api: fix some php8 warnings
2021-02-09 08:15:07 +03:00
7ae0e8d9c5
rewrite some more hooks in classes/feeds
2021-02-08 23:10:22 +03:00
345dbb3521
rewrite some more hooks
2021-02-08 22:46:01 +03:00
6c8ccd2acc
front page log checker: filter out idiotic GD warning
2021-02-08 22:15:35 +03:00
9f3de2d24c
login: fix profile warning
2021-02-08 22:03:27 +03:00
07408ac222
opml: normalize class name
2021-02-08 21:38:26 +03:00
d91eae9c7e
pluginhost: add some type hints
2021-02-08 21:38:09 +03:00
7eb860af61
even more hooks
2021-02-08 21:28:09 +03:00
6e57fd77af
db: add type hints
2021-02-08 21:11:56 +03:00
a14873d5b4
more hooks, also add type hint for PluginHost::getInstance()
2021-02-08 21:06:14 +03:00
54bbd08f38
some more hooks
2021-02-08 20:45:11 +03:00
ca4c93c6b9
pluginhost: note hook function prototypes
2021-02-08 20:20:24 +03:00
7874f6ac58
remove PHPMD.UnusedFormalParameter
2021-02-08 19:42:10 +03:00
a341a838b1
pluginhost: deny hook registration to plugins which lack relevant implementation methods
2021-02-08 19:16:53 +03:00
51d2deeea9
fix hierarchy of authentication modules, make everything extend Auth_Base and implement hook_auth_user() for pluginhost
2021-02-08 19:11:31 +03:00
fc2e0bf67b
log viewer: disable previous page on page 1
2021-02-08 17:05:50 +03:00
fa2ebcd0a2
api: rewrite a few more hooks
2021-02-08 17:03:34 +03:00
363b3629a4
rewrite a few more hooks
2021-02-08 16:52:47 +03:00
3b52cea811
move some old-style handlers to new callback ones
2021-02-08 16:14:48 +03:00
1d5c8ee500
prefs: fix user plugins shown by incorrect criteria
2021-02-08 15:41:15 +03:00
1eb1629d9e
pluginhost: rework run_hooks() to be shorter, add callback variant; implement exception handling for both
2021-02-08 14:24:45 +03:00
20b56b5b23
pluginhost: catch errors while loading plugin source code
2021-02-08 12:14:12 +03:00
4165834f80
pluginhost: catch fatal errors in plugin init
2021-02-08 12:10:25 +03:00
d293cbd5a9
fix several warnings related to feed editor
2021-02-08 11:46:43 +03:00
0a788da2d2
dlg: fix unset param warning
2021-02-08 09:00:29 +03:00
3ad820e083
oops, remove unneeded warnings
2021-02-08 08:31:06 +03:00
479da5aa86
jimIcon: hide GD warning
2021-02-08 08:30:04 +03:00
3f972f8fed
public/subscribe: fix warnings
2021-02-08 08:20:30 +03:00
41fc03287e
fix even more warnings reported by phpstan
2021-02-06 17:56:47 +03:00
c94f1b6ff8
fix some more warnings reported by phpstan
2021-02-06 17:38:24 +03:00
b6e1a5c91a
fix several warnings reported by phpstan
2021-02-06 17:19:07 +03:00
ce2335deaf
pref-users: css fixes
2021-02-06 16:24:40 +03:00
d8de10d78a
error log: fix severity dropdown
2021-02-06 16:16:43 +03:00
73e697a0df
fix some warnings in prefs (filters, users)
2021-02-06 16:13:11 +03:00
73070544ca
error log: make it more readable
2021-02-06 16:11:29 +03:00
5cfc5914f2
log viewer: show total pages
2021-02-06 15:33:19 +03:00
5849a39820
af_redditimgur: don't try to load empty html; fix a warning in update debugger
2021-02-06 10:31:06 +03:00
ce489a724b
fix a few more warnings
2021-02-06 10:23:45 +03:00
10392ecc28
event log: add pagination
2021-02-06 10:10:54 +03:00
9fdeb58fd3
check a few more php8 warnings
2021-02-06 09:51:28 +03:00
a544123b59
fix clean() for arrays and user plugin list
2021-02-06 00:17:41 +03:00
6e774a58fe
more php8 fixes mostly related to login
2021-02-06 00:12:15 +03:00
403dca154c
initial WIP for php8; bump php version requirement to 7.0
2021-02-05 23:41:32 +03:00
da0ad82c24
Archive cleanup:
...
- remove code to manually archive/unarchive articles
- remove ttrss_archived_feeds/orig_feed_id handling - the whole thing was implemented for
this data to be kept indefinitely; it doesn't make a lot of sense to deal with this stuff
now that it is expired after one month anyway (same reasons as feed browser being removed - privacy)
- remove "originally from"-related stuff because of the above
- also remove unused remaining frontend/backend code related to feed browser (rip)
2021-01-17 14:55:11 +03:00
25520e9784
Select... dropdown: replace dijit Select with DropDownButton, simplify layout
...
PluginHost: add HOOK_HEADLINE_TOOLBAR_SELECT_MENU_ITEM
Headlines.onActionChanged: removed
2021-01-17 11:27:07 +03:00
bc0d50e892
remove show as feed from Select dropdown in main toolbar
2021-01-17 10:43:29 +03:00
b2993bcd30
remove menu options to manually un/archive articles
2021-01-17 10:37:40 +03:00
ee4b7bebe8
pluginhost: load_data: check schema last
2021-01-15 08:35:05 +03:00
40f38fc87f
pluginhost: load plugin data automatically (also marks load_data method as private)
2021-01-15 08:32:06 +03:00
f67f0f864b
HOOK_ARTICLE_EXPORT_FEED: also pass owner_uid
2021-01-11 22:52:31 +03:00
fadf4dec96
Include tags for HOOK_ARTICLE_EXPORT_FEED.
2021-01-10 03:23:16 -05:00
33a5ecd2ce
feed editor: show purge interval correctly if FORCE_ARTICLE_PURGE is set
2021-01-07 18:16:42 +03:00
4e3ef7a4dd
get_user_ip: remove REMOTEADDR for the time being
2021-01-05 10:25:43 +03:00
a8302fb253
use X-Real-IP headers if possible while authenticating
2021-01-05 10:17:24 +03:00
8cc07bc8bd
event log: add severity filtering
2020-12-24 15:02:47 +03:00
6da576dbe4
BLACKLISTED_TAGS: use textarea for editing; normalize value when saving
2020-12-21 08:50:34 +03:00
f59c567831
update_rss_feed: fix BLACKLISTED_TAGS not working properly, simplify tag-related code
2020-12-20 23:12:45 +03:00
5f733604f0
purge_feed: limit debugging to LOG_VERBOSE
2020-12-20 23:11:26 +03:00
d2db58de4f
Switch from 'vsprintf' to 'sprintf' in another place.
2020-12-16 07:55:32 -06:00
ef7e679363
Merge branch 'feature/php8' of wn/tt-rss into master
2020-12-16 11:06:48 +00:00
b4b2ba99ef
purge_feed: shorten one log message
2020-12-15 09:43:59 +03:00
f05f9b4252
purge_feed: add more debugging output
2020-12-15 08:50:01 +03:00
9b7338e807
feed editor: properly show global purging interval as disabled
2020-12-15 08:49:43 +03:00
83962a8561
feed debugger: allow setting log level to LOG_EXTENDED
2020-12-12 22:17:23 +03:00
62da307ef1
Use correct 'sprintf' function and other minor fixes in Pref_Feeds.
2020-12-12 10:28:55 -06:00
a1f8d6941b
Remove duplicate block in 'classes/pref/filters.php'.
...
Also a minor tweak to getting the search filter.
2020-12-12 10:28:54 -06:00
8c4ca7c8ef
Fix some 'isset' checks in 'classes/pref/prefs.php'.
2020-12-12 10:28:53 -06:00
95d0cb4953
Handle potential absence of a URL path in UrlHelper.
2020-12-12 10:28:53 -06:00
71c8d8d365
queryFeedHeadlines:
...
- there should be no need for DISTINCT query when checking for first id
- fix DISTINCT query part being undefined when browsing by tags
- add query debugging for tags
2020-12-08 17:01:19 +03:00
7608f3d7b0
Merge branch 'master' of git.fakecake.org:tt-rss
2020-12-08 13:55:11 +03:00
2edfcbbd85
get_article_image: add support for ARTICLE_KIND_ALBUM
2020-12-08 13:54:52 +03:00
85b788709a
setArticleTags: prevent duplicate tags being assigned if called twice
...
editTagsDlg: prevent dialot from being submitted twice
normalize_categories: filter out empty values that failed validation
2020-12-07 23:35:37 +03:00
d06cc8267b
queryFeedHeadlines: bring back DISTINCT for a limited set of columns
2020-12-07 16:59:48 +03:00
e40b79ab33
get_article_image: return basic kind to which flavor image belongs
2020-12-07 12:09:06 +03:00
db3fcb861b
viewfeed: reintroduce timestamps, fix debugging, fix some indents
2020-12-04 18:55:53 +03:00
20af8d5caf
queryFeedHeadlines: properly define for a few more variables
2020-12-04 08:59:37 +03:00
1580748c17
queryFeedHeadlines: make sure feed_check_qpart is always defined
2020-12-04 08:55:26 +03:00
904d5f7a3b
queryFeedHeadlines: no longer select DISTINCT headlines for performance reasons (this also removes _HEADLINES_QUERY_NO_DISTINCT)
2020-12-04 08:44:43 +03:00
e9673eb13d
experimental: add optional _HEADLINES_QUERY_NO_DISTINCT to disable DISTINCT keyword in queryFeedHeadlines query
2020-12-03 14:42:01 +03:00
8089fcc762
feed editor: also show default value for purge interval
2020-11-30 15:34:15 +03:00
d48460969d
feed editor: show actual value of default update interval
2020-11-30 15:29:22 +03:00
d1ee30d1ba
prevent horizontal scrolling in filter editor dialog if rules are very long
2020-11-27 12:27:12 +03:00
328d7b55c8
URLHelper: fix E_DEPRECATED error related to idn_to_ascii()
2020-11-14 15:13:35 +03:00
01c0d4bbfd
allow audio to be sent to client from the cache
2020-11-04 14:34:37 -05:00
f782ee46ad
Fix incorrect parenthesis placement in `count()`.
2020-10-29 00:52:07 -04:00
f1fd5e8db1
mark feed as having an error if update task fails (and no last error is already stored for this feed)
2020-10-18 16:12:58 +03:00
935f163919
api: catchupfeed: allow passing 'mode' (optional), bump api version
2020-10-03 10:23:21 +03:00
4ea407f613
when auto disabling feeds based on DAEMON_UNSUCCESSFUL_DAYS_LIMIT only consider feeds with recent attempts to update (to prevent clashes with not recently logged users, etc)
2020-10-01 15:59:40 +03:00
38a7a1da88
hide uninteresting errors in several DOMDocument->loadHTML() invocations
2020-10-01 13:20:07 +03:00
8a02a728c8
add DAEMON_UNSUCCESSFUL_DAYS_LIMIT tunable (defaults to 30 days)
2020-09-30 17:03:16 +03:00
e641547d37
set ttrss_feeds.last_successful_update as needed
2020-09-30 16:35:50 +03:00
15e8ee3471
housekeeping: add task to cleanup orphan feed icons
2020-09-29 12:46:55 +03:00
82bc740363
Logger::log - allow specifying errno
...
bump severity of PDO exception log messages to E_USER_WARNING
2020-09-29 10:08:54 +03:00
3b17c45887
exclude E_USER_NOTICE from recent events icon
2020-09-29 10:03:11 +03:00
23d20847a3
update_rss_feed: fallback to previous method if passthru() is not available
2020-09-28 21:19:53 +03:00
c70e26db31
validate url: feed urlencoded() URL to filter_var() only
2020-09-28 19:46:31 +03:00
7c8bed0524
accept -1 as a valid exit code for per-feed update processes
2020-09-28 16:02:59 +03:00
335dcd3bf9
don't mention last_updated in non-zero failure error message because that's not what it means
2020-09-28 08:32:14 +03:00
3534b8dfa7
improve logging for per-feed update task failures
2020-09-28 08:02:38 +03:00
74cd60d7cc
update_rss_feed: don't return as if failed on http 304
2020-09-27 17:13:36 +03:00
d4d0e976dc
update-feed: exit with non-zero exit code if update_rss_feed() failed
...
daemon: log if per-feed update task terminated with non-zero exit code
2020-09-27 16:42:45 +03:00
0761533d0a
lock per-feed update processes based on feed ID to reduce possibilty
...
of concurrent updates
2020-09-27 16:01:39 +03:00
528b387563
update individual feed in a separate process to prevent PHP fatal errors
...
(for example, OOM) from stopping the entire batch
this should also slightly increase memory budget for update processes
2020-09-27 15:58:13 +03:00
e993d4feb2
Merge branch 'master' of git.fakecake.org:tt-rss
2020-09-25 10:04:09 +03:00
71e9f70b8a
search_to_sql: use per-user default language instead of hardcoded english if isn't specified explicitly
2020-09-25 10:03:42 +03:00
d0ed7890df
prev: add missing class
2020-09-23 13:05:00 +03:00
215f388992
move timestamp-related stuff to a separate class
2020-09-23 13:04:26 +03:00
05744bb474
fix updater never scheduling feeds for update if they never been updated before while having default update interval set
2020-09-22 20:33:51 +03:00
8fb2baecdc
another hack for validation of URLs with invalid characters
2020-09-22 19:56:26 +03:00
a897c4165b
validate URLs: convert IDN to punycode before passing URL to filter_var()
2020-09-22 15:32:22 +03:00
6811d0bde2
use self:: in some places to invoke static methods from the same class
2020-09-22 14:54:15 +03:00
b5710baf34
- don't fail on non-ascii characters when validating URLs
...
- fix IDN hostnames not being converted properly
2020-09-22 14:37:45 +03:00
ab6aa0ad3e
fix previous re: resolve_redirects
2020-09-22 09:18:24 +03:00
74568df4ff
remove a lot of stuff from global context (functions.php), add a few helper classes instead
2020-09-22 09:04:33 +03:00
3dd4169b5f
clarify some URL validation-related error messages
2020-09-21 20:35:24 +03:00
4785f21316
update_rss_feed: log effective URL after fetching
...
validate_url: treat scheme as case-insensitive
2020-09-21 20:26:57 +03:00
05ef9aac2f
update URL pointing to version.json
2020-09-19 07:33:59 +03:00
03a337a660
add basic safe mode which doesn't load any user plugins
2020-09-18 15:48:22 +03:00
a4525d31b2
replace FALSE with false so that static analyzer shuts up about it
2020-09-17 19:02:27 +03:00
afa0023c51
don't try to update manually disabled feeds even if they haven't been updated before or are marked for a manual update
2020-09-17 15:40:50 +03:00
37f41a5246
forgotpass: use type strict comparison for reset token
2020-09-17 11:49:27 +03:00
e3adacc588
fix several cases of Db class being invoked as wrong name (as DB)
2020-09-17 09:18:03 +03:00
89d53a7f49
fix typo in previous
2020-09-17 08:45:17 +03:00
1f79d614c4
fix OTP QR code not displayed because of CSRF token passed as a query
...
parameter
use type-strict comparison when validating CSRF token on the backend
2020-09-17 08:43:39 +03:00
9d3c794983
subscribe: allow pre-filling feed URL if passed via query string
2020-09-16 17:20:31 +03:00
33fdde249e
pass CSRF token to opml import and feed icon replace dialogs
2020-09-16 06:43:55 +03:00
42b5564d1e
editarticletags: load dialog via XHR
2020-09-15 18:47:19 +03:00
0706a328a4
handler: default base csrf_ignore() to false
2020-09-15 18:16:33 +03:00
0a142912d3
backend handler: require CSRF, remove obsolete code
2020-09-15 18:08:08 +03:00
154417d80b
public/logout: require valid CSRF token
2020-09-15 16:59:11 +03:00
cbcb10a272
Feeds: load quickaddfeed and search dialogs via XHR w/ CSRF protection
2020-09-15 16:28:09 +03:00
8080c525fd
- backend: require CSRF token to be passed via POST
...
- do not leak CSRF token via GET request in feed debugger
- rework Article/redirect to use POST
2020-09-15 16:12:53 +03:00
e670ac2ee5
require CSRF token for Article/redirect
2020-09-15 15:35:50 +03:00
7e50c6c4b5
- enable CSRF support earlier
...
- remove rpc/sanityCheck from CSRF-excluded calls
2020-09-15 15:32:17 +03:00
79f102c25d
af_proxy_http: never print received data directly, always redirect to cached_url
...
cache/getUrl: basename() passed filename just in case
2020-09-15 08:02:28 +03:00
4a074111b5
user preferences: forbid < and > characters when changing passwords (were silently stripped on save because of clean())
2020-09-14 20:53:00 +03:00
da98ba662e
public/subscribe: require valid CSRF token when validating the form
2020-09-14 20:21:22 +03:00
c3d14e1fa5
- fix multiple vulnerabilities in af_proxy_http
...
- fix vulnerability in rewrite_relative_url() which prevented some URLs from being properly absolutized
- fetch_file_contents: validate all URLs before requesting them
- validate URLs: explicitly whitelist http and https scheme, forbid everything else
- DiskCache/cached_url: only serve whitelisted content types (images, video)
- simplify filename/URL handling code, remove and consolidate some less-used functions
2020-09-14 19:46:52 +03:00
a922b3cc6d
order_to_override_query: allow HOOK_HEADLINES_CUSTOM_SORT_OVERRIDE plugins to override built-in sorting
2020-09-11 07:48:22 +03:00
67f02e2aa7
properly return counters for labels with zero assigned articles
...
refs https://community.tt-rss.org/t/label-counter-doesnt-update-when-count-goes-down-to-zero/3766
2020-08-29 08:41:52 +03:00
88ced02622
Silence php 7.2 error message generated in `session_set_cookie_params`.
2020-08-14 10:47:46 -05:00
ddf9227dc4
pluginhost: allow overriding default sort modes via HOOK_HEADLINES_CUSTOM_SORT_MAP etc
2020-08-13 12:23:27 +03:00
dfa65e9374
move order_by to SQL override logic into a separate function
2020-08-13 11:52:32 +03:00
48be005774
instead of taking batch timestamp and score (?) into account, make oldest first sorting work consistently with newest first - i.e. rely on feed-provided timestamp
2020-08-11 13:29:09 +03:00
05a47e5cf4
OPML: export/import per-feed purge interval
2020-08-10 11:57:39 +03:00
c4ee0e25a1
more int/string type mismatches on getCategories
2020-08-01 16:30:10 +02:00
3da618e0ea
make sure all ints are casted (to int) on getCategories
2020-07-31 16:15:16 +02:00
68b78ecd3d
Merge branch 'bugfix/invalid-opml' of wn/tt-rss into master
2020-07-01 14:48:02 +00:00
b6372a846d
when exporting OPML via web UI, add user login to the filename
2020-07-01 10:02:24 +03:00
fa653f5a43
prefs: show disabled filters properly on mysql
2020-07-01 09:49:53 +03:00
2996a3942f
prefs: show root of filter tree as enabled so it's not grayed out
2020-07-01 09:48:27 +03:00
614d3ac1bf
Properly check if OPML file was loaded during import.
2020-06-27 15:06:08 -05:00
c352e872e9
core: pass found enclosures to HOOK_ARTICLE_FILTER
...
af_redditimgur: remove enclosures if we found something to embed because it's going to be a low-res thumbnail
2020-06-24 22:54:14 +03:00
6eb94f1e13
better support for image srcset attributes as discussed in https://community.tt-rss.org/t/problem-with-img-srcset/3519
2020-06-15 11:58:59 +03:00
d01ad09800
eslint-related fixes; move a few things from global context to App
2020-06-05 07:44:57 +03:00
c8cc845d5b
when removing favicon, reset its auto-refresh timer
2020-05-22 15:06:52 +03:00
06d2c65193
calculate_article_hash: don't die() on previous, woops
2020-05-17 17:44:32 +03:00
3a142cbf58
calculate_article_hash: ignore some useless or read-only fields (i.e. GUID) when calculating hash
2020-05-17 17:42:37 +03:00
cd1f3cb8cc
* store UID in article hashed GUID separately so it could be migrated cleanly to a different instance
...
* store resulting GUID as a JSON object so it could be extended easier if needed
2020-05-17 14:01:16 +03:00
7a2e9bef77
add --opml-export to update.php
2020-05-13 12:07:31 +03:00
c275a0cd33
DiskCache: append fake file extension when sending cached files based on mime type to make saving files easier
2020-05-12 13:28:54 +03:00
3a4b9249a9
DiskCache: properly deal with srcset attributes
2020-04-29 19:29:36 +03:00
4a00f96733
remove unneeded var_dump()
2020-04-29 11:35:02 +03:00
6573541873
* add HOOK_ENCLOSURE_IMPORTED
...
* pass feed id to HOOK_FEED_PARSED
2020-04-29 11:33:39 +03:00
44b1f0fcc0
search: add support for label:XXX search keyword
...
Labels: enforce case-insensitive lookups when creating/looking for labels
2020-04-04 14:34:08 +03:00
1f2a721905
allow overriding built-in templates via templates.local
2020-03-13 14:40:35 +03:00
ec1b0befc7
add support for video[@src] in media cache
...
it's a valid alternative to a source[@src] child element:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
2020-03-12 11:08:39 +01:00
cdde23b4dc
actually download <video> posters to media cache
...
video[@poster] is already supported in the rewriting logic but never
actually downloaded
2020-03-12 11:08:33 +01:00
b4287a2e98
fix url rewriting for videos with poster and src
...
if a poster attribute was present only that would have been rewritten
and the (arguably more important) src attribute would be left as-is
2020-03-12 11:08:24 +01:00
208e02c47d
PluginHost/save_data: use separate PDO connection to prevent issues with nested transactions
2020-03-10 08:14:00 +03:00
bcbc5ccc78
batchSubscribe: use validationtextarea
2020-02-28 14:03:29 +03:00
f24ece85a6
add validationtextarea control, use it for filter match editor
2020-02-28 13:53:45 +03:00
8645f36c5b
filter test dialog: pass contents via xhr POST
2020-02-28 12:16:54 +03:00
bdb1e475e7
external subscribe dialog: support dark theme
2020-02-27 13:40:32 +03:00
b2876f6c72
share anything dialog: support dark theme
2020-02-27 13:38:24 +03:00
4ab3854aed
don't generate default.css, replace with themes/light.css as a default root CSS file
2020-02-22 16:22:44 +03:00
5f30061c92
properly calculate marked counters for feeds in nested categories
2020-02-20 15:54:40 +03:00
60288f02e8
1. feedtree: show counters for marked articles if view-mode == marked
...
2. hide/show relevant counter nodes using css
3. cleanup some counter-related code
4. compile default css into light theme to prevent cache-related issues
2020-02-20 14:14:45 +03:00
5b6d9cee29
prefs layout fixes:
...
1. prevent layout breakage when using an authenticator which doesn't allow changing passwords
2. show explanatory messages when OTP or password changing is not available
3. allow app (API) passwords when using any auth module
2020-02-18 11:51:04 +03:00
47135160d1
getCategoryCounters: properly handle categories which don't have any stored feeds/articles
2020-01-27 15:45:04 +03:00
88d4324e32
mark primary button in the default password dialog
2020-01-25 13:08:29 +03:00
776fe4768b
default password warning: fix close button, don't crash if dialog is recreated (on feed tree reload etc)
2020-01-25 13:02:11 +03:00
0e9e1ad112
getCategoryUnread: return correct unread count for labels category
2020-01-25 12:53:10 +03:00
cdd2b6fd22
getCategoryChildrenUnread: fix typo
2020-01-25 10:00:22 +03:00
a6ced36189
getCategoryCounters: properly calculate counters for child subcategory entries
...
getCategoryUnread: cleanup
2020-01-25 09:57:28 +03:00
a64b8a7fdb
getCategoryUnread: don't return unread counters for Special category because it doesn't make a lot of sense to do so
2020-01-24 15:54:01 +03:00
2f6741e49a
getFeedCounters: pass parameter correctly to PDO
2020-01-24 14:27:24 +03:00
6080cca9ca
scrap counter cache system; rework counters to sum() booleans instead
2020-01-24 14:25:31 +03:00
3b29e865b0
support night mode in feed debugger
2020-01-19 10:56:49 +03:00
aa56bcaf44
support night mode when using share by URL
2020-01-19 10:51:08 +03:00
f47998f569
generate_syndicated_feed: use local media in generated feeds if it is available
2020-01-13 17:02:14 +03:00
b1c5ebdace
API/getVersion: don't try to use removed VERSION constant
2020-01-05 09:42:57 +03:00
fdb1fc7608
get_version: fix commit/timestamp lost on subsequent invocations because of misbehaving caching
2019-12-20 18:17:05 +03:00
72d0fac80c
remove version.php and VERSION global constant, do version-related things in a slightly less ridiculous way
2019-12-18 14:27:40 +03:00
df464e3d0d
update app password notice
2019-12-17 14:58:31 +03:00
9c0235ab66
show current unread counter on headlines toolbar if sidebar is hidden
2019-12-12 07:37:28 +03:00
76dd74e0d9
add a hidden tweakable which forbids changing passwords
2019-12-06 17:45:22 +03:00
ac95ab4a65
user css dialog: allow saving and applying CSS without closing the dialog
2019-12-06 14:02:30 +03:00
565547f5a1
php 7.4 deprecation-related fixes
2019-12-06 07:27:22 +03:00
f30287be65
versioning changes
...
- remove VERSION_STATIC - https://community.tt-rss.org/t/versioning-changes-for-trunk/2974
- report git commit/timestamp properly by invoking git instead of trying to parse .git/HEAD etc
- remove git-related global constants used when checking for updates
2019-12-05 13:23:54 +03:00
d15f0349bf
remove hardcoded iframe domain whitelist, make iframe script whitelisting configurable by plugins (HOOK_IFRAME_WHITELISTED)
2019-11-27 11:52:51 +03:00
e5b7b145e5
cache media: set referrer to source URL when fetching images
2019-11-25 09:48:24 +03:00
304d3a0b88
tag-related fixes
...
1. move tag sanitization to feedparser common item class
2. enforce length limit on tags when parsing
3. support multiple tags passed via one dc:subject and other such elements, parse them as a comma-separated list
4. sort resulting tag list to prevent different order between feed updates
5. remove some duplicate code related to tag validation
6. allow + symbol in tags
2019-11-20 18:56:34 +03:00
8c3efd51ec
reset domain hit quota on feed update start
2019-11-17 13:17:21 +03:00
63ce7ea705
add a plugin page warning for plugins using HOOK_FEED_FETCHED, etc
2019-11-14 07:01:45 +03:00
0d7b10469b
update_rss_feed: add specific logging for HOOK_FETCH_FEED, HOOK_FEED_FETCHED, HOOK_FEED_PARSED handlers
2019-11-14 06:39:45 +03:00
5bb8dad631
is_gzipped: don't try to strpos() over entire buffer
2019-11-12 07:11:10 +03:00
Andrew Dolgov
Frenck Lutke
fox
wn_
Joseph
Philip Klempin
JustAMacUser
fox
John Aylward
Rodney Stromlund
Paco Esteban
lllusion3418