Commit Graph

782 Commits

Author SHA1 Message Date
Andrew Dolgov 85adef06f4 onkeydown handlers: fix default keyboard events not being blocked if necessary 2018-12-05 09:11:12 +03:00
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
2018-12-05 07:41:55 +03:00
Andrew Dolgov 2ab097b2e5 initial work for flat modern theme 2018-12-04 22:24:31 +03:00
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 2018-12-04 19:03:42 +03:00
Andrew Dolgov ed1bd992d7 PrefFilterTree: fix obscure crash because of getLabel() not casting data to string 2018-12-04 16:07:24 +03:00
Andrew Dolgov f6e287df11 remove 4px margin of cdm.expanded 2018-12-04 13:40:47 +03:00
Andrew Dolgov 7e7a15136b Headlines.onRowChecked: fix undefined row 2018-12-04 10:32:57 +03:00
Andrew Dolgov 4a0b644f61 Headlines.onRowChecked: fix possible desync in checkbox and row selected state 2018-12-04 10:19:24 +03:00
Andrew Dolgov 6d3092c742 Headlines.openInNewWindow: don't set article active, just window.open() it and set read 2018-12-04 05:57:56 +03:00
Andrew Dolgov d3486b15f9 fix collapse_sidebar hotkey action 2018-12-03 20:49:37 +03:00
Andrew Dolgov d8d3662729 CommonDialogs: refresh proper elements after feed operations in preferences 2018-12-03 20:16:07 +03:00
Andrew Dolgov e76d1fb995 plugins: mail, mailto: remove code from global context 2018-12-03 14:21:50 +03:00
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 2018-12-03 13:38:13 +03:00
Andrew Dolgov a049b5bd88 shorten declaration of PrefHelpers.OPML 2018-12-03 12:57:19 +03:00
Andrew Dolgov 8f1881e12c remove cookie set check 2018-12-03 12:55:07 +03:00
Andrew Dolgov 4d4034091a prefs: Prefs global -> Helpers 2018-12-03 12:46:00 +03:00
Andrew Dolgov b3bc638a9f refactor OPML export/import code to be less horrible 2018-12-03 12:26:49 +03:00
Andrew Dolgov 78cc470193 remove some plugin JS code out of global context 2018-12-03 10:51:14 +03:00
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
2018-12-03 09:33:44 +03:00
wn_ b83ed6c7c4 Fix reference to `PluginHost`.
A `const` doesn't create a property on `window`.
2018-12-02 15:06:28 -06:00
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 2018-12-02 22:08:18 +03:00
Andrew Dolgov ac8361e6f6 add AppBase as a shared ancestor for main and prefs app objects
remove event.observe stuff from startup, unneeded
2018-12-02 21:52:50 +03:00
Andrew Dolgov eeb49d375c uploadIconHandler -> CommonDialogs 2018-12-02 20:57:51 +03:00
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 2018-12-02 20:56:30 +03:00
Andrew Dolgov 495248dd97 add Notify object 2018-12-02 20:44:53 +03:00
wn_ 87850ca1aa Fix 'document.onkeydown' handler 2018-12-02 11:21:37 -06:00
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
2018-12-02 20:07:57 +03:00
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 2018-12-02 18:38:27 +03:00
Andrew Dolgov 807ff07454 split main objects to dojo modules 2018-12-02 17:18:59 +03:00
Andrew Dolgov fda3ad39c8 split several utility objects into separate dojo modules 2018-12-02 17:00:58 +03:00
Andrew Dolgov 35ded4bc84 edit phrasing of some alert()s 2018-12-02 16:30:32 +03:00
Andrew Dolgov 3a6dae9203 prefs: more of the same, really 2018-12-02 16:29:00 +03:00
Andrew Dolgov b9869dbc01 prefs: remove some more stuff from global context (user management, etc) 2018-12-02 16:17:36 +03:00
Andrew Dolgov 58e54282d3 prefs: move more global functions into matching classes 2018-12-02 15:30:07 +03:00
Andrew Dolgov f26d404890 prefs: move other tree-related functions to respective trees 2018-12-02 12:03:28 +03:00
Andrew Dolgov 60cd467694 embed some pref-feed helper functions into the tree 2018-12-02 11:50:53 +03:00
Andrew Dolgov 2e985d1733 move some label helper functions to prefLabelTree 2018-12-02 11:34:57 +03:00
Andrew Dolgov e23b6e397d prefs: store active tab for reload, remove most old table row functions 2018-12-02 11:25:32 +03:00
Andrew Dolgov aa2f119eb6 remove getSelectedTableRowIds (Tables.getSelected) 2018-12-02 10:46:09 +03:00
Andrew Dolgov 874560db54 remove obsolete row selection functions
move getUrlParam() to Utils
2018-12-02 10:33:58 +03:00
Andrew Dolgov 2f85b50e36 remove toggleSelectListRow2() 2018-12-02 10:16:25 +03:00
Andrew Dolgov 8ea3a75df0 filters: simplify list row selection for checkboxes (properly) 2018-12-02 10:03:31 +03:00
Andrew Dolgov fb64726854 filters: simplify list row selection for checkboxes 2018-12-02 10:01:03 +03:00
Andrew Dolgov da9f83c4ac filter dialog fixes 2018-12-02 09:55:43 +03:00
Andrew Dolgov 1930f0e4e0 toggleSelect(etc): properly check for headlines object 2018-12-02 09:49:49 +03:00
Andrew Dolgov 0a18d0b1ed Feeds: shorten some method names
finally rename "view as rss"
2018-12-02 08:57:22 +03:00
Andrew Dolgov 6e625555c9 Headlines: shorten selectArticles 2018-12-02 08:34:08 +03:00
Andrew Dolgov 3678315bea Article, Headlines: shorten several method names 2018-12-02 08:32:13 +03:00
Andrew Dolgov d8ac5474ec onLoaded: since we call scroll handler anyway, remove fill up hack 2018-12-02 07:40:09 +03:00
Andrew Dolgov e5f3b75540 fix some minor linter problems 2018-12-02 07:31:10 +03:00
Andrew Dolgov 1e2d4410d3 move some more shared stuff to CommonDialogs, Filters, and Utils 2018-12-01 22:39:29 +03:00
Andrew Dolgov 4b492cc93e clear _infscroll_timeout when headlines are loaded 2018-12-01 22:24:30 +03:00
Andrew Dolgov bc96eac2ac addLabel -> CommonDialogs 2018-12-01 22:19:20 +03:00
Andrew Dolgov 2cd23e344c create headlines spacer with document.createElement() 2018-12-01 22:16:08 +03:00
Andrew Dolgov 6c110c1ceb headlines scroll handler: don't autoselect anything if feed was just opened 2018-12-01 22:12:36 +03:00
Andrew Dolgov de9509cd31 hotkeys: simplify prefix timeout handling 2018-12-01 22:07:00 +03:00
Andrew Dolgov b284e72d63 openArticleInNewWindow: also, set it active 2018-12-01 21:54:22 +03:00
Andrew Dolgov cc26be0793 migrate tt-rss.js contents to App 2018-12-01 21:51:00 +03:00
Andrew Dolgov 642c37ea61 further effocts to wrap JS stuff into objects 2018-12-01 21:01:53 +03:00
Andrew Dolgov 4bed9be57d js-ification: start on some common dialogs 2018-12-01 18:25:32 +03:00
Andrew Dolgov 44d3aedd38 prefs: hotkey handler to App 2018-12-01 18:10:30 +03:00
Andrew Dolgov ff708a9357 prefs: initial objectification 2018-12-01 18:08:09 +03:00
Andrew Dolgov b9984c0ed6 revert wrong changes in prefs.js 2018-12-01 18:05:20 +03:00
Andrew Dolgov 18868fb7ac remove counters_last_request from globals 2018-12-01 18:03:58 +03:00
Andrew Dolgov 97df81d8d9 even more objectification of JS 2018-12-01 17:54:16 +03:00
Andrew Dolgov 1d82bd4f19 further objectification 2018-12-01 17:42:21 +03:00
Andrew Dolgov 072c03fbac cdmClicked: backport master change to click on links 2018-12-01 17:23:59 +03:00
Andrew Dolgov 00cd4a48d4 Feeds -> this 2018-12-01 17:23:44 +03:00
Andrew Dolgov d86ddbc635 further objectification of JS code 2018-12-01 17:21:26 +03:00
Andrew Dolgov 049a37aa0e WIP reshuffling of JS global context into separate logical objects 2018-12-01 17:05:35 +03:00
Andrew Dolgov 4dbbd45caf enable floating title in unexpanded mode 2018-12-01 12:46:50 +03:00
Andrew Dolgov 468faee635 viewfeed: remove (tons of) obsolete code 2018-12-01 12:36:28 +03:00
Andrew Dolgov 069ecb6c2e viewfeed: catchup batched articles before opening next feed 2018-12-01 11:45:11 +03:00
Andrew Dolgov 710d06a288 catchup batching:
* behave better if invoked during an infinite scroll request
* flush catchup batch when article is selected manually
2018-12-01 11:42:57 +03:00
Andrew Dolgov 195180b64d minor refactoring: normalize some function names; cleanup; etc 2018-12-01 11:18:35 +03:00
Andrew Dolgov e720e6b628 remove infobox_callback2 2018-12-01 10:56:25 +03:00
Andrew Dolgov c151607b91 unpackVisibleHeadlines: increase lookahead distance 2018-12-01 10:25:16 +03:00
Andrew Dolgov b87b4287b7 scroll handler: fix loadMoreHeadlines() not being called 2018-12-01 10:19:45 +03:00
Andrew Dolgov 523e1cb9e8 reduce headlines scrolling timeout 2018-12-01 09:37:51 +03:00
Andrew Dolgov e84adbba37 rate-limit headlinesScrollHandler via timeout instead of distance scrolled
minor floating title cleanup
2018-12-01 09:33:09 +03:00
Andrew Dolgov efd28bb3b7 add ngettext to globals 2018-12-01 09:01:50 +03:00
Andrew Dolgov 669077c6ad refactor selection toggle functions; other minor cleanup 2018-12-01 08:59:30 +03:00
Andrew Dolgov a2ef54cd92 toggleMark, togglePub: refactor implementation
shorten marked/published img CSS classes
2018-12-01 08:20:09 +03:00
Andrew Dolgov 3325979bf0 isCdmMode -> isCombinedMode 2018-12-01 08:04:12 +03:00
Andrew Dolgov 32d36d439c in unexpanded mode unpack article only when activated 2018-12-01 07:53:51 +03:00
Andrew Dolgov 8971b920ce getSelectedArticleIds2: return unique ids
setActiveArticleId: update selected prompt
2018-12-01 01:21:33 +03:00
Andrew Dolgov c155a9e1ef toggle_cdm_expanded: use xhrPost 2018-12-01 01:18:32 +03:00
Andrew Dolgov 5aa9c60494 bring back (debloated) version of unexpanded combined mode 2018-12-01 01:03:01 +03:00
Andrew Dolgov 1702ecf7ea cdmClicked: when clicked on article link, open it in background window even without ctrl 2018-12-01 00:35:18 +03:00
Andrew Dolgov e2b8c9273e first stage of headline element handling refactoring 2018-12-01 00:11:52 +03:00
Andrew Dolgov c1ee7035e6 </hurr> 2018-11-30 20:24:38 +03:00
Andrew Dolgov 137bc3b3db cdmScrollToArticle: set id as active if selected 2018-11-30 20:24:10 +03:00
Andrew Dolgov 08bee97858 cdmScrollToArticle: set article read on selection 2018-11-30 20:00:27 +03:00
Andrew Dolgov ebc09be79d moveToPost: set unread to false when article is selected 2018-11-30 19:59:11 +03:00
Andrew Dolgov 8359ca6dad combined mode (and more) css class name updates 2018-11-30 15:48:17 +03:00
Andrew Dolgov 2f961ee830 plugins: add some xhrPost refactoring 2018-11-30 15:23:48 +03:00
Andrew Dolgov 764434a491 remove remove_splash() 2018-11-30 15:13:19 +03:00
Andrew Dolgov 02ec3984bd replace 4 space indents with tabs 2018-11-30 15:07:44 +03:00
Andrew Dolgov 59f5335f56 unpackVisibleHeadlines: go ahead of the buffer position a bit (2) 2018-11-30 14:26:28 +03:00
Andrew Dolgov 58dee80ae5 unpackVisibleHeadlines: go ahead of the buffer position a bit 2018-11-30 14:25:12 +03:00
Andrew Dolgov 0c06bb5fe1 scroll handler: performance improvements 2018-11-30 14:20:00 +03:00
Andrew Dolgov b9585004e6 packed headlines: no point in using JSON here 2018-11-30 13:56:33 +03:00
Andrew Dolgov 9563e3bcd6 remove expandable CDM headlines 2018-11-30 13:51:54 +03:00
Andrew Dolgov c8c9a26f30 move to simpler CDM handling of encoded content (instead of CENCW... etc) 2018-11-30 13:26:41 +03:00
Andrew Dolgov da1a3c2cc5 remove ok = confirm() thing 2018-11-30 13:05:59 +03:00
Andrew Dolgov fd752a79af finish xhrPost migration of js/ 2018-11-30 13:00:26 +03:00
Andrew Dolgov 7e8be97b66 remove duplicated code from hotkey actions handler
more xhrPost() refactoring
2018-11-30 12:46:52 +03:00
Andrew Dolgov 24c618dd6f editSelectedFeeds: fix missing unset checkboxes properly 2018-11-30 11:55:24 +03:00
Andrew Dolgov ef129fed2a some more xhrPost refactoring (batchEditSave WIP) 2018-11-30 10:48:50 +03:00
Andrew Dolgov fc0a3050eb use xhrPost is even more places! 2018-11-30 09:23:51 +03:00
Andrew Dolgov eaf7cfdba6 use xhrPost in even more places! 2018-11-29 23:36:54 +03:00
Andrew Dolgov 560b9fdd26 use xhrPost in more places 2018-11-29 22:56:34 +03:00
Andrew Dolgov 0d27227359 use xhrPost in more places; various minor cleanup 2018-11-29 22:21:09 +03:00
Andrew Dolgov 0267212454 move to let/const syntax in custom dojo modules 2018-11-29 21:21:06 +03:00
Andrew Dolgov 9dc5524df1 set dialogs to const 2018-11-29 21:13:41 +03:00
Andrew Dolgov 1b91bb4564 don't compare result with undefined seq 2018-11-29 21:07:19 +03:00
Andrew Dolgov 4508e3103d some more eslint-related stuff 2018-11-29 21:03:55 +03:00
Andrew Dolgov 8572e0108a declare globals with let 2018-11-29 20:09:25 +03:00
Andrew Dolgov 424e28db6b eslint-related fixes 2018-11-29 20:07:23 +03:00
Andrew Dolgov a3e2f1a9c3 define custom dojo modules with define() instead of require(), update startup module dependencies 2018-08-23 09:56:34 +03:00
Andrew Dolgov e35a46733f hlClicked: do not set headline selected when ctrl-clicking 2018-03-16 21:34:01 +03:00
Andrew Dolgov fa2e3b235a addLabel: remove unused active_tab 2018-03-16 17:25:42 +03:00
Andrew Dolgov d195c6a62e gotoExportOpml: js strict mode fix 2018-03-16 15:50:48 +03:00
wn_ a972ab45bd strict js: various var fixes 2018-03-14 20:02:21 -05:00
Andrew Dolgov ab688e963d viewfeed: remove force_nocache (unused) 2018-03-14 22:35:12 +03:00
Andrew Dolgov 7560e54e39 switchPanelMode: strict-mode fix for article_id 2018-03-14 19:45:10 +03:00
wn_ 30aa9743eb strict js: fix subscribing when HTML with multiple feeds
also a minor fix for response handling in quickAddFilter
2018-03-11 14:35:36 -05:00
wn_ a30f862de4 strict js: fix catchupBatchedArticles
This addresses the "Unread not removed from row" issue.
2018-03-10 07:38:23 -06:00
wn_ ad04bbf81d strict js: fix more dialog vars 2018-03-10 07:11:33 -06:00
wn_ 97f084c828 strict js: fix helpDialog 2018-03-09 19:57:17 -06:00
Andrew Dolgov 3009ecc44f initial for JS strict mode 2018-03-08 18:33:42 +03:00
Andrew Dolgov f6269d1bc4 add special class for feeds with disabled updates 2018-02-08 13:54:06 +03:00
Andrew Dolgov 44eda8521e filter delete action/rule: fix selector syntax 2018-02-04 12:50:21 +03:00
Andrew Dolgov 0518510814 remove some obsolete stuff, fix minor issues found by code analyzer 2017-12-04 11:02:13 +03:00
Andrew Dolgov 8f92a67e6f some (very minor) code cleanup in feeds class 2017-12-04 10:39:50 +03:00
Andrew Dolgov fa3bcfa379 queryfeedheadlines: there's no need to quote order_by/override_order
else: feedicon cache busting etc
2017-12-03 22:49:57 +03:00
Andrew Dolgov 7c0eb1b621 add defaultPasswordWarning nag dialog 2017-12-03 20:46:27 +03:00
Andrew Dolgov b5bf9a0ff3 remove long forgotten stuff related to feed debugging actionbar 2017-12-02 15:12:39 +03:00
Andrew Dolgov fbe7cb0a48 rpc: switch to PDO 2017-12-01 23:49:14 +03:00
Andrew Dolgov 03c56b041f force-request counters on load once if bw_limit option is enabled (because there's no timeout()) 2017-08-12 07:51:37 +03:00
wn_ b5fc9781ad Don't display label context menu items if there are no labels.
Caused by: 5e78b0c253
See: https://discourse.tt-rss.org/t/label-options-sometimes-not-showing-in-context-menu/366
2017-08-01 18:15:16 -05:00
Andrew Dolgov 22adcd7466 request counters less times during startup, delay initial request in feedlist_init() a bit 2017-07-30 21:53:11 +03:00
Andrew Dolgov 5e78b0c253 do not base headlines label context submenu on feed tree labels category 2017-07-30 11:55:30 +03:00
Andrew Dolgov 267bcee32c quickAddFeed: fix legacy feed_id type being passed to newrule 2017-07-02 22:50:44 +03:00
Andrew Dolgov 12b7b90c70 prefs: reload after OPML import 2017-07-02 20:26:18 +03:00
wn_ b3e3cb06d9 Show a blank icon in PrefFeedTree if there is no favicon for a feed.
Duplicates behavior of FeedTree.
Prevents a broken request to 'false' if a feed doesn't have a favicon.
2017-05-27 12:29:00 -05:00
Andrew Dolgov 5b6ea1ef91 remove pubsubhubbub: dead 2017-05-16 10:41:20 +03:00
Andrew Dolgov 7590f03961 feedtree.selectFeed: focus headlines-frame after selection 2017-05-12 08:05:35 +03:00
Andrew Dolgov 46b433933e hotkey_handler: one more tiny tweak 2017-05-05 11:46:16 +03:00
Andrew Dolgov a97e8cddf7 hotkey_handler: cleanup things a bit 2017-05-05 11:41:49 +03:00