Commit Graph

701 Commits

Author SHA1 Message Date
Andrew Dolgov 669077c6ad refactor selection toggle functions; other minor cleanup 2018-12-01 08:59:30 +03:00
Andrew Dolgov a2ef54cd92 toggleMark, togglePub: refactor implementation
shorten marked/published img CSS classes
2018-12-01 08:20:09 +03:00
Andrew Dolgov 3325979bf0 isCdmMode -> isCombinedMode 2018-12-01 08:04:12 +03:00
Andrew Dolgov 32d36d439c in unexpanded mode unpack article only when activated 2018-12-01 07:53:51 +03:00
Andrew Dolgov 8971b920ce getSelectedArticleIds2: return unique ids
setActiveArticleId: update selected prompt
2018-12-01 01:21:33 +03:00
Andrew Dolgov c155a9e1ef toggle_cdm_expanded: use xhrPost 2018-12-01 01:18:32 +03:00
Andrew Dolgov 5aa9c60494 bring back (debloated) version of unexpanded combined mode 2018-12-01 01:03:01 +03:00
Andrew Dolgov 1702ecf7ea cdmClicked: when clicked on article link, open it in background window even without ctrl 2018-12-01 00:35:18 +03:00
Andrew Dolgov e2b8c9273e first stage of headline element handling refactoring 2018-12-01 00:11:52 +03:00
Andrew Dolgov c1ee7035e6 </hurr> 2018-11-30 20:24:38 +03:00
Andrew Dolgov 137bc3b3db cdmScrollToArticle: set id as active if selected 2018-11-30 20:24:10 +03:00
Andrew Dolgov 08bee97858 cdmScrollToArticle: set article read on selection 2018-11-30 20:00:27 +03:00
Andrew Dolgov ebc09be79d moveToPost: set unread to false when article is selected 2018-11-30 19:59:11 +03:00
Andrew Dolgov 8359ca6dad combined mode (and more) css class name updates 2018-11-30 15:48:17 +03:00
Andrew Dolgov 2f961ee830 plugins: add some xhrPost refactoring 2018-11-30 15:23:48 +03:00
Andrew Dolgov 764434a491 remove remove_splash() 2018-11-30 15:13:19 +03:00
Andrew Dolgov 02ec3984bd replace 4 space indents with tabs 2018-11-30 15:07:44 +03:00
Andrew Dolgov 59f5335f56 unpackVisibleHeadlines: go ahead of the buffer position a bit (2) 2018-11-30 14:26:28 +03:00
Andrew Dolgov 58dee80ae5 unpackVisibleHeadlines: go ahead of the buffer position a bit 2018-11-30 14:25:12 +03:00
Andrew Dolgov 0c06bb5fe1 scroll handler: performance improvements 2018-11-30 14:20:00 +03:00
Andrew Dolgov b9585004e6 packed headlines: no point in using JSON here 2018-11-30 13:56:33 +03:00
Andrew Dolgov 9563e3bcd6 remove expandable CDM headlines 2018-11-30 13:51:54 +03:00
Andrew Dolgov c8c9a26f30 move to simpler CDM handling of encoded content (instead of CENCW... etc) 2018-11-30 13:26:41 +03:00
Andrew Dolgov da1a3c2cc5 remove ok = confirm() thing 2018-11-30 13:05:59 +03:00
Andrew Dolgov fd752a79af finish xhrPost migration of js/ 2018-11-30 13:00:26 +03:00
Andrew Dolgov 7e8be97b66 remove duplicated code from hotkey actions handler
more xhrPost() refactoring
2018-11-30 12:46:52 +03:00
Andrew Dolgov 24c618dd6f editSelectedFeeds: fix missing unset checkboxes properly 2018-11-30 11:55:24 +03:00
Andrew Dolgov ef129fed2a some more xhrPost refactoring (batchEditSave WIP) 2018-11-30 10:48:50 +03:00
Andrew Dolgov fc0a3050eb use xhrPost is even more places! 2018-11-30 09:23:51 +03:00
Andrew Dolgov eaf7cfdba6 use xhrPost in even more places! 2018-11-29 23:36:54 +03:00
Andrew Dolgov 560b9fdd26 use xhrPost in more places 2018-11-29 22:56:34 +03:00
Andrew Dolgov 0d27227359 use xhrPost in more places; various minor cleanup 2018-11-29 22:21:09 +03:00
Andrew Dolgov 0267212454 move to let/const syntax in custom dojo modules 2018-11-29 21:21:06 +03:00
Andrew Dolgov 9dc5524df1 set dialogs to const 2018-11-29 21:13:41 +03:00
Andrew Dolgov 1b91bb4564 don't compare result with undefined seq 2018-11-29 21:07:19 +03:00
Andrew Dolgov 4508e3103d some more eslint-related stuff 2018-11-29 21:03:55 +03:00
Andrew Dolgov 8572e0108a declare globals with let 2018-11-29 20:09:25 +03:00
Andrew Dolgov 424e28db6b eslint-related fixes 2018-11-29 20:07:23 +03:00
Andrew Dolgov a3e2f1a9c3 define custom dojo modules with define() instead of require(), update startup module dependencies 2018-08-23 09:56:34 +03:00
Andrew Dolgov e35a46733f hlClicked: do not set headline selected when ctrl-clicking 2018-03-16 21:34:01 +03:00
Andrew Dolgov fa2e3b235a addLabel: remove unused active_tab 2018-03-16 17:25:42 +03:00
Andrew Dolgov d195c6a62e gotoExportOpml: js strict mode fix 2018-03-16 15:50:48 +03:00
wn_ a972ab45bd strict js: various var fixes 2018-03-14 20:02:21 -05:00
Andrew Dolgov ab688e963d viewfeed: remove force_nocache (unused) 2018-03-14 22:35:12 +03:00
Andrew Dolgov 7560e54e39 switchPanelMode: strict-mode fix for article_id 2018-03-14 19:45:10 +03:00
wn_ 30aa9743eb strict js: fix subscribing when HTML with multiple feeds
also a minor fix for response handling in quickAddFilter
2018-03-11 14:35:36 -05:00
wn_ a30f862de4 strict js: fix catchupBatchedArticles
This addresses the "Unread not removed from row" issue.
2018-03-10 07:38:23 -06:00
wn_ ad04bbf81d strict js: fix more dialog vars 2018-03-10 07:11:33 -06:00
wn_ 97f084c828 strict js: fix helpDialog 2018-03-09 19:57:17 -06:00
Andrew Dolgov 3009ecc44f initial for JS strict mode 2018-03-08 18:33:42 +03:00
Andrew Dolgov f6269d1bc4 add special class for feeds with disabled updates 2018-02-08 13:54:06 +03:00
Andrew Dolgov 44eda8521e filter delete action/rule: fix selector syntax 2018-02-04 12:50:21 +03:00
Andrew Dolgov 0518510814 remove some obsolete stuff, fix minor issues found by code analyzer 2017-12-04 11:02:13 +03:00
Andrew Dolgov 8f92a67e6f some (very minor) code cleanup in feeds class 2017-12-04 10:39:50 +03:00
Andrew Dolgov fa3bcfa379 queryfeedheadlines: there's no need to quote order_by/override_order
else: feedicon cache busting etc
2017-12-03 22:49:57 +03:00
Andrew Dolgov 7c0eb1b621 add defaultPasswordWarning nag dialog 2017-12-03 20:46:27 +03:00
Andrew Dolgov b5bf9a0ff3 remove long forgotten stuff related to feed debugging actionbar 2017-12-02 15:12:39 +03:00
Andrew Dolgov fbe7cb0a48 rpc: switch to PDO 2017-12-01 23:49:14 +03:00
Andrew Dolgov 03c56b041f force-request counters on load once if bw_limit option is enabled (because there's no timeout()) 2017-08-12 07:51:37 +03:00
wn_ b5fc9781ad Don't display label context menu items if there are no labels.
Caused by: 5e78b0c253
See: https://discourse.tt-rss.org/t/label-options-sometimes-not-showing-in-context-menu/366
2017-08-01 18:15:16 -05:00
Andrew Dolgov 22adcd7466 request counters less times during startup, delay initial request in feedlist_init() a bit 2017-07-30 21:53:11 +03:00
Andrew Dolgov 5e78b0c253 do not base headlines label context submenu on feed tree labels category 2017-07-30 11:55:30 +03:00
Andrew Dolgov 267bcee32c quickAddFeed: fix legacy feed_id type being passed to newrule 2017-07-02 22:50:44 +03:00
Andrew Dolgov 12b7b90c70 prefs: reload after OPML import 2017-07-02 20:26:18 +03:00
wn_ b3e3cb06d9 Show a blank icon in PrefFeedTree if there is no favicon for a feed.
Duplicates behavior of FeedTree.
Prevents a broken request to 'false' if a feed doesn't have a favicon.
2017-05-27 12:29:00 -05:00
Andrew Dolgov 5b6ea1ef91 remove pubsubhubbub: dead 2017-05-16 10:41:20 +03:00
Andrew Dolgov 7590f03961 feedtree.selectFeed: focus headlines-frame after selection 2017-05-12 08:05:35 +03:00
Andrew Dolgov 46b433933e hotkey_handler: one more tiny tweak 2017-05-05 11:46:16 +03:00
Andrew Dolgov a97e8cddf7 hotkey_handler: cleanup things a bit 2017-05-05 11:41:49 +03:00
Andrew Dolgov 0ae7de6d91 hotkey_handler: return true on prefix handled 2017-05-05 11:33:43 +03:00
Andrew Dolgov fa1be041c2 feedtree, selectFeed: focus selected node 2017-05-05 10:35:10 +03:00
Andrew Dolgov 0a79531696 hotkey_handler: stop propagation of handled prefix/action events 2017-05-05 10:01:33 +03:00
Andrew Dolgov 337535416f filter by search results while marking feed as read 2017-03-31 11:21:35 +03:00
Andrew Dolgov 63f0ed3d9c cdmClicked: do not use event.target.parents to figure out if clicked on a heading 2017-03-06 12:19:13 +03:00
Andrew Dolgov 270c0a00e5 improve JS error logging with additional stuff 2017-03-05 10:50:15 +03:00
Andrew Dolgov e0a957b3f6 use try/catch block in updatefeedlist
remove reporting function from exception dialog
2017-03-05 10:30:49 +03:00
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
2017-03-04 14:34:44 +03:00
Andrew Dolgov b835a52814 rework the way headlines menus identify calling row 2017-02-17 09:01:45 +03:00
Andrew Dolgov ad7cea62e1 editFilter: fix selector expressions broken by 88946d3 2017-02-15 13:22:16 +03:00
Andrew Dolgov 79ec2f3efd set error report url to https 2017-02-14 09:32:21 +03:00
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 2017-02-13 23:36:58 +03:00
Andrew Dolgov 20deb5fc32 cdmcollapse/expand: use less convoluted selector queries 2017-02-13 22:45:30 +03:00
Andrew Dolgov 70c0a8c2e0 pass several image files used in notify messages to frontend as base64 to prevent broken error messages in case network connection is down. also, update some close buttons to show correct cursor. 2017-02-09 23:19:26 +03:00
Andrew Dolgov 3188e863b3 handle_rpc_json: fix netalert button never appearing on JSON parse error 2017-02-09 23:04:34 +03:00
Andrew Dolgov 829d478f1b add some protection against opener attacks if external site is opened via window.open() 2017-02-08 15:07:05 +03:00
Andrew Dolgov 23c8ef7e36 parse_counters: skip subscribed-feeds id properly 2017-02-04 14:50:50 +03:00
Andrew Dolgov 6358d70d5e reset local counter cache when feed count changes 2017-02-04 11:57:31 +03:00
Andrew Dolgov 24c7e4132d subscribe dialog: do not report errors via alert()
fetch_file_contents: reset all globals on start, return error message body when not using curl
subscribe_to_feed: report if cloudflare is in the error message
2017-01-28 12:45:49 +03:00
Andrew Dolgov ad326dbf78 unpackVisibleHeadlines: do not iterate over all RROWs all the time 2017-01-22 20:57:16 +03:00
Andrew Dolgov 70c5b2bfcc feed tree: only run animation for appearing unread counters to prevent clashes with aux counter updating and animations ending up in wrong state 2017-01-22 20:20:35 +03:00
Andrew Dolgov 3bc1b53772 initHeadlinesMenu: remove unneeded output 2017-01-22 19:58:17 +03:00
Andrew Dolgov 974c6eb523 attach headline menu objects to correct DOM nodes in combined mode 2017-01-22 19:57:16 +03:00
Andrew Dolgov d5f74019ac parse_counters: cache previous reply and skip processing of unchanged rows (better implementation) 2017-01-22 19:38:07 +03:00
Andrew Dolgov a4e04c498f parse_counters: cache previous reply and skip processing of unchanged rows 2017-01-22 19:29:14 +03:00
Andrew Dolgov e1f7b05b52 reuse menu objects while appending headline rows 2017-01-22 19:20:23 +03:00
Andrew Dolgov b1a80693b1 collapse_feedlist: also toggle splitter 2017-01-22 17:46:11 +03:00
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 16:52:27 -05:00
Andrew Dolgov b7d63a58db fix loading indicator position/size for tree leafs 2017-01-21 22:30:20 +03:00
Andrew Dolgov 7fbc10c236 force-enable persist for feedTree 2017-01-21 22:21:46 +03:00
Andrew Dolgov e2e2479984 Merge branch 'dojo-1.12.1'
Conflicts:
	js/prefs.js
2017-01-21 21:59:17 +03:00
Andrew Dolgov ab235fc5f1 prefs: add updateSelectedPrompt shim called by toggleSelectedRow() 2017-01-21 21:49:10 +03:00
Andrew Dolgov 1c4f5e8390 add dependency on dojo/_base/html 2017-01-21 21:47:44 +03:00
Anders Kaseorg 6887a0f573 lib: Upgrade Dojo and Dijit from 1.8.3 to 1.12.1
The itemNode and expandoNode elements have changed from img to
span (https://bugs.dojotoolkit.org/ticket/16699), so we now put our
tree icons inside them rather than replacing them.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 13:22:14 -05:00
Anders Kaseorg 9f539be3c2 Replace deprecated dojo.place with domConstruct.place
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 13:22:13 -05:00
Andrew Dolgov 6293d3717c add toggle_sidebar plugin, remove obsolete toggle button
add PluginHost::HOOK_MAIN_TOOLBAR_BUTTON
2017-01-07 15:29:17 +03:00
Andrew Dolgov f04b12d8e7 category: swap context menu items 2016-11-22 09:11:13 +03:00
Andrew Dolgov acfee412a3 feed tree: add category context menu entry to un/collapse it 2016-11-11 14:14:31 +03:00
Andrew Dolgov d39a2f8005 switch modules to new dojo definition format 2016-08-10 13:40:24 +03:00
Andrew Dolgov 546b419f52 catch plugin JS errors 2016-08-10 12:23:35 +03:00
Andrew Dolgov fd539f2800 prefs: use dojo asynchronously 2016-08-10 12:22:30 +03:00
Andrew Dolgov 0dbc20a8d4 load dijit properly, duh 2016-08-10 11:49:05 +03:00
Andrew Dolgov ee5170424e dojo: main UI: load stuff asynchronously 2016-08-10 10:01:05 +03:00
Andrew Dolgov 64c24ecb59 add hotkey for toggling VFEED_GROUP_BY_FEED preference 2016-07-26 15:55:00 +03:00
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 2016-03-22 23:43:32 +03:00
Andrew Dolgov 2d052e42b5 getLoadedArticleIds: consider visible rows only
catchupFeedInGroup: hide articles when catching up, with caveats
2016-03-22 23:22:28 +03:00
Andrew Dolgov 6be118fda1 showArticleInHeadlines: remove unused code 2016-03-22 13:41:55 +03:00
Andrew Dolgov c4e211046e updateFloatingMenu: performance improvements 2016-03-22 13:38:20 +03:00
Andrew Dolgov d7cc5e6cdd fix previous 2016-03-22 12:51:15 +03:00
Andrew Dolgov 63c7446a79 headlines scroll handler: add a rate limit 2016-03-22 12:43:18 +03:00
Andrew Dolgov 7c0d68f207 remove dismiss* functions 2016-03-22 10:28:34 +03:00
Andrew Dolgov a51bc3dfa5 catchupfeedingroup: do not remove elements 2016-03-22 10:23:57 +03:00
Andrew Dolgov 6056d164fa cleanup dismissArticle functions 2016-03-22 10:11:11 +03:00
Andrew Dolgov 11514d576f catchupFeedInGroup: dismiss elements on catchup 2016-03-22 09:42:00 +03:00
Andrew Dolgov dfaf806a7a catchupFeedInGroup: send catchup request even if there are no unread articles in the buffer for this feed 2016-03-21 21:43:54 +03:00
Andrew Dolgov 701de97ebb improvements for catchupFeedInGroup() 2016-03-21 21:40:40 +03:00
Kostiantyn Moroz 2757c49387 Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode) 2016-02-07 18:48:24 +00:00
Andrew Dolgov 0b41bd3414 add some hacks to hopefully mitigate headlines memory leaks 2016-01-11 01:11:26 +03:00
Andrew Dolgov 9842b51c71 getfeedname: fix for non-numeric feeds (tags) 2015-12-30 15:11:39 +03:00
Andrew Dolgov 89bea945ce filters: add to previous on JS side 2015-12-03 10:25:30 +03:00
Andrew Dolgov d38cd41253 loadMoreHeadlines: use correct offsets for starred vfeed in adaptive mode 2015-10-27 15:36:51 +03:00
Andrew Dolgov a71e571b97 headlines_callback2: force prevent duplicate row ids 2015-10-07 18:14:21 +03:00
Andrew Dolgov f48f292d2b tweak filter preview layout a bit; allow previewing matched articles in a popup 2015-09-11 13:05:08 +03:00
Andrew Dolgov 3857536f70 fix testing in create filter dialog, woops 2015-09-09 22:13:43 +03:00
Andrew Dolgov 261226a3a5 mostly implement async filter test dialog 2015-09-09 22:09:03 +03:00
Andrew Dolgov a007c18dff wip: filter async testing 2015-09-09 16:56:04 +03:00
Andrew Dolgov a0dbc45acd add edit feed to feed header context menu in grouped mode 2015-09-07 12:49:49 +03:00
Andrew Dolgov b717c65e4e update previous 2015-09-03 16:54:09 +03:00
Andrew Dolgov 791877c39d fix catching up for grouped feeds 2015-09-03 16:41:04 +03:00
Andrew Dolgov e17079dcef make disabled filter rules easier to discern
show if filter set match_any_rule on the overview
2015-08-17 12:33:07 +03:00
Andrew Dolgov dcbe36b2a2 fix some remaining old-style viewfeed() calls 2015-08-13 09:51:39 +03:00
Andrew Dolgov 9109e171ee feedtree: don't hide feeds with errors 2015-08-12 21:47:40 +03:00
Andrew Dolgov bf9cc9ad95 combine user edit & user details 2015-08-12 20:19:38 +03:00
Andrew Dolgov f9c1f8b0d4 pref-feeds: check for inactive feeds asynchronously 2015-08-12 16:19:42 +03:00
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
2015-08-12 14:09:46 +03:00
Andrew Dolgov b87744534a add plugin-based filter actions (see example plugin in attic)
bump schema
2015-08-11 23:28:42 +03:00
Andrew Dolgov 6810a1de42 use dijit form widget for attachments dropdown 2015-08-11 14:53:07 +03:00
Andrew Dolgov 176a489e54 use batch-based catching up in cdmExpandArticle() to reduce server load 2015-08-11 12:25:11 +03:00
Andrew Dolgov eaec06f950 prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
a bunch of other related fixes
2015-08-11 12:00:08 +03:00
Andrew Dolgov 95b493d68d partially revert previous because of navigation breakage in expanded mode, durrr 2015-08-11 11:31:50 +03:00
Andrew Dolgov b71add41d5 unfuck catchupbatchedarticles a bit 2015-08-11 10:12:22 +03:00