a7983d475e
fix phpstan warnings in classes/api.php
2021-11-13 17:51:26 +03:00
77b8dc7386
fix phpstan warnings in classes/feedparser.php
2021-11-13 17:48:52 +03:00
45431170b6
fix phpstan warnings in classes/db/migrations.php
2021-11-13 17:31:13 +03:00
3ba8d964b6
Address PHPStan warnings in 'classes/api.php'.
2021-11-13 14:15:20 +00:00
1ec003ce35
Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag).
2021-11-13 14:05:48 +00:00
25775bb407
Fix type of 'check_first_id' in Feeds '_format_headlines_list'.
2021-11-13 04:16:36 +00:00
d3a81f598b
Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0
2021-11-12 21:17:31 +00:00
2c41bc7fbc
Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'.
2021-11-12 06:16:18 +00:00
9db5e402a0
Address PHPStan warnings in 'classes/rpc.php'.
...
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'.
2021-11-12 05:42:55 +00:00
011c941e7c
Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'.
2021-11-12 05:24:02 +00:00
b0eb347839
Fix a warning in 'classes/counters.php'.
2021-11-12 05:04:55 +00:00
763515de79
Address PHPStan warnings in 'classes/feeds.php'.
...
Also some minor related tweaks in other classes.
2021-11-12 04:48:06 +00:00
5606e38bff
Update signature of handler 'csrf_ignore' to include types.
2021-11-12 02:01:31 +00:00
57bf56f794
Address PHPStan warnings in 'classes/article.php'.
...
Also related changes in some other classes.
2021-11-12 01:50:40 +00:00
a0f37c3206
Address PHPStan warnings in 'classes/pluginhost.php'.
2021-11-12 00:06:00 +00:00
95277fd099
Address PHPStan warnings in 'classes/labels.php'.
2021-11-11 22:28:13 +00:00
2d5603b196
Address PHPStan warnings in 'classes/diskcache.php'.
2021-11-11 22:07:32 +00:00
50997df57a
Address PHPStan warnings in 'inclasses/digest.php'.
2021-11-11 21:46:44 +00:00
728a71150a
Fix 'TimeHelper::make_local_datetime()' (null is allowed).
2021-11-11 21:33:12 +00:00
58ea0d4339
Address PHPStan warnings in 'classes/debug.php'.
2021-11-11 21:02:06 +00:00
2e3a9098b9
Address PHPStan warnings in 'classes/userhelper.php'.
2021-11-11 20:25:13 +00:00
f704d25ab1
Address PHPStan warnings in 'classes/timehelper.php'.
2021-11-11 20:12:47 +00:00
03495c11ed
Address PHPStan warnings in 'classes/sanitizer.php'.
...
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
2021-11-11 19:59:25 +00:00
3f8aaffd34
Address PHPStan warnings in 'classes/rssutils.php'.
...
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure).
2021-11-11 18:53:52 +00:00
eb068fbc47
Address PHPStan warnings in 'classes/prefs.php'.
2021-11-11 16:47:51 +00:00
14ca0f2ac0
Address PHPStan warnings in 'classes/counters.php'.
2021-11-11 12:26:30 +00:00
7a919a79d7
Fix some additional PHPStan warnings in UrlHelper.
2021-11-11 11:12:40 +00:00
4cc3374f9f
Initial go at PHPStan rule level 6.
2021-11-10 21:38:25 +00:00
9e8d69739f
add two helper account access levels:
...
- read only - can't subscribe to more feeds, feed updates are skipped
- disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
2021-11-10 20:44:51 +03:00
9dac9c5a0d
Address PHPStan warnings in 'classes/urlhelper.php'.
...
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array.
------ ---------------------------------------------------------------------
Line classes/urlhelper.php
------ ---------------------------------------------------------------------
66 Offset 'path' on array{scheme: string} in isset() does not exist.
165 Parameter #2 $associative of function get_headers expects bool, int
given.
167 Parameter #2 $associative of function get_headers expects bool, int
given.
278 Negated boolean expression is always true.
309 Negated boolean expression is always true.
------ ---------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
ac5a4f5937
Address PHPStan warning in 'classes/pref/users.php'.
...
------ -------------------------------
Line classes/pref/users.php
------ -------------------------------
170 If condition is always false.
------ -------------------------------
2021-11-01 21:10:27 +00:00
a38892d5d7
Address PHPStan warning in 'classes/pref/prefs.php'.
...
------ ------------------------------------------------
Line classes/pref/prefs.php
------ ------------------------------------------------
1328 Expression on left side of ?? is not nullable.
------ ------------------------------------------------
2021-11-01 21:10:27 +00:00
8a920a16e7
Address PHPStan warnings in 'classes/pluginhost.php'.
...
------ --------------------------------------------------------------------
Line classes/pluginhost.php
------ --------------------------------------------------------------------
16 Property PluginHost::$last_registered is never read, only written.
386 If condition is always true.
------ --------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
a7a59fe0e2
Address PHPStan warning in 'classes/logger/sql.php'.
...
------ --------------------------------------
Line classes/logger/sql.php
------ --------------------------------------
4 Property Logger_SQL::$pdo is unused.
------ --------------------------------------
2021-11-01 21:10:27 +00:00
72cf4f1f0d
Address PHPStan warning in 'classes/feeds.php'.
...
------ ------------------------------------
Line classes/feeds.php
------ ------------------------------------
8 Property Feeds::$params is unused.
------ ------------------------------------
2021-11-01 21:10:27 +00:00
5b17c44e70
Address PHPStan warning in 'classes/feeditem/common.php'.
...
------ ---------------------------------------------
Line classes/feeditem/common.php
------ ---------------------------------------------
194 No error to ignore is reported on line 194.
------ ---------------------------------------------
2021-11-01 21:10:27 +00:00
7d8837ca17
Address PHPStan warnings in 'classes/db.php'.
...
------ --------------------------------------------------
Line classes/db.php
------ --------------------------------------------------
7 Property Db::$link is unused.
86 Property Db::pdo (PDO) in empty() is not falsy.
------ --------------------------------------------------
2021-11-01 21:10:27 +00:00
77a98134b8
Address PHPStan warnings in 'classes/config.php'.
...
------ -----------------------------------------------------------------------
Line classes/config.php
------ -----------------------------------------------------------------------
3 Constant Config::_ENVVAR_PREFIX is unused.
177 Constant Config::_DEFAULTS is unused.
237 Property Config::$schema_version is never read, only written.
352 Property Config::$migrations (Db_Migrations) in empty() is not falsy.
------ -----------------------------------------------------------------------
2021-11-01 21:10:26 +00:00
76d8b1bf6f
HOOK_ARTICLE_BUTTON/HOOK_ARTICLE_LEFT_BUTTON: only try to parse markup if its actually there
2021-10-26 15:45:12 +03:00
933913410c
css: make plugin button container a flexbox
...
backend: pass plugin button generated code through domdocument to ensure
its correctness; set data-plugin-name attribute on children to make
them sortable via css
2021-10-24 20:11:49 +03:00
9f734c9050
minor phpstan tweaks
2021-10-22 13:49:08 +03:00
41245da8a6
pluginhost: update comments for HOOK_ constants to use phpdoc syntax; add HOOK_PRE_SUBSCRIBE
2021-10-22 13:24:10 +03:00
aead30a041
Fix undefined array key "output" when adding new label
2021-10-15 23:05:50 +00:00
a936e80630
OPML improvements/fixes:
...
* allow CLI import of OPML files (--opml-import)
* visualize OPML structure when importing
* add strict type hints to most OPML class methods
2021-10-15 10:06:00 +03:00
145fc31625
feed tree context menu: add an entry to open originating website
2021-10-10 22:08:17 +03:00
949e2ab4d2
properly sanitize video poster attribute
2021-09-24 08:40:06 +03:00
8ed927dbd2
OPML: multiple fixes
...
- remove unused integer indexes when exporting filters as JSON
- fix warning when importing filters without rules
- properly assign category IDs for category filter rules
- fix warning: check if outline attributes like xmlUrl are set before trying to use them
- fix warning: don't try to use libxml_disable_entity_loader on PHP 8
2021-09-08 09:04:15 +03:00
78ff7770d1
classes/opml: fix indentation; when importing, don't produce warning
...
on filters with no rules defined.
2021-09-08 08:12:13 +03:00
36e174750e
fix label ordering in feed tree
2021-09-02 08:21:05 +03:00
e8f9567d79
fix password recovery
2021-08-25 18:18:04 +02:00
a1173ab06a
block useless usort() E_DEPRECATED for the time being
2021-08-23 18:38:37 +03:00
2c931df77c
remove SELF_USER_AGENT custom constant, replaced with configurable Config::HTTP_USER_AGENT / Config::get_user_agent()
2021-08-23 10:56:31 +03:00
5c60254474
Pref_Feeds:calculate_children_count - fix operator precedence
2021-08-23 10:45:34 +03:00
0808123179
fix broken feed tree generation when categories are disabled
2021-08-18 21:02:58 +03:00
23b4152c9e
Make prefs feed search case-insensitive.
...
Previously the search query had to match lower title or feed_url (i.e. searching w/ uppercase wouldn't match).
2021-08-17 23:14:14 +00:00
992e9cd9e3
Use ORM more in 'classes/pref/feeds.php'.
2021-08-17 23:03:35 +00:00
73d14338ab
fix rendering of category filters on Uncategorized
2021-07-28 12:59:47 +03:00
14d57d9a14
Rewrite feed entry link as href content
2021-06-19 14:36:04 +02:00
1d4d3bc49c
Fix operator precedence
2021-06-18 12:52:29 +02:00
800ebd6373
revise previous a little bit more
2021-06-18 11:52:06 +03:00
69f261c41d
revise previous a little bit
2021-06-18 11:30:11 +03:00
e9c062a189
UrlHelper::rewrite_relative():
...
- support invoking specifying owner URL element/attribute
- restrict mailto/magnet/tel schemes for A href
- allow some data: base64 image types for IMG src
Sanitizer::sanitize():
- when checking href and src attributes, pass element tagname and attribute to rewrite_relative()
2021-06-18 11:20:57 +03:00
34807bacd4
Merge pull request 'Skip all urls with schemes different from base_url in rewrite_relative' ( #38 ) from klempin/tt-rss:fix/mailto into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/38
2021-06-17 18:51:35 +03:00
b3bedd0a94
Skip URI base on ALLOWED_RELATIVE_SCHEMES in rewrite_relative
2021-06-16 15:24:15 +02:00
8ed8a10965
add settings profile cloning
2021-06-16 14:24:57 +03:00
326850845d
UrlHelper::rewrite_relative: don't try to feed NULL to with_trailing_slash()
2021-05-21 17:10:32 +03:00
dff479af64
feeditem_atom: support xml:base for enclosures and entry content
...
UrlHelper::rewrite_relative: use base URL path if relative url path is not absolute (experimental)
2021-05-21 15:39:41 +03:00
8574532b7f
add hotkeys J/K to move between unread feeds
2021-05-20 20:32:00 +03:00
295fc1f88a
API: bump api level to 17
2021-05-18 16:55:00 +03:00
2adf364c2c
provide base configuration object in login response to skip on initial getConfig
2021-05-18 16:54:33 +03:00
9f6237a1b8
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-05-18 16:37:09 +03:00
57cd8acfc9
API: return custom sort types in getConfig
2021-05-18 16:36:56 +03:00
f423874e05
checking for PDO there is rather useless
2021-05-11 19:37:31 +03:00
b5a559a1a7
sanity check: in single user mode, only test for admin user if migrations have been completed
2021-05-11 19:36:25 +03:00
0c38dc8456
Improve missing token check
...
Avoid "E_NOTICE (8) (classes/userhelper.php:78) Undefined index:
csrf_token" in logs.
2021-05-11 10:32:59 +02:00
b2f888e386
include archived articles (which lack associated feed id) when browsing by tag
2021-05-07 19:15:10 +03:00
86300a0ca8
add urlhelper to extract youtube video id from url
2021-05-07 07:37:27 +03:00
cfd9e6b53b
FIX: public.php - Undefined index: feed_title
2021-04-19 10:43:30 +02:00
eadaaebd58
functions_enabled: trim spaces from disable_functions php ini setting
2021-04-12 11:55:19 +03:00
a61348e2b7
pluginhost: add profile_get/profile_set helpers
2021-04-09 14:01:30 +03:00
c0fba62fa0
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-03-29 19:48:10 +03:00
0acd33abe3
OTP: generate longer secrets, also make them easier to read/copy
2021-03-29 19:26:04 +03:00
5d5c034a90
Adjust quotation marks in search query before 'str_getcsv'.
...
This moves a potential first quotation mark to before the associated keyword to ensure 'str_getcsv' groups the key and value correctly. Without this 'str_getcsv' would split on potential spaces within the quoted value.
2021-03-27 00:18:05 +00:00
e3c51b0e6c
Revert "clip max displayed counter value to 9999 because of container node width"
...
This reverts commit c34a4c85bd
2021-03-23 11:51:17 +03:00
c34a4c85bd
clip max displayed counter value to 9999 because of container node width
2021-03-23 10:47:06 +03:00
0f6644880a
yet another flex feedtree attempt
2021-03-22 16:18:59 +03:00
711e8e70e0
Switch most of API to ORM
...
'updateArticle' was left as-is due to Idiorm not supporting efficient multi-row updating (i.e. it would do an UPDATE per row).
2021-03-20 14:00:53 +00:00
43ea36d030
prefs: allow setting email if it was previously blank
2021-03-17 19:50:04 +03:00
cd52ca80ab
Minor cleanup in 'Handler_Public->getProfiles'
2021-03-17 16:37:39 +00:00
baf3ecd4cf
Fix a couple of array index warnings in 'Handler_Public->forgotpass'
2021-03-17 16:30:17 +00:00
541a07250c
Switch 'Handler_Public->forgotpass' to ORM
2021-03-17 16:18:06 +00:00
f057c124d1
Switch 'Handler_Public->login' to ORM, fix 'Handler_Public->getProfiles'
2021-03-17 15:52:43 +00:00
7ea48f7a4b
Switch 'Handler_Public->rss' to ORM
2021-03-17 14:00:19 +00:00
b6ae280446
Switch 'Handler_Public->getProfiles' to ORM
2021-03-17 13:48:27 +00:00
401b22666d
Switch 'RSSUtils::update_basic_info' to ORM
2021-03-17 01:51:32 +00:00
a0e41f41a4
add svg loading indicators
2021-03-16 21:32:44 +03:00
44b274b6d4
remove published opml (use CLI instead)
2021-03-16 12:27:46 +03:00
39bbbef030
Fix E_NOTICE in `add_handler()`.
2021-03-15 16:20:38 -04:00
13210747d8
mailer: stop warning if to_name is unset (it's optional anyway)
2021-03-15 14:45:50 +03:00
3d801b1ac5
set orm and pdo mysql charset on connection
2021-03-13 17:56:52 +01:00
38ab3ef11c
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-03-13 11:22:06 +03:00
4ddcd54e8d
* limit progressfunction debugging to size quota exceeded notifications
...
* af_redditimgur: reparent generated iframes outside of post table
2021-03-13 11:18:59 +03:00
fa22e1bc35
Add coalescing operator to otp_enabled when changing user password
2021-03-12 20:26:24 +01:00
fcce1c443e
api: don't try to pass null site_url to Article::_get_image()
2021-03-12 17:15:45 +03:00
580eccd3da
throttle login attempts, controlled by Config::AUTH_MIN_INTERVAL
2021-03-12 09:35:01 +03:00
b9268fcc88
schema: add ttrss_users.last_auth_attempt
2021-03-12 09:19:50 +03:00
76a6060ca3
get_override_links: actually return overrides
2021-03-12 07:40:34 +03:00
f9a381ecca
grid: add a header icon (and a hotkey) to toggle article span entire row
2021-03-11 08:35:02 +03:00
27ab16b6dc
add Config::LOCAL_OVERRIDE_JS
2021-03-11 07:44:58 +03:00
324aef9f6f
route Logger:log() to user_error() if there's no adapter
2021-03-10 21:31:57 +03:00
b6033d0bbd
grid view tweaks
2021-03-10 11:44:16 +03:00
0b93d8d013
add hotkey to toggle grid view
2021-03-10 10:01:22 +03:00
ddfa39015e
experimental: add preference to show combined mode headlines as a 2 column grid
2021-03-10 08:33:56 +03:00
2160a86092
show E_COMPILE_ERROR in event log at higher severity levels
2021-03-09 17:00:51 +03:00
dd9d017f7d
add another coalesce for rule inverse
2021-03-09 13:42:28 +03:00
9b321be270
get_article_filters: set coalesce values for inverse and match_any_rule
2021-03-09 09:31:52 +03:00
4fe2e6bbf1
app password list: fix th/td alignment
2021-03-09 09:04:13 +03:00
bc7cb76379
describe global settings in classes/config.php
2021-03-08 20:39:11 +03:00
fed5158ec5
Default to null 'rv' for plugin update check.
...
Previously 'rv' was returned as an empty JS array, causing 'p.rv.git_status != 0' to evaluate to true and a misleading 'Ready to update' appearing for certain plugins.
2021-03-08 15:38:52 +00:00
ef03f8188c
api: add support for setting score (bump api level to 16)
2021-03-08 13:45:15 +03:00
c26f58d8a5
fix some php8 warnings
2021-03-08 11:16:32 +03:00
46b77fc6b7
fix digest preview not working on mysql because of a quoted LIMIT argument
2021-03-08 09:10:44 +03:00
603cc89638
check updates one plugin at a time
2021-03-07 20:11:54 +03:00
f4d0e7bb6d
* af_redditimgur: optionally import score
...
* add pluginhost->set_array() to set many plugin settings at once
2021-03-07 15:21:31 +03:00
72c04123d4
HOOK_ARTICLE_IMAGE: stop after first provided match
2021-03-07 14:19:00 +03:00
ac6a59914b
nsfw: support API clients
2021-03-07 13:22:38 +03:00
ffb93d72ac
fix previous to actually save enabled plugins
2021-03-07 12:28:24 +03:00
773bad1490
prevent list of enabled plugins resetting if saved while in search results
2021-03-07 12:26:33 +03:00
c036c27ec7
logger: use constants instead of hardcoded string literals
2021-03-07 09:05:23 +03:00
17650775d2
hide event log accordion pane if LOG_DESTINATION is not sql
2021-03-07 09:02:24 +03:00
5bb8714839
allow blank override values
2021-03-07 09:00:36 +03:00
d6fd0d5462
add some icons, remove some words
2021-03-06 23:51:48 +03:00
825e362f0e
Fix "array offset on value of type null" for $error and $old_error
...
I tried applying to only $error and only $old_error, but both appear to be needed.
Log entries:
E_NOTICE (8) classes/urlhelper.php:464 Trying to access array offset on value of type null
1. classes/urlhelper.php(464): ttrss_error_handler(8, Trying to access array offset on value of type null, classes/urlhelper.php, 464, [)
2. classes/rssutils.php(464): fetch([{"url":"https://some.url.rss ","login":"","pass":"","timeout":15,"last_modified":"Sat, 31 Aug 2019 15:22:31 GMT"})
3. update.php(235): update_rss_feed(732, 1)
2021-03-06 20:33:23 +01:00
68ecf52594
some small layout fixes, remove a few inline styles
2021-03-06 20:03:36 +03:00
473ea6255c
render list of plugins on the client
2021-03-06 18:14:25 +03:00
217922899d
set some more type hints
2021-03-06 15:23:54 +03:00
270f0c3132
general cleanup, set some type hints
2021-03-06 15:19:31 +03:00
63651bd91d
fix some leftover variables
2021-03-06 15:05:49 +03:00
e5469479c1
* don't try to update custom set feed favicons
...
* cleanup update_rss_feed() a bit, use ORM
2021-03-06 11:17:15 +03:00
2e8b064236
The type hint for 'DAEMON_MAX_CHILD_RUNTIME' should be T_INT
2021-03-05 17:32:32 +00:00
2cd159e2ce
use separate database column for OTP secrets (migrate previous format if needed)
2021-03-05 17:40:17 +03:00
2aed79d729
schema: add separate otp_secret column
2021-03-05 17:16:48 +03:00
5c1f9f31bd
add a bunch of button icons
2021-03-05 15:16:41 +03:00
fe06416f17
sessions: stop validating against hash of user agent because chromium is sending
...
different agent headers for whatever reason, example:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/88.0.4324.192 Safari/537.36
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/88.0.4324.104 Safari/537.36
seems to be related, at least, to App.postOpenWindow() hack.
2021-03-05 12:27:23 +03:00
98c75a9e43
don't check for plugin updates automatically on pane open
2021-03-05 10:25:32 +03:00
e8e6329040
rename unfairly prefixed get_enclosures() in feeditem
2021-03-05 09:35:24 +03:00
d016f7a499
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-03-04 19:50:32 +03:00
476965b161
show installed plugins in the installer list
2021-03-04 19:50:19 +03:00
9442ceb7bd
Fix Undefined index when using Single User Mode
2021-03-04 18:32:18 +03:00
f398fea414
shorten plugin list action buttons
2021-03-04 16:44:21 +03:00
6cf771f2bc
_get_available_plugins: decode as array
2021-03-04 15:57:11 +03:00
04128c7870
add search to plugin installer
2021-03-04 15:52:37 +03:00
4fda5ccd0e
fix a bunch of bookmarklets login forms not leading back
2021-03-04 13:40:54 +03:00
30765805fd
use orm for settings profiles stuff
2021-03-04 12:30:45 +03:00
31b29e0a56
log applied migrations
2021-03-04 11:33:25 +03:00
8f8ca49e4b
migrations: refuse to apply empty schema files
2021-03-04 10:13:29 +03:00
4ede76280b
migrations: don't try to use transactions on mysql
2021-03-04 09:43:12 +03:00
5eb0f3d640
bring back web dbupdate using new migrations system
2021-03-04 09:22:24 +03:00
c0fb0a5ec0
wip for db_migrations for core schema
2021-03-04 08:30:52 +03:00
921569e5da
support loading base schema as latest version
2021-03-04 07:26:05 +03:00
8256ab5dd9
wip: initial for db_migrations
2021-03-03 23:38:52 +03:00
0cb719a404
add basic local plugin uninstaller
2021-03-03 19:35:11 +03:00
cb7f322f09
add basic plugin installer (uses tt-rss.org)
2021-03-03 19:07:39 +03:00
06cb181f73
add update button for system plugins
2021-03-03 14:17:55 +03:00
75e659ba65
reduce Amount of Caps Used in Multiple Dialogs
2021-03-03 14:10:18 +03:00
0730128a97
add a send test email button to prefs/system
2021-03-03 14:00:18 +03:00
dbda996a7a
previous one was not good enough i guess
2021-03-03 11:37:58 +03:00
1aedd22306
config::make_self_url() strip index.php etc
2021-03-03 11:35:04 +03:00
50087df162
* remove _SKIP_SELF_URL_PATH_CHECKS
...
* simplify SELF_URL_PATH checks wrt trailing slash
2021-03-03 11:23:39 +03:00
6f93c45c28
use orm in some more places; prevent _get_cat_title from hitting the db for uncategorized
2021-03-02 20:07:31 +03:00
9ec0732942
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-03-02 19:21:27 +03:00
ba86c64d38
add digest preview button, also fix a bunch of bugs
2021-03-02 19:21:21 +03:00
c4b78ed0a6
Merge pull request 'Fix undefined array key warnings when using iOS app' ( #12 ) from sam302psu/tt-rss:undefined-array-keys into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/12
2021-03-02 19:00:08 +03:00
57fdf032e9
changed skip and limit to coalesce to 0 instead of ""
2021-03-02 18:44:13 +03:00
8f8142df29
Fix undefined array key warnings when using iOS app
...
Use coalesce operator and empty string/default value to fix undefined array key warnings filling up logs when using iOS app to access api.
2021-03-02 17:36:57 +03:00
386316aba1
update previous (comment)
2021-03-02 17:12:35 +03:00
1ab6ca57af
initialize Db object early because otherwise ORM might be used unconfigured
2021-03-02 17:11:38 +03:00
d6629ed188
move dbupdater to db/updater; move base SCHEMA_VERSION constant inside db/updater class
2021-03-02 15:03:01 +03:00
86b12fc06c
pluginhost: remove namespace classloader, plugins should use composer instead
2021-03-02 13:38:03 +03:00
08ff629af5
limit user data sent to frontend
2021-03-02 13:29:54 +03:00
d4ad483add
user editor: allow toggling otp
2021-03-02 13:27:41 +03:00
982bd838bf
use orm when setting personal data; fix some warnings in mailer class
2021-03-02 13:20:41 +03:00
30b94fb194
store widescreen mode setting in preferences instead of a cookie
2021-03-02 12:22:48 +03:00
1a7f724bfa
move around some methods in base plugins class
2021-03-02 12:15:42 +03:00
20d0cbff77
use ORM for article _labels_of/_feeds_of
2021-03-02 12:08:54 +03:00
f9888fc67f
use separate connection for logging
2021-03-02 11:37:56 +03:00
c4eaab8a31
feeds/_add_cat: use ORM
2021-03-02 10:24:15 +03:00
7cf12233d7
use ORM when subscribing feeds
2021-03-02 10:11:42 +03:00
dae0476159
sql logger: use orm
2021-03-02 09:58:50 +03:00
2005a7bf4f
revise behavior of Feeds::_cat_of
2021-03-02 09:36:44 +03:00
f097ae608d
article/redirect: use orm (cast id to int)
2021-03-02 09:31:57 +03:00
3bab5ca6b1
article/redirect: use orm
2021-03-02 09:31:23 +03:00
f195e86be3
don't rely on exit code when checking version (again)
2021-03-02 08:33:56 +03:00
84d8b08d1f
use orm for feed access keys
2021-03-02 08:26:37 +03:00
70adfd4a74
* sanitize: never rewrite relative links to our own prefix
...
* use Config::get_self_url() instead of get_self_url_prefix() in a bunch
of places
2021-03-02 08:16:41 +03:00
6f835ded78
remove (unused) prefs/toggleAdvanced
2021-03-02 08:10:06 +03:00
f56a4eab17
use orm for app password stuff
2021-03-02 08:08:48 +03:00
372e8e062c
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-03-02 07:35:31 +03:00
51ed72efab
use dash instead of space when invoking git to get version
2021-03-02 07:35:20 +03:00
03400bd8d4
Get the version as an array in RPC->checkforupdates.
2021-03-02 03:14:21 +00:00
031ee47a3e
don't try to pass string literal NOW() to ORM as a timestamp
2021-03-01 23:07:20 +03:00
b150e46a52
revert back load_filters-related changes
2021-03-01 22:25:41 +03:00
cd962dfa00
delete Article getScore (seems to be unused)
2021-03-01 20:32:44 +03:00
56f658711f
use orm for a bunch of short feed/cat queries
2021-03-01 20:25:53 +03:00
8b1a2406e6
userhelper: use orm for a few more user-related things
2021-03-01 19:32:27 +03:00
127a868e40
userhelper: use orm for some things
2021-03-01 19:03:21 +03:00
f38be747d1
initial for idiorm
2021-03-01 18:36:47 +03:00
f96abd2b52
generate_syndicated_feed: timestamp is a strtotime() expression, not an integer
2021-03-01 16:16:50 +03:00
6359259dbb
simplify internal authentication code and bump default algo to SSHA-512
2021-03-01 15:24:18 +03:00
320503dd39
move version-related stuff to Config; fix conditional feed requests
2021-03-01 13:43:37 +03:00
20a844085f
hide version for bundled plugins because it's meaningless; for everything else support showing version using git (if about[0] is null)
2021-03-01 12:11:42 +03:00
7ef72fe0dc
move startup checks to Config, set a bunch of @deprecated annotations
2021-03-01 10:20:21 +03:00
b05d4e3d9f
speed up plugin updating a bit, fix some phpstan warnings
2021-02-28 21:50:05 +03:00
afc7142250
move all $fetch globals to UrlHelper
2021-02-28 10:12:57 +03:00
e2cbb54b2c
plugin updater: show changes before updating
2021-02-28 09:46:06 +03:00
7f2fe465b0
add plugin updates checker into normal updates checker
2021-02-27 19:14:13 +03:00
d821e4b090
disable plugin update checking if CHECK_FOR_UPDATES is disabled
2021-02-27 17:40:17 +03:00
85f411d688
don't try to update all plugins
2021-02-27 17:35:00 +03:00
de63e3799a
only show plugin update buttons when needed
2021-02-27 17:29:41 +03:00
cf5c7c4f29
feeds/add: hide php8 warning
2021-02-27 14:16:49 +03:00
dfff2cef7b
add basic updater for stuff in plugins.local
2021-02-27 13:05:02 +03:00
5edcbf2e9b
add an option to disable conditional counters
2021-02-27 11:25:07 +03:00
6d06450649
don't rely only on label_cache contents when displaying headline labels
2021-02-27 10:58:11 +03:00
126b1fd2de
don't try to compare null value against anything
2021-02-26 21:48:20 +03:00
ebf16a36a1
remove a bunch of return type hints that didn't quite fit
2021-02-26 19:27:40 +03:00
ef8c3abd7e
Merge branch 'master' of git.tt-rss.org:fox/tt-rss
2021-02-26 19:17:27 +03:00
3fd7856543
* switch to composer for qrcode and otp dependencies
...
* move most OTP-related stuff into userhelper
* remove old phpqrcode and otphp libraries
2021-02-26 19:16:17 +03:00
c6fb62f384
Merge pull request 'fix-mysql-support' ( #10 ) from klatch/tt-rss:fix-mysql-support into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/10
2021-02-26 19:03:15 +03:00
1baf8c5217
Merge pull request 'Fix the type hint for '_DEFAULT_VIEW_MODE'.' ( #9 ) from wn/tt-rss:bugfix/default-view-mode-type into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/9
2021-02-26 15:46:48 +03:00
d577eb898c
when browsing by tags, return same set of columns as normally
2021-02-26 15:45:30 +03:00
c01b6e43fd
add pluginhost->get_array() shorthand
2021-02-26 15:33:59 +03:00
86513d70dd
Fix the type hint for '_DEFAULT_VIEW_MODE'.
2021-02-26 12:21:58 +00:00
e6a875b7e4
check if client-presented URL scheme is different from one configured in SELF_URL_PATH
2021-02-26 14:14:44 +03:00
4896874bda
_get_headlines: don't try to use _SESSION uid
2021-02-26 13:52:16 +03:00
26a6177bc9
upd previous
2021-02-26 12:36:15 +03:00
9689f884ab
add Prefs::DEBUG_HEADLINE_IDS
2021-02-26 12:34:50 +03:00
05f690c86b
add a separator before HEADLINES_NO_DISTINCT
2021-02-26 10:22:04 +03:00
3ab664f846
feeds/view: silence view_mode warning
2021-02-26 10:02:25 +03:00
f3d4bae32e
add an option to disable DISTINCT on headlines query (unless it's Labels category)
2021-02-26 09:57:34 +03:00
51142e1bf8
silence phpstan warning
2021-02-26 09:24:43 +03:00
7815a881e8
cleanup previous
2021-02-26 09:22:16 +03:00
56b10fea18
pass translations to frontend as a json object
2021-02-26 09:21:17 +03:00
fd9cd52929
prefs: migrate after cache has been filled to skip 1 pref request
2021-02-25 21:45:16 +03:00
a1ca62af50
cache schema version better
2021-02-25 21:42:05 +03:00
22ae284db4
reduce overall amount of unnecessary database queries
2021-02-25 21:27:16 +03:00
281f2efeb8
wrap prefs->migrate() into a transaction block
2021-02-25 19:21:29 +03:00
89ad25405e
userhelper: only notify failed login for actual logins
2021-02-25 18:26:37 +03:00
8915bd1b21
fix crash caused by non-numeric non-null _SESSION[uid] passed to sql logger
2021-02-25 18:21:48 +03:00
34c74400a4
enforce some stricter type checking for loggers
2021-02-25 17:10:03 +03:00
dcf0135285
logger: shorter syntax
2021-02-25 15:49:30 +03:00
59c14e9c00
api: remove base64 encoded passwords (wtf), log all authentication failures in userhelper
2021-02-25 15:39:46 +03:00
efd196839a
stop caching schema version entirely, fix some session_start() related warnings
2021-02-25 15:28:27 +03:00
1464abbbfc
prefs cleanup
2021-02-25 14:59:02 +03:00
c96172fa04
use constants in get_pref()/set_pref()
2021-02-25 14:49:58 +03:00
5aa05c90e1
pref-prefs: use constants instead of hardcoded strings
2021-02-25 14:45:11 +03:00
011e318947
prefs: don't try to do anything on schema < 141
2021-02-25 14:38:29 +03:00
6f02b1afd0
cleanup a bunch of old prefs code
2021-02-25 14:25:37 +03:00
7f18e8c33b
updater: show owner login instead of just uid
2021-02-25 14:23:56 +03:00
7869378436
deal with feed update scheduling w/ new prefs
2021-02-25 14:20:54 +03:00
2f2642bbd4
add fallback for feed_language on edit-feed-saving
...
Feed_language is only included in the form if running on pgsql, failing
the not null constraint on mysql setups.
2021-02-25 12:06:25 +01:00
00d0cb8c81
remove unused data from schema files
2021-02-25 12:58:00 +03:00
2621fe7955
fix get_pref always using default profile; remove unneeded code from db_prefs
2021-02-25 12:53:20 +03:00
bd2314170d
implement prefs UI based on new prefs class and a few more things
2021-02-25 12:46:13 +03:00
49a9afadce
add prefs caching
2021-02-25 10:34:59 +03:00
8026f3c3bd
initial (wip) for new prefs: add missing
2021-02-25 09:34:03 +03:00
988eb3ac91
initial (wip) for new prefs
2021-02-25 09:33:36 +03:00
2f14fa1bc3
add a hack to position labels on a dijit toolbar better
2021-02-24 15:53:47 +03:00
7f41228a71
decouple runtime-info object from counters
2021-02-24 15:40:19 +03:00
553548b689
request label counters conditionally
2021-02-24 15:07:31 +03:00
9313ebf2e7
fix warning in counters::get_feeds()
2021-02-24 13:25:26 +03:00
8b09e653e0
pass array to setScore
2021-02-24 12:10:09 +03:00
155e4f6125
pass a bunch of related arrays properly to backend
2021-02-24 12:07:25 +03:00
e468e5a589
cats_of: enforce owner_uid
2021-02-24 10:09:08 +03:00
6ea1430a04
no special counter handling for catchupAll
2021-02-24 10:01:39 +03:00
e6505b7d83
_cats_of: only request parents if needed
2021-02-24 09:56:59 +03:00
d6203bf350
try to calculate counters conditionally based on feed ids
2021-02-24 09:47:26 +03:00
a42e8aad97
add Errors.php
2021-02-23 22:31:43 +03:00
8d2e3c2528
drop errors.php and simplify error handling
2021-02-23 22:26:07 +03:00
85095f8a53
rename TTRSS_SESSION_NAME to SESSION_NAME
2021-02-23 17:01:25 +03:00
ab4dafa4be
config: add a type hint system
2021-02-23 16:58:48 +03:00
2ae0b7059f
cleanup some defined-stuff
2021-02-23 09:01:27 +03:00
77e6d589ff
allow adding custom config options
2021-02-22 23:20:52 +03:00
445ac1213c
finalize config:: migration; make config.php optional
2021-02-22 22:51:12 +03:00
211f699aa0
migrate the rest into Config::
2021-02-22 22:35:27 +03:00
383f4ca04a
add config.php
2021-02-22 21:49:09 +03:00
e4107ac952
wip: initial for config object
2021-02-22 21:47:48 +03:00
42173386b3
dirname(__FILE__) -> __DIR__
2021-02-22 17:38:46 +03:00
3f00502305
Merge pull request 'Let 'RSSUtils::check_feed_favicon' update existing favicons.' ( #6 ) from wn/tt-rss:check-feed-favicon into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/6
2021-02-22 17:25:02 +03:00
6fbf7ef368
Remove check against the old file in 'RSSUtils::check_feed_favicon'.
2021-02-22 12:06:27 +00:00
be4e7b1340
fix several issues reported by phpstan
2021-02-22 14:41:09 +03:00
33fff26869
reinstate HOOK_RENDER_ENCLOSURE
2021-02-22 10:00:50 +03:00
02a9485966
Try to limit max favicon size, don't store current/old in a var.
2021-02-21 23:30:31 +00:00
f6bfb89b29
pref-prefs: switch to new control shorthand in a few places
2021-02-21 23:18:32 +03:00
cb401af6f6
Let 'RSSUtils::check_feed_favicon' update existing favicons.
2021-02-21 19:01:40 +00:00
861a632ac7
move published opml JS code to pref helpers
2021-02-21 18:04:44 +03:00
521d0b65c7
batch feed editor: use tab layout, cleanup
2021-02-21 16:02:57 +03:00
d1328321be
move published OPML endpoint to public.php
2021-02-21 15:16:39 +03:00
2843b99171
minor filter UI layout fix
2021-02-21 13:08:34 +03:00
810afdaf5a
prevent creation of filter rules matching no feeds
2021-02-21 12:28:25 +03:00
3b8d69206c
deal with filter actions UI
2021-02-21 10:28:59 +03:00
94560132dd
for the most part, deal with filter rules UI
2021-02-21 09:35:07 +03:00
b4e96374bc
more filter stuff
2021-02-20 21:48:05 +03:00
590b1fc39e
a few more methods shuffled around
2021-02-20 18:21:36 +03:00
be91355c20
first for filter frontend overhaul
2021-02-20 18:15:08 +03:00
39be169f0b
also disable Article.completeTags
2021-02-20 13:39:17 +03:00
5c7416458f
rpc: disable completeLabels for now
2021-02-20 13:37:21 +03:00
22fe9b54d2
feed editor: use client dialog
2021-02-20 13:32:09 +03:00
9586c72a17
wip: feed editor client-side
2021-02-20 10:26:09 +03:00
545bcc3e4b
bookmarklets: cleanup some more markup
2021-02-20 08:49:40 +03:00
ce3e1756b3
Fix an undefined array key warning in 'catchupFeed'.
2021-02-19 21:46:30 +00:00
053b262aa7
rename public.php/cached_url to cached
2021-02-19 20:28:15 +03:00
fc0ebf0891
move bookmarklet-related methods out of public.php into the plugin
2021-02-19 20:21:36 +03:00
cf249d7e8c
modify classname helpers to use element.classList; fix feed debugger & share--get
2021-02-19 19:29:43 +03:00
737cffc241
render feed icon markup on the client
2021-02-19 17:40:11 +03:00
d445530fa0
format note on the client
2021-02-19 17:15:22 +03:00
4fa8450d38
setArticleTags: always return tags from the db
2021-02-19 15:50:42 +03:00
e73779fec1
render tags on the client
2021-02-19 15:31:50 +03:00
131f34648d
render headline labels on the client
2021-02-19 15:03:48 +03:00
660a1bbe01
* switch to xhr.post() almost everywhere
...
* call App.handlerpcjson() automatically on json request (if possible)
* show net/log indicators in prefs
2021-02-19 13:44:56 +03:00
bb4e4282f4
migrate a bunch of xhrPost invocations
2021-02-19 11:28:14 +03:00
00310d2d23
cleanup some unused code, fix App.byId() invoked by wrong name
2021-02-19 06:58:50 +03:00
dcfea9baac
properly validate feed editor dialog
2021-02-19 06:51:15 +03:00
c088e9d9d8
get rid of a few more prototype-isms
2021-02-18 22:23:06 +03:00
70fa423026
initial for RIP prototype/scriptaculous
2021-02-18 21:51:18 +03:00
75435aa960
user details: cleanup
2021-02-18 13:00:20 +03:00
39c0fe3697
shorten many invocations of Ajax.Request in inline form methods
2021-02-18 12:27:26 +03:00
466cba39d8
Merge branch 'master' of git.fakecake.org:fox/tt-rss
2021-02-18 11:54:29 +03:00
1adb9bb6b6
profiles: use client dialog; move related methods to pref-prefs
2021-02-18 11:54:22 +03:00
e4609c18ef
* add (disabled) shortcut syntax for plugin methods
...
* add controls shortcut for pluginhandler tags
* add similar shortcut for frontend
* allow plugins to selectively exclude their methods from CSRF checking
2021-02-17 21:44:21 +03:00
b16abc157e
* App: rename hidden to hidden_tag
...
* search: use client dialog
* add some form field helpers
2021-02-17 19:34:54 +03:00
92cb91e2e2
search dialog: bring back id of language dropdown
2021-02-17 16:33:28 +03:00
7be1e3ed38
pluginhandler: reject method requests without CSRF
2021-02-17 15:04:39 +03:00
e9c3118ddd
don't show E_USER_DEPRECATED on the frontpage
2021-02-17 14:14:10 +03:00
d439685895
pluginhandlers: post notice if pluginmethod is requested without CSRF token
2021-02-17 14:05:12 +03:00
273ada7353
* implement shortcut syntax for exposed plugin methods
...
* move shared article rendering code to share plugin
2021-02-17 09:59:14 +03:00
91e7969383
replace a few more controls to new style
2021-02-16 18:57:06 +03:00
24c79d91c2
controls_compat: comment out most of them
2021-02-16 18:53:56 +03:00
f58c49beaa
replace a few more controls to new style
2021-02-16 18:50:18 +03:00
9d7ba773ec
move session-related functions to their own namespace
2021-02-16 17:13:16 +03:00
7fad6ce651
move rgb/hsl functions to their own namespace
2021-02-16 17:07:23 +03:00
bdbbdbb0ed
rework controls to accept parameters as array
2021-02-16 16:59:21 +03:00
627af2c236
amend previous to fix actual underlying problem (double escaping)
2021-02-16 15:36:40 +03:00
1f5d81b77c
use a few more control helpers for checkboxes
2021-02-16 15:19:42 +03:00
22fc6871e8
remove backend helper and move its only function to rpc for the time being
2021-02-16 14:51:42 +03:00
d7127cead3
feed debugger: use hidden helpers; add button helpers
2021-02-16 14:42:27 +03:00
1f43d7916c
replace print_hidden with hidden_tag
2021-02-16 14:32:06 +03:00
26d6b84a57
add namespaced controls with unified naming; deprecated old-style control shortcuts
2021-02-16 14:23:00 +03:00
cb6b3584ce
pref-labels: remove unused code
2021-02-16 14:19:06 +03:00
cca84aedfd
_format_enclosures: always return entries array
2021-02-16 10:18:50 +03:00
88f7c4f1a5
feeds/view: fix php8 warning
2021-02-16 10:11:58 +03:00
Andrew Dolgov
wn_
Philip Klempin
jmechnich
fox
Jacek Tomasiak
Oliver Haucke
JustAMacUser
Jordan Galby
ltGuillaume
Threk
sam302psu
Frenck Lutke