Commit Graph

  • f537502fce deal with (most of) phpstan warnings in auth_internal and auth_remote Andrew Dolgov 2021-11-14 21:09:53 +0300
  • 67a89e861d Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6 Andrew Dolgov 2021-11-14 21:01:25 +0300
  • 9326ed605f Address PHPStan warning in 'classes/pref/filters.php'. wn_ 2021-11-14 17:59:02 +0000
  • 812f5f532e Address PHPStan warning in 'classes/mailer.php'. wn_ 2021-11-14 17:57:17 +0000
  • 91c9a73532 deal with phpstan warnings in plugins/cache_starred_images.php Andrew Dolgov 2021-11-14 20:59:49 +0300
  • 931a7533ce adjust some return types in urlhelper Andrew Dolgov 2021-11-14 20:53:30 +0300
  • 80291ffe0c deal with phpstan warnings in plugins/af_redditimgur.php Andrew Dolgov 2021-11-14 20:51:22 +0300
  • cfc31fc692 set annotations/types in af_psql_trgm Andrew Dolgov 2021-11-14 20:36:55 +0300
  • d17b79311e set missing annotations in af_comics Andrew Dolgov 2021-11-14 20:33:37 +0300
  • afdb4b0072 set phpdoc annotations for auth_base Andrew Dolgov 2021-11-14 20:26:05 +0300
  • 6bd6a14c20 revise phpdoc annotations for hook_sanitize() Andrew Dolgov 2021-11-14 20:19:12 +0300
  • f5c881586b Handle potentially null link, title, etc. in FeedParser. wn_ 2021-11-14 16:59:21 +0000
  • 7988c79bd4 plugin.php: add some minor method phpdoc corrections Andrew Dolgov 2021-11-14 18:05:31 +0300
  • 1b5c61ac85 userhelper: add a phpdoc variable class hint Andrew Dolgov 2021-11-14 18:02:20 +0300
  • 01b39d985c deal with the rest of warnings in plugin.php Andrew Dolgov 2021-11-14 18:00:03 +0300
  • dd7299b6d0 deal with a few more phpstan warnings re: base plugin class Andrew Dolgov 2021-11-14 17:19:35 +0300
  • 55729b4bbd fix HOOK_QUERY_HEADLINES being invoked with different argument lists, add some more phpdoc comments for base plugin class Andrew Dolgov 2021-11-14 17:07:47 +0300
  • af2f4460ce * deal with some phpstan warnings in base plugin class * arguably better hack for incompatible plugins causing E_COMPILE_ERROR Andrew Dolgov 2021-11-14 16:49:10 +0300
  • c3ffa08807 deal with phpstan warnings in update.php Andrew Dolgov 2021-11-14 16:15:31 +0300
  • 98af46addd prefs: properly report failures when loading plugin list Andrew Dolgov 2021-11-14 16:13:06 +0300
  • cf93371607 show safe mode warning dialog in prefs Andrew Dolgov 2021-11-14 16:12:27 +0300
  • 8b743f7249 xhr.json: properly pass failure callback to xhr.post() Andrew Dolgov 2021-11-14 16:07:52 +0300
  • d3d3bceec9 xhr.json: properly pass failure callback to xhr.post() Andrew Dolgov 2021-11-14 16:07:52 +0300
  • 9b5d199ad9 xhr.json: don't call resolve() on failed to parse data Andrew Dolgov 2021-11-14 15:57:43 +0300
  • fe1feca009 xhr.json: don't call resolve() on failed to parse data Andrew Dolgov 2021-11-14 15:57:43 +0300
  • 15af164f69 pluginhost: add a hack to not crash on an incompatible plugin more than once (per login) - UGLY Andrew Dolgov 2021-11-14 11:50:55 +0300
  • 0a2dcacbcf normalize some mismatching hook function definitions to match base Plugin class Andrew Dolgov 2021-11-14 11:11:49 +0300
  • 81a10f69bc deal with phpstan warnings related to base authentication modules Andrew Dolgov 2021-11-14 10:48:32 +0300
  • 5a50c333b2 Address PHPStan warnings in 'classes/pref/filters.php'. wn_ 2021-11-13 16:21:58 +0000
  • fe5ada7250 set some annotations on Plugin hook methods Andrew Dolgov 2021-11-13 20:07:13 +0300
  • 5e34fe17a7 experimental: bring back plugin hooks to Plugin base class once (to be improved/fixed with annotations later) Andrew Dolgov 2021-11-13 20:03:28 +0300
  • 618e96b793 deal with some warnings in plugins/trgm,readability and base plugin class Andrew Dolgov 2021-11-13 19:55:30 +0300
  • 03d0692268 no need to duplicate annotations Andrew Dolgov 2021-11-13 19:52:47 +0300
  • 68d7cf44f9 phpstan: deal with plugins/share Andrew Dolgov 2021-11-13 19:49:37 +0300
  • 37827427a2 rework previous Plugin changes as phpdoc annotations Andrew Dolgov 2021-11-13 19:41:50 +0300
  • 9845d5fd15 revert all plugin base class related changes to keep compatibility with extant plugins (for the time being) Andrew Dolgov 2021-11-13 19:36:24 +0300
  • edd476e7fe minor: correct $cat type in Pref_Feeds#calculate_children_count() wn_ 2021-11-13 16:00:56 +0000
  • a18473e4c0 Address PHPStan warnings in 'classes/pref/feeds.php'. wn_ 2021-11-13 15:50:37 +0000
  • b37a03fb31 Fix the type of Labels::update_cache() wn_ 2021-11-13 14:41:22 +0000
  • f2323bda81 fix phpstan warnings in classes/plugin-template.php Andrew Dolgov 2021-11-13 18:26:11 +0300
  • 70051742af experimental: also don't keep base plugin template as a non-analyzed file Andrew Dolgov 2021-11-13 18:21:04 +0300
  • b381e95792 experimental: auto-generate and add all plugin hook methods to Plugin class Andrew Dolgov 2021-11-13 18:18:05 +0300
  • 8a83f061bf fix phpstan warnings in classes/sanitizer.php Andrew Dolgov 2021-11-13 17:52:03 +0300
  • a7983d475e fix phpstan warnings in classes/api.php Andrew Dolgov 2021-11-13 17:51:26 +0300
  • 77b8dc7386 fix phpstan warnings in classes/feedparser.php Andrew Dolgov 2021-11-13 17:48:52 +0300
  • 45431170b6 fix phpstan warnings in classes/db/migrations.php Andrew Dolgov 2021-11-13 17:31:13 +0300
  • 3ba8d964b6 Address PHPStan warnings in 'classes/api.php'. wn_ 2021-11-13 14:15:20 +0000
  • 1ec003ce35 Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag). wn_ 2021-11-13 14:05:43 +0000
  • 25775bb407 Fix type of 'check_first_id' in Feeds '_format_headlines_list'. wn_ 2021-11-13 04:14:18 +0000
  • d3a81f598b Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0 wn_ 2021-11-12 21:17:31 +0000
  • 2c41bc7fbc Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'. wn_ 2021-11-12 06:16:18 +0000
  • 9db5e402a0 Address PHPStan warnings in 'classes/rpc.php'. wn_ 2021-11-12 05:42:55 +0000
  • 011c941e7c Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'. wn_ 2021-11-12 05:24:02 +0000
  • b0eb347839 Fix a warning in 'classes/counters.php'. wn_ 2021-11-12 05:04:55 +0000
  • f0ad5881c0 PHPStan warning fix in 'backend.php'. wn_ 2021-11-12 04:53:53 +0000
  • 734be4ebd1 Minor PHPStand warning fix in 'update.php'. wn_ 2021-11-12 04:51:35 +0000
  • 763515de79 Address PHPStan warnings in 'classes/feeds.php'. wn_ 2021-11-12 04:48:06 +0000
  • 5606e38bff Update signature of handler 'csrf_ignore' to include types. wn_ 2021-11-12 02:01:31 +0000
  • 57bf56f794 Address PHPStan warnings in 'classes/article.php'. wn_ 2021-11-12 01:50:40 +0000
  • a0f37c3206 Address PHPStan warnings in 'classes/pluginhost.php'. wn_ 2021-11-12 00:06:00 +0000
  • 95277fd099 Address PHPStan warnings in 'classes/labels.php'. wn_ 2021-11-11 22:28:13 +0000
  • 2d5603b196 Address PHPStan warnings in 'classes/diskcache.php'. wn_ 2021-11-11 22:07:32 +0000
  • 50997df57a Address PHPStan warnings in 'inclasses/digest.php'. wn_ 2021-11-11 21:46:44 +0000
  • cc220058e0 Address PHPStan warnings in 'include/functions.php'. wn_ 2021-11-11 21:37:34 +0000
  • 728a71150a Fix 'TimeHelper::make_local_datetime()' (null is allowed). wn_ 2021-11-11 21:33:12 +0000
  • 58ea0d4339 Address PHPStan warnings in 'classes/debug.php'. wn_ 2021-11-11 21:02:06 +0000
  • 00b86bac39 Address PHPStan warnings in 'include/errorhandler.php'. wn_ 2021-11-11 20:46:42 +0000
  • e4b8e2d063 Address PHPStan warnings in 'include/controls_compat.php'. wn_ 2021-11-11 20:40:30 +0000
  • d2ccbecea6 Address PHPStan warnings in 'include/controls.php'. wn_ 2021-11-11 20:36:37 +0000
  • 2e3a9098b9 Address PHPStan warnings in 'classes/userhelper.php'. wn_ 2021-11-11 20:25:13 +0000
  • f704d25ab1 Address PHPStan warnings in 'classes/timehelper.php'. wn_ 2021-11-11 20:12:47 +0000
  • 03495c11ed Address PHPStan warnings in 'classes/sanitizer.php'. wn_ 2021-11-11 19:59:25 +0000
  • 3f8aaffd34 Address PHPStan warnings in 'classes/rssutils.php'. wn_ 2021-11-11 18:53:52 +0000
  • eb068fbc47 Address PHPStan warnings in 'classes/prefs.php'. wn_ 2021-11-11 16:47:51 +0000
  • bf2bb875ab Address PHPStan warnings in 'include/sessions.php'. wn_ 2021-11-11 15:57:03 +0000
  • 14ca0f2ac0 Address PHPStan warnings in 'classes/counters.php'. wn_ 2021-11-11 12:26:30 +0000
  • 0f324b77df Address PHPStan warning and tweak 'tasks'+'interval' handling in 'update_daemon2.php'. wn_ 2021-11-11 12:11:30 +0000
  • 7a919a79d7 Fix some additional PHPStan warnings in UrlHelper. wn_ 2021-11-11 11:08:04 +0000
  • bf53dfa515 Don't use 'mixed' directly (PHP 8+). wn_ 2021-11-10 21:53:28 +0000
  • 4cc3374f9f Initial go at PHPStan rule level 6. wn_ 2021-11-10 21:38:25 +0000
  • 87a30d88d3 plugin cleanup re: phpstan 1.0 warnings Andrew Dolgov 2021-11-10 20:58:40 +0300
  • 9e8d69739f add two helper account access levels: - read only - can't subscribe to more feeds, feed updates are skipped - disabled - can't login define used access levels as UserHelper constants and refactor code to use them instead of hardcoded numbers Andrew Dolgov 2021-11-10 20:44:51 +0300
  • 7a52560e4e Merge pull request 'PHPStan 1.0.0 and related warning fixes' (#49) from wn/tt-rss:feature/phpstan-1.0.0-and-fixes into master fox 2021-11-02 08:37:11 +0300
  • 57436ee0c1 Address PHPStan warning in 'update.php'. wn_ 2021-11-01 20:38:26 +0000
  • 3cc60a0219 Address PHPStan warnings in 'include/colors.php'. wn_ 2021-11-01 20:37:53 +0000
  • 9dac9c5a0d Address PHPStan warnings in 'classes/urlhelper.php'. wn_ 2021-11-01 20:36:48 +0000
  • ac5a4f5937 Address PHPStan warning in 'classes/pref/users.php'. wn_ 2021-11-01 20:33:46 +0000
  • a38892d5d7 Address PHPStan warning in 'classes/pref/prefs.php'. wn_ 2021-11-01 20:32:43 +0000
  • 8a920a16e7 Address PHPStan warnings in 'classes/pluginhost.php'. wn_ 2021-11-01 20:31:42 +0000
  • a7a59fe0e2 Address PHPStan warning in 'classes/logger/sql.php'. wn_ 2021-11-01 20:30:55 +0000
  • 72cf4f1f0d Address PHPStan warning in 'classes/feeds.php'. wn_ 2021-11-01 20:30:24 +0000
  • 5b17c44e70 Address PHPStan warning in 'classes/feeditem/common.php'. wn_ 2021-11-01 20:29:38 +0000
  • 7d8837ca17 Address PHPStan warnings in 'classes/db.php'. wn_ 2021-11-01 20:28:00 +0000
  • 77a98134b8 Address PHPStan warnings in 'classes/config.php'. wn_ 2021-11-01 16:03:28 +0000
  • 1584d00891 Bump PHPStan to 1.0.0 wn_ 2021-11-01 15:36:56 +0000
  • 9714c4fbcf Merge branch 'weblate-integration' Andrew Dolgov 2021-10-29 14:10:02 +0300
  • 76d8b1bf6f HOOK_ARTICLE_BUTTON/HOOK_ARTICLE_LEFT_BUTTON: only try to parse markup if its actually there Andrew Dolgov 2021-10-26 15:45:12 +0300
  • 933913410c css: make plugin button container a flexbox backend: pass plugin button generated code through domdocument to ensure its correctness; set data-plugin-name attribute on children to make them sortable via css Andrew Dolgov 2021-10-24 20:11:49 +0300
  • 9f734c9050 minor phpstan tweaks Andrew Dolgov 2021-10-22 13:49:08 +0300
  • 3b70d1f622 require phpstan via composer Andrew Dolgov 2021-10-22 13:42:29 +0300