wn_
78acf18b70
Address PHPStan warnings in FeedItem classes.
2021-11-15 02:40:45 +00:00
wn_
8943604aad
Change the param type for UserHelper::hash_password() $algo to appease PHPStan.
...
PHPStan was complaining in 'plugins/auth_internal/init.php' due to UserHelper::hash_password() being passed a string, rather than a UserHelper::HASH_ALGO_* constant. Just switching the param to string for now.
2021-11-14 22:44:48 +00:00
wn_
324d926eb4
Also fix the param signature for Plugin#hook_hotkey_info()
2021-11-14 22:16:16 +00:00
wn_
12f9df1066
Fix the return signature for Plugin#hook_hotkey_info()
2021-11-14 22:11:27 +00:00
wn_
8f749fe61b
Address PHPStan warnings in 'include/colors.php'.
...
Also some formatting for readability.
2021-11-14 21:06:06 +00:00
wn_
6d438c5a77
Address PHPStan warning in 'classes/pref/users.php'.
2021-11-14 20:27:17 +00:00
wn_
5632d75a45
Address PHPStan warning in 'classes/pref/system.php'.
2021-11-14 20:26:21 +00:00
wn_
abab2a94e8
Address PHPStan warning in 'classes/pref/prefs.php'.
...
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
wn_
b8f0627a0e
Address PHPStan warning in 'classes/pref/labels.php'.
2021-11-14 20:13:09 +00:00
Andrew Dolgov
56cf425e45
revise prototype for hook_enclosure_imported
2021-11-14 23:03:25 +03:00
Andrew Dolgov
c3fbf56984
deal with most of warnings in plugins/af_readability
2021-11-14 21:25:56 +03:00
Andrew Dolgov
242cf916ef
deal with phpstan warnings in plugins/note, nsfw, and share
2021-11-14 21:20:59 +03:00
Andrew Dolgov
5f808051b2
deal with phpstan warnings in auto_assign_labels and bookmarklets
2021-11-14 21:14:21 +03:00
Andrew Dolgov
f537502fce
deal with (most of) phpstan warnings in auth_internal and auth_remote
2021-11-14 21:09:53 +03:00
Andrew Dolgov
67a89e861d
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
2021-11-14 21:01:25 +03:00
wn_
9326ed605f
Address PHPStan warning in 'classes/pref/filters.php'.
2021-11-14 17:59:57 +00:00
wn_
812f5f532e
Address PHPStan warning in 'classes/mailer.php'.
2021-11-14 17:59:57 +00:00
Andrew Dolgov
91c9a73532
deal with phpstan warnings in plugins/cache_starred_images.php
2021-11-14 20:59:49 +03:00
Andrew Dolgov
931a7533ce
adjust some return types in urlhelper
2021-11-14 20:53:30 +03:00
Andrew Dolgov
80291ffe0c
deal with phpstan warnings in plugins/af_redditimgur.php
2021-11-14 20:51:22 +03:00
Andrew Dolgov
cfc31fc692
set annotations/types in af_psql_trgm
2021-11-14 20:36:55 +03:00
Andrew Dolgov
d17b79311e
set missing annotations in af_comics
2021-11-14 20:33:37 +03:00
Andrew Dolgov
afdb4b0072
set phpdoc annotations for auth_base
2021-11-14 20:26:05 +03:00
Andrew Dolgov
6bd6a14c20
revise phpdoc annotations for hook_sanitize()
2021-11-14 20:19:12 +03:00
wn_
f5c881586b
Handle potentially null link, title, etc. in FeedParser.
2021-11-14 16:59:21 +00:00
Andrew Dolgov
7988c79bd4
plugin.php: add some minor method phpdoc corrections
2021-11-14 18:05:31 +03:00
Andrew Dolgov
1b5c61ac85
userhelper: add a phpdoc variable class hint
2021-11-14 18:02:20 +03:00
Andrew Dolgov
01b39d985c
deal with the rest of warnings in plugin.php
2021-11-14 18:00:03 +03:00
Andrew Dolgov
dd7299b6d0
deal with a few more phpstan warnings re: base plugin class
2021-11-14 17:19:35 +03:00
Andrew Dolgov
55729b4bbd
fix HOOK_QUERY_HEADLINES being invoked with different argument lists, add some more phpdoc comments for base plugin class
2021-11-14 17:07:47 +03:00
Andrew Dolgov
af2f4460ce
* deal with some phpstan warnings in base plugin class
...
* arguably better hack for incompatible plugins causing E_COMPILE_ERROR
2021-11-14 16:49:10 +03:00
Andrew Dolgov
c3ffa08807
deal with phpstan warnings in update.php
2021-11-14 16:15:31 +03:00
Andrew Dolgov
98af46addd
prefs: properly report failures when loading plugin list
2021-11-14 16:13:06 +03:00
Andrew Dolgov
cf93371607
show safe mode warning dialog in prefs
2021-11-14 16:12:27 +03:00
Andrew Dolgov
8b743f7249
xhr.json: properly pass failure callback to xhr.post()
2021-11-14 16:08:01 +03:00
Andrew Dolgov
d3d3bceec9
xhr.json: properly pass failure callback to xhr.post()
2021-11-14 16:07:52 +03:00
Andrew Dolgov
9b5d199ad9
xhr.json: don't call resolve() on failed to parse data
2021-11-14 15:57:56 +03:00
Andrew Dolgov
fe1feca009
xhr.json: don't call resolve() on failed to parse data
2021-11-14 15:57:43 +03:00
Andrew Dolgov
15af164f69
pluginhost: add a hack to not crash on an incompatible plugin more than once (per login) - UGLY
2021-11-14 11:50:55 +03:00
Andrew Dolgov
0a2dcacbcf
normalize some mismatching hook function definitions to match base Plugin class
2021-11-14 11:11:49 +03:00
Andrew Dolgov
81a10f69bc
deal with phpstan warnings related to base authentication modules
2021-11-14 10:48:32 +03:00
wn_
5a50c333b2
Address PHPStan warnings in 'classes/pref/filters.php'.
2021-11-14 00:59:19 +00:00
Andrew Dolgov
fe5ada7250
set some annotations on Plugin hook methods
2021-11-13 20:07:13 +03:00
Andrew Dolgov
5e34fe17a7
experimental: bring back plugin hooks to Plugin base class once (to be improved/fixed with annotations later)
2021-11-13 20:03:28 +03:00
Andrew Dolgov
618e96b793
deal with some warnings in plugins/trgm,readability and base plugin class
2021-11-13 19:55:30 +03:00
Andrew Dolgov
03d0692268
no need to duplicate annotations
2021-11-13 19:52:47 +03:00
Andrew Dolgov
68d7cf44f9
phpstan: deal with plugins/share
2021-11-13 19:49:37 +03:00
Andrew Dolgov
37827427a2
rework previous Plugin changes as phpdoc annotations
2021-11-13 19:41:50 +03:00
Andrew Dolgov
9845d5fd15
revert all plugin base class related changes to keep compatibility with extant plugins (for the time being)
2021-11-13 19:36:26 +03:00
wn_
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
2021-11-13 16:00:59 +00:00