Commit Graph

1613 Commits

Author SHA1 Message Date
Chih-Hsuan Yen 40afee5d12 Fix calculating average color for *.ico
Currently colorPalette() always fails for *.ico due to a logic error.
It's a regression from 8f749fe61b.
2023-02-10 18:20:42 +08:00
Andrew Dolgov c30b24d09f
deal with type errors in batch feed editor properly, un-deprecate PDO wrapper functions and document them for posterity 2022-12-30 19:51:34 +03:00
Andrew Dolgov a16acd65fc
batch feed editor:
- fix some field changes not applying because of DB type errors
 - rework to use bound vars instead of sql query concatenation
deprecate: checkbox_to_sql_bool(), bool_to_sql_bool()
2022-12-30 19:07:15 +03:00
jmechnich 017bf9777f Return true in custom error handler for proper suppression 2022-10-10 14:56:28 +02:00
jmechnich 504d0afd35 Fix handling of suppressed errors 2022-10-01 10:28:36 +02:00
Andrew Dolgov c0e77241d3
update gl translation label (2) 2022-08-22 19:10:06 +03:00
Andrew Dolgov 70f500bee9
update gl translation label 2022-08-22 19:08:59 +03:00
Andrew Dolgov aca16a3448
enable gl translation (Galician) 2022-08-21 18:42:06 +03:00
wn_ c301053965 Use the null coalescing assignment operator in various places. 2022-08-12 18:21:38 +00:00
Andrew Dolgov 7c45b3f789
* add HOOK_LOGINFORM_ADDITIONAL_BUTTONS
* allow plugins to inject JS code into login form
2022-07-24 16:33:28 +03:00
Andrew Dolgov b17b4a4b9e fix be locale label 2022-04-18 13:04:29 +03:00
Andrew Dolgov ddb6f4316c enable Belarusian translation (proper UI label pending) 2022-04-18 10:49:18 +03:00
Andrew Dolgov 77f39d65b5 * Feeds::_get_counters - fix retrieving unread for tags
* mark several symbols as @deprecated properly
 * replace uses of (deprecated) getFeedUnread() with Feeds::_get_counters()
2022-02-20 11:04:40 +03:00
Andrew Dolgov a109e89983 mark clean() return value as nullable 2021-11-23 17:01:08 +03:00
Andrew Dolgov 7cfc30ac25 format_backtrace: revise previous to only try truncating/adding actual strings 2021-11-20 16:15:10 +03:00
Andrew Dolgov 3323ae78ce * sql_bool_to_bool: make parameter nullable
* errorhandler: don't try to truncate null strings
 * UrlHelper::rewrite_relative: fix undefined offset warnings for URLs
that lack schema/host (data: etc)
2021-11-20 16:11:44 +03:00
wn_ 8f749fe61b Address PHPStan warnings in 'include/colors.php'.
Also some formatting for readability.
2021-11-14 21:06:06 +00:00
wn_ abab2a94e8 Address PHPStan warning in 'classes/pref/prefs.php'.
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
wn_ cc220058e0 Address PHPStan warnings in 'include/functions.php'. 2021-11-11 21:37:34 +00:00
wn_ 00b86bac39 Address PHPStan warnings in 'include/errorhandler.php'. 2021-11-11 20:47:29 +00:00
wn_ e4b8e2d063 Address PHPStan warnings in 'include/controls_compat.php'. 2021-11-11 20:47:20 +00:00
wn_ d2ccbecea6 Address PHPStan warnings in 'include/controls.php'. 2021-11-11 20:47:12 +00:00
wn_ f704d25ab1 Address PHPStan warnings in 'classes/timehelper.php'. 2021-11-11 20:12:47 +00:00
wn_ 03495c11ed Address PHPStan warnings in 'classes/sanitizer.php'.
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
2021-11-11 19:59:25 +00:00
wn_ bf2bb875ab Address PHPStan warnings in 'include/sessions.php'. 2021-11-11 15:57:03 +00:00
Andrew Dolgov 9e8d69739f add two helper account access levels:
- read only - can't subscribe to more feeds, feed updates are skipped
 - disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
2021-11-10 20:44:51 +03:00
wn_ 3cc60a0219 Address PHPStan warnings in 'include/colors.php'.
------ ------------------------------------------------------------------
Line   include/colors.php
------ ------------------------------------------------------------------
215    Variable $out might not be defined.
223    Parameter #3 $pad_string of function str_pad expects string, int
        given.
255    Variable $h might not be defined.
317    Variable $img might not be defined.
------ ------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
Andrew Dolgov 8ed927dbd2 OPML: multiple fixes
- remove unused integer indexes when exporting filters as JSON
 - fix warning when importing filters without rules
 - properly assign category IDs for category filter rules
 - fix warning: check if outline attributes like xmlUrl are set before trying to use them
 - fix warning: don't try to use libxml_disable_entity_loader on PHP 8
2021-09-08 09:04:15 +03:00
Andrew Dolgov 2c931df77c remove SELF_USER_AGENT custom constant, replaced with configurable Config::HTTP_USER_AGENT / Config::get_user_agent() 2021-08-23 10:56:31 +03:00
Andrew Dolgov 44c5d0feba prolong PHP session cookie automatically to stop hard logouts after SESSION_COOKIE_LIFETIME expires 2021-06-25 12:12:05 +03:00
Andrew Dolgov 4e9c3500fb clarify some @deprecation notices 2021-06-17 11:27:00 +03:00
Andrew Dolgov dff479af64 feeditem_atom: support xml:base for enclosures and entry content
UrlHelper::rewrite_relative: use base URL path if relative url path is not absolute (experimental)
2021-05-21 15:39:41 +03:00
Andrew Dolgov e3c4724dc1 use database-backed sessions in single user mode 2021-05-11 19:21:53 +03:00
Andrew Dolgov 27ab16b6dc add Config::LOCAL_OVERRIDE_JS 2021-03-11 07:44:58 +03:00
Andrew Dolgov cfb4882591 cleanup javascript_tag and stylesheet_tag 2021-03-08 17:39:24 +03:00
Andrew Dolgov 17650775d2 hide event log accordion pane if LOG_DESTINATION is not sql 2021-03-07 09:02:24 +03:00
Andrew Dolgov ecb94ec23d login page: fix a warning if return is unset 2021-03-05 15:35:48 +03:00
Andrew Dolgov fe06416f17 sessions: stop validating against hash of user agent because chromium is sending
different agent headers for whatever reason, example:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/88.0.4324.192 Safari/537.36

Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/88.0.4324.104 Safari/537.36

seems to be related, at least, to App.postOpenWindow() hack.
2021-03-05 12:27:23 +03:00
Andrew Dolgov 4fda5ccd0e fix a bunch of bookmarklets login forms not leading back 2021-03-04 13:40:54 +03:00
Andrew Dolgov 5eb0f3d640 bring back web dbupdate using new migrations system 2021-03-04 09:22:24 +03:00
Andrew Dolgov e19570f422 sessions: don't check schema version 2021-03-04 08:32:19 +03:00
Andrew Dolgov d6629ed188 move dbupdater to db/updater; move base SCHEMA_VERSION constant inside db/updater class 2021-03-02 15:03:01 +03:00
Andrew Dolgov 70adfd4a74 * sanitize: never rewrite relative links to our own prefix
* use Config::get_self_url() instead of get_self_url_prefix() in a bunch
of places
2021-03-02 08:16:41 +03:00
Andrew Dolgov 8b1a2406e6 userhelper: use orm for a few more user-related things 2021-03-01 19:32:27 +03:00
Andrew Dolgov 6359259dbb simplify internal authentication code and bump default algo to SSHA-512 2021-03-01 15:24:18 +03:00
Andrew Dolgov 320503dd39 move version-related stuff to Config; fix conditional feed requests 2021-03-01 13:43:37 +03:00
Andrew Dolgov 1e6973307c we don't need to initialize urlhelper properties 2021-03-01 10:23:44 +03:00
Andrew Dolgov 7ef72fe0dc move startup checks to Config, set a bunch of @deprecated annotations 2021-03-01 10:20:21 +03:00
Andrew Dolgov 1bb0d9b603 sanity_check: config.php is now optional, also cleanup some error messages 2021-02-28 17:42:21 +03:00
Andrew Dolgov afc7142250 move all $fetch globals to UrlHelper 2021-02-28 10:12:57 +03:00