Commit Graph

10 Commits

Author SHA1 Message Date
Michael Kuhn bbb8a2e873 Fix missed hotkeys in googlereaderkeys plugin 2019-03-17 17:39:20 +01:00
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
2019-03-11 12:01:27 +01:00
Andrew Dolgov 21ce7d9ec0 update phpmd ruleset to use (subset) of cleancode
fix various minor issues reported by static analysis
remove redundant php closing tag from several more files
2017-04-26 20:57:36 +03:00
Mike Frysinger 68ad3aea9d googlereaderkeys: add o/enter/? keys like Google Reader 2013-05-19 04:09:47 -04:00
Andrew Dolgov 106a3de91c plugins: bump API version 2013-04-19 17:31:56 +04:00
Andrew Dolgov 6322ac79a0 remove $link 2013-04-17 16:48:41 +04:00
Mike Stegeman fb5364bc16 Modify googlereaderkeys plugin with mark unread toggle. 2013-03-22 06:40:39 -06:00
Andrew Dolgov 5b18c93622 tweak hotkey map notation to allow stuff like shift-arrows 2013-03-18 20:59:48 +04:00
Mark Waters 733ef11e09 Added requested article_scroll_up and article_scroll_down keys. 2013-03-16 12:06:59 +01:00
Andrew Dolgov 3afc03b530 add plugins/googlereaderkeys 2013-03-12 11:35:41 +04:00