Commit Graph

619 Commits

Author SHA1 Message Date
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
2019-03-11 12:01:27 +01:00
Andrew Dolgov 19f162dbe3 css: insensitive -> text-muted 2019-03-08 10:11:57 +03:00
Andrew Dolgov 684a1368e9 toggle_sidebar: switch icon on click 2019-03-06 12:52:09 +03:00
Andrew Dolgov 2b54413599 af_redditimgur: update prefs markup 2019-03-05 19:45:48 +03:00
Andrew Dolgov fb62f2b970 toggle_sidebar: use hamburger icon 2019-03-04 21:55:35 +03:00
Andrew Dolgov cee76f4d49 bookmarklets: add more info link 2019-02-26 08:15:58 +03:00
Andrew Dolgov cbd119c7a3 pref-prefs: fix markup 2019-02-25 19:11:17 +03:00
Andrew Dolgov 54c1b5c611 fill in some missing doctypes; use short doctype where it wasn't 2019-02-23 13:49:40 +03:00
Andrew Dolgov abfd552962 plugins: update markup 2019-02-22 12:48:02 +03:00
Andrew Dolgov 335147e572 dialogs: use semantic markup instead of dlgsec stuff
continue unifying quoting style for html strings
2019-02-22 10:48:56 +03:00
Andrew Dolgov 55b032a6bd plugins/share: update layout 2019-02-22 06:35:14 +03:00
Andrew Dolgov 4e253add8c UI: add some more info links to relevant wiki pages; minor layout updates 2019-02-21 16:21:16 +03:00
Andrew Dolgov fd8f8c7b3e af_readability: construct readability object inside try-catch block 2019-02-21 06:52:15 +03:00
Andrew Dolgov 1a8770f8f4 add plugins/hotkeys_noscroll 2019-02-20 15:32:53 +03:00
Andrew Dolgov 4d9141d762 simplify dlgSec-related markup 2019-02-20 14:37:59 +03:00
Andrew Dolgov 3b057d5f02 OTP: css fixes 2019-02-19 20:17:13 +03:00
Andrew Dolgov 1d2da64572 af_redditimgur: apparently imgur has link rel='image_src' now, let's use it 2019-02-06 16:24:31 +03:00
Andrew Dolgov a5517fe857 fetch_file_contents: decompress gzipped data
af_readability: remove utf8 preamble hack
2018-12-21 17:50:16 +03:00
Andrew Dolgov 0efb6e1bc2 remove pub_set.png, replace usages with iconfont 2018-12-14 17:30:41 +03:00
Andrew Dolgov e53959322b plugins/embed_original: move to attic repo 2018-12-13 09:54:41 +03:00
Andrew Dolgov 1b4567a973 remove vf_shared pixmap 2018-12-09 16:51:44 +03:00
Andrew Dolgov e54db22998 close_button: use vector icon 2018-12-09 16:35:00 +03:00
Andrew Dolgov 607ede512f center previously centered text on single line dialog panels 2018-12-09 16:27:29 +03:00
Andrew Dolgov 4036b479f9 share plugin: fix unshare() 2018-12-09 11:48:29 +03:00
Andrew Dolgov a400a8ffc1 add PluginHost.HOOK_INIT_COMPLETE (and make no_title_counters use it) 2018-12-08 20:06:07 +03:00
Andrew Dolgov b96beeeda7 bookmarklets: show pref link-buttons properly 2018-12-08 15:55:35 +03:00
Andrew Dolgov bd66a9ef28 render article on the client using headlines data 2018-12-08 09:32:14 +03:00
Andrew Dolgov 7adf937936 shorten_expanded: use dojo button, don't break attachment dropdown, other fixes 2018-12-07 22:56:34 +03:00
Andrew Dolgov 165eea32e8 af_psql_trgm: fix parameter not being quoted properly in showrelated 2018-12-07 18:02:42 +03:00
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
2018-12-07 14:03:33 +03:00
Andrew Dolgov b68ee9adf4 af_comics: add Stonetoss 2018-12-07 12:02:38 +03:00
Andrew Dolgov 4cbc62d2a5 article note format updates 2018-12-06 20:55:51 +03:00
Andrew Dolgov 836a949407 af_psql_trgm: fix showrelated() layout 2018-12-06 12:13:59 +03:00
Andrew Dolgov bc2d40009b plugins/mail, mailto: update icons 2018-12-06 08:59:15 +03:00
Andrew Dolgov 814e49f8f7 add icons to accordion panels in preferences
fix typo in pref-prefs closing panel tag
2018-12-06 08:56:28 +03:00
Andrew Dolgov c700345c96 trgm: use vector icon, replace recently read icon 2018-12-05 22:48:14 +03:00
Andrew Dolgov 4996269d55 remove mark_button (just use hotkeys or main icon, why is this even needed?) 2018-12-05 22:36:12 +03:00
Andrew Dolgov 94bc24ff31 share by url stuff: use link icon instead of share 2018-12-05 22:33:09 +03:00
Andrew Dolgov 37205321d9 remove share.png 2018-12-05 22:28:09 +03:00
Andrew Dolgov 17d9e14dde toggle_sidebar: use icon-font 2018-12-05 22:27:17 +03:00
Andrew Dolgov 9703162f57 plugins: note,shared - move to iconfont 2018-12-05 22:19:46 +03:00
Andrew Dolgov a2e06410c2 shorten_expanded: call unpackVisible() because there might be new stuff from below if current is shortened 2018-12-05 08:13:47 +03:00
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 2018-12-04 19:03:42 +03:00
Andrew Dolgov 31e79317b3 normalize various font sizes and families between prefs & main UI
change some dialogs layout a bit to maybe become more readable
2018-12-04 15:22:22 +03:00
Andrew Dolgov e76d1fb995 plugins: mail, mailto: remove code from global context 2018-12-03 14:21:50 +03:00
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 2018-12-03 13:38:13 +03:00
Andrew Dolgov 78cc470193 remove some plugin JS code out of global context 2018-12-03 10:51:14 +03:00
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 2018-12-02 20:56:30 +03:00
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
2018-12-02 20:07:57 +03:00
Andrew Dolgov 35ded4bc84 edit phrasing of some alert()s 2018-12-02 16:30:32 +03:00