Andrew Dolgov
1bfe1d7b31
simplify error handling
...
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
2017-03-04 14:34:44 +03:00
Andrew Dolgov
b835a52814
rework the way headlines menus identify calling row
2017-02-17 09:01:45 +03:00
Andrew Dolgov
5161460048
bind headlines menu to a selector to avoid remaking it unnecessarily
2017-02-13 23:36:58 +03:00
Andrew Dolgov
20deb5fc32
cdmcollapse/expand: use less convoluted selector queries
2017-02-13 22:45:30 +03:00
Andrew Dolgov
829d478f1b
add some protection against opener attacks if external site is opened via window.open()
2017-02-08 15:07:05 +03:00
Andrew Dolgov
ad326dbf78
unpackVisibleHeadlines: do not iterate over all RROWs all the time
2017-01-22 20:57:16 +03:00
Andrew Dolgov
3bc1b53772
initHeadlinesMenu: remove unneeded output
2017-01-22 19:58:17 +03:00
Andrew Dolgov
974c6eb523
attach headline menu objects to correct DOM nodes in combined mode
2017-01-22 19:57:16 +03:00
Andrew Dolgov
e1f7b05b52
reuse menu objects while appending headline rows
2017-01-22 19:20:23 +03:00
Anders Kaseorg
88946d331a
Replace all setTimeout strings with functions
...
This fixes a cross-site scripting vulnerability.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 16:52:27 -05:00
Andrew Dolgov
b6b5554db4
normalize some html5 custom attributes
2016-03-22 23:43:32 +03:00
Andrew Dolgov
2d052e42b5
getLoadedArticleIds: consider visible rows only
...
catchupFeedInGroup: hide articles when catching up, with caveats
2016-03-22 23:22:28 +03:00
Andrew Dolgov
6be118fda1
showArticleInHeadlines: remove unused code
2016-03-22 13:41:55 +03:00
Andrew Dolgov
c4e211046e
updateFloatingMenu: performance improvements
2016-03-22 13:38:20 +03:00
Andrew Dolgov
d7cc5e6cdd
fix previous
2016-03-22 12:51:15 +03:00
Andrew Dolgov
63c7446a79
headlines scroll handler: add a rate limit
2016-03-22 12:43:18 +03:00
Andrew Dolgov
7c0d68f207
remove dismiss* functions
2016-03-22 10:28:34 +03:00
Andrew Dolgov
6056d164fa
cleanup dismissArticle functions
2016-03-22 10:11:11 +03:00
Kostiantyn Moroz
2757c49387
Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode)
2016-02-07 18:48:24 +00:00
Andrew Dolgov
0b41bd3414
add some hacks to hopefully mitigate headlines memory leaks
2016-01-11 01:11:26 +03:00
Andrew Dolgov
a71e571b97
headlines_callback2: force prevent duplicate row ids
2015-10-07 18:14:21 +03:00
Andrew Dolgov
a0dbc45acd
add edit feed to feed header context menu in grouped mode
2015-09-07 12:49:49 +03:00
Andrew Dolgov
6b0a17ad8b
viewfeed: switch to hash-based arguments
...
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
2015-08-12 14:09:46 +03:00
Andrew Dolgov
6810a1de42
use dijit form widget for attachments dropdown
2015-08-11 14:53:07 +03:00
Andrew Dolgov
176a489e54
use batch-based catching up in cdmExpandArticle() to reduce server load
2015-08-11 12:25:11 +03:00
Andrew Dolgov
eaec06f950
prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
...
a bunch of other related fixes
2015-08-11 12:00:08 +03:00
Andrew Dolgov
95b493d68d
partially revert previous because of navigation breakage in expanded mode, durrr
2015-08-11 11:31:50 +03:00
Andrew Dolgov
b71add41d5
unfuck catchupbatchedarticles a bit
2015-08-11 10:12:22 +03:00
Andrew Dolgov
8292123ebc
assorted fixes for keyboard navigation which hopefully don't break everything else
2015-08-11 10:06:30 +03:00
Andrew Dolgov
231c672c5d
fix previous
2015-08-11 09:12:57 +03:00
Andrew Dolgov
837443630f
infscroll: preload articles a bit earlier
2015-08-11 09:05:04 +03:00
Andrew Dolgov
d8e8e24e34
pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense)
2015-07-31 13:42:05 +03:00
Andrew Dolgov
8691b32abf
disable headline appear animation
2015-07-29 18:11:23 +03:00
Andrew Dolgov
d46af5a5cf
headlines scroll handler: make preloading less aggressive
2015-07-29 16:57:24 +03:00
Andrew Dolgov
e7a66d1230
(experimental) disable infscroll requests while marking auto catched up articles as read
2015-07-14 12:50:27 +03:00
Andrew Dolgov
33c4bd8968
fix error feed (i.e. when requested feed no longer exists) not display properly
2015-07-13 22:04:21 +03:00
Andrew Dolgov
f17069960c
roll back separate headline transport
2015-07-13 22:01:29 +03:00
Andrew Dolgov
57c521df91
maybe speedup headline adding a bit, maybe not
2015-07-13 18:38:39 +03:00
Andrew Dolgov
9ef1985f1b
viewfeed.js: cleanup the code a bit
2015-07-13 01:28:02 +03:00
Andrew Dolgov
ac4c1383ae
bring cdmFeedTitle style in line with the rest of the UI
...
send headline rows as separate JSON objects
2015-07-13 01:19:52 +03:00
Andrew Dolgov
48fefe2f6b
fixes for first_id stuff
2015-07-12 18:08:02 +03:00
Andrew Dolgov
39d488a256
viewfeed: set hsp status when scrolling to the very end
2015-07-12 13:37:24 +03:00
Andrew Dolgov
15ae8cd084
js: remove current_top_id global
2015-07-12 13:30:00 +03:00
Andrew Dolgov
3444020100
report top id changed in headlines buffer
2015-07-12 12:01:34 +03:00
Andrew Dolgov
f5a0fb8b64
queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating
2015-07-12 01:29:36 +03:00
Andrew Dolgov
5a45821ec9
prevent event propagation when clicking on CDM article footer
2015-06-18 16:00:03 +03:00
Andrew Dolgov
a72cd54ce1
bayes: properly reset score when going good -> ugly
...
article: add helper to refresh article score pic, properly set scorepic title
2015-06-17 22:04:32 +03:00
Anders Kaseorg
5c145bde7a
Make the floating title transition smoother
...
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting. Now it
appears at the point when its bottom lines up with the real title’s
bottom. This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.
We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden. It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.
Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2015-01-30 21:58:44 -05:00
Andrew Dolgov
760183e37d
minor spacer/whiteBox appearance tweaks
2014-07-26 22:08:33 +04:00
Andrew Dolgov
1d6191ee0a
always create headline-spacer on lazy load
2014-07-26 22:00:33 +04:00