Commit Graph

614 Commits

Author SHA1 Message Date
Andrew Dolgov 24c7e4132d subscribe dialog: do not report errors via alert()
fetch_file_contents: reset all globals on start, return error message body when not using curl
subscribe_to_feed: report if cloudflare is in the error message
2017-01-28 12:45:49 +03:00
Andrew Dolgov ad326dbf78 unpackVisibleHeadlines: do not iterate over all RROWs all the time 2017-01-22 20:57:16 +03:00
Andrew Dolgov 70c5b2bfcc feed tree: only run animation for appearing unread counters to prevent clashes with aux counter updating and animations ending up in wrong state 2017-01-22 20:20:35 +03:00
Andrew Dolgov 3bc1b53772 initHeadlinesMenu: remove unneeded output 2017-01-22 19:58:17 +03:00
Andrew Dolgov 974c6eb523 attach headline menu objects to correct DOM nodes in combined mode 2017-01-22 19:57:16 +03:00
Andrew Dolgov d5f74019ac parse_counters: cache previous reply and skip processing of unchanged rows (better implementation) 2017-01-22 19:38:07 +03:00
Andrew Dolgov a4e04c498f parse_counters: cache previous reply and skip processing of unchanged rows 2017-01-22 19:29:14 +03:00
Andrew Dolgov e1f7b05b52 reuse menu objects while appending headline rows 2017-01-22 19:20:23 +03:00
Andrew Dolgov b1a80693b1 collapse_feedlist: also toggle splitter 2017-01-22 17:46:11 +03:00
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 16:52:27 -05:00
Andrew Dolgov b7d63a58db fix loading indicator position/size for tree leafs 2017-01-21 22:30:20 +03:00
Andrew Dolgov 7fbc10c236 force-enable persist for feedTree 2017-01-21 22:21:46 +03:00
Andrew Dolgov e2e2479984 Merge branch 'dojo-1.12.1'
Conflicts:
	js/prefs.js
2017-01-21 21:59:17 +03:00
Andrew Dolgov ab235fc5f1 prefs: add updateSelectedPrompt shim called by toggleSelectedRow() 2017-01-21 21:49:10 +03:00
Andrew Dolgov 1c4f5e8390 add dependency on dojo/_base/html 2017-01-21 21:47:44 +03:00
Anders Kaseorg 6887a0f573 lib: Upgrade Dojo and Dijit from 1.8.3 to 1.12.1
The itemNode and expandoNode elements have changed from img to
span (https://bugs.dojotoolkit.org/ticket/16699), so we now put our
tree icons inside them rather than replacing them.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 13:22:14 -05:00
Anders Kaseorg 9f539be3c2 Replace deprecated dojo.place with domConstruct.place
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 13:22:13 -05:00
Andrew Dolgov 6293d3717c add toggle_sidebar plugin, remove obsolete toggle button
add PluginHost::HOOK_MAIN_TOOLBAR_BUTTON
2017-01-07 15:29:17 +03:00
Andrew Dolgov f04b12d8e7 category: swap context menu items 2016-11-22 09:11:13 +03:00
Andrew Dolgov acfee412a3 feed tree: add category context menu entry to un/collapse it 2016-11-11 14:14:31 +03:00
Andrew Dolgov d39a2f8005 switch modules to new dojo definition format 2016-08-10 13:40:24 +03:00
Andrew Dolgov 546b419f52 catch plugin JS errors 2016-08-10 12:23:35 +03:00
Andrew Dolgov fd539f2800 prefs: use dojo asynchronously 2016-08-10 12:22:30 +03:00
Andrew Dolgov 0dbc20a8d4 load dijit properly, duh 2016-08-10 11:49:05 +03:00
Andrew Dolgov ee5170424e dojo: main UI: load stuff asynchronously 2016-08-10 10:01:05 +03:00
Andrew Dolgov 64c24ecb59 add hotkey for toggling VFEED_GROUP_BY_FEED preference 2016-07-26 15:55:00 +03:00
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 2016-03-22 23:43:32 +03:00
Andrew Dolgov 2d052e42b5 getLoadedArticleIds: consider visible rows only
catchupFeedInGroup: hide articles when catching up, with caveats
2016-03-22 23:22:28 +03:00
Andrew Dolgov 6be118fda1 showArticleInHeadlines: remove unused code 2016-03-22 13:41:55 +03:00
Andrew Dolgov c4e211046e updateFloatingMenu: performance improvements 2016-03-22 13:38:20 +03:00
Andrew Dolgov d7cc5e6cdd fix previous 2016-03-22 12:51:15 +03:00
Andrew Dolgov 63c7446a79 headlines scroll handler: add a rate limit 2016-03-22 12:43:18 +03:00
Andrew Dolgov 7c0d68f207 remove dismiss* functions 2016-03-22 10:28:34 +03:00
Andrew Dolgov a51bc3dfa5 catchupfeedingroup: do not remove elements 2016-03-22 10:23:57 +03:00
Andrew Dolgov 6056d164fa cleanup dismissArticle functions 2016-03-22 10:11:11 +03:00
Andrew Dolgov 11514d576f catchupFeedInGroup: dismiss elements on catchup 2016-03-22 09:42:00 +03:00
Andrew Dolgov dfaf806a7a catchupFeedInGroup: send catchup request even if there are no unread articles in the buffer for this feed 2016-03-21 21:43:54 +03:00
Andrew Dolgov 701de97ebb improvements for catchupFeedInGroup() 2016-03-21 21:40:40 +03:00
Kostiantyn Moroz 2757c49387 Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode) 2016-02-07 18:48:24 +00:00
Andrew Dolgov 0b41bd3414 add some hacks to hopefully mitigate headlines memory leaks 2016-01-11 01:11:26 +03:00
Andrew Dolgov 9842b51c71 getfeedname: fix for non-numeric feeds (tags) 2015-12-30 15:11:39 +03:00
Andrew Dolgov 89bea945ce filters: add to previous on JS side 2015-12-03 10:25:30 +03:00
Andrew Dolgov d38cd41253 loadMoreHeadlines: use correct offsets for starred vfeed in adaptive mode 2015-10-27 15:36:51 +03:00
Andrew Dolgov a71e571b97 headlines_callback2: force prevent duplicate row ids 2015-10-07 18:14:21 +03:00
Andrew Dolgov f48f292d2b tweak filter preview layout a bit; allow previewing matched articles in a popup 2015-09-11 13:05:08 +03:00
Andrew Dolgov 3857536f70 fix testing in create filter dialog, woops 2015-09-09 22:13:43 +03:00
Andrew Dolgov 261226a3a5 mostly implement async filter test dialog 2015-09-09 22:09:03 +03:00
Andrew Dolgov a007c18dff wip: filter async testing 2015-09-09 16:56:04 +03:00
Andrew Dolgov a0dbc45acd add edit feed to feed header context menu in grouped mode 2015-09-07 12:49:49 +03:00
Andrew Dolgov b717c65e4e update previous 2015-09-03 16:54:09 +03:00
Andrew Dolgov 791877c39d fix catching up for grouped feeds 2015-09-03 16:41:04 +03:00
Andrew Dolgov e17079dcef make disabled filter rules easier to discern
show if filter set match_any_rule on the overview
2015-08-17 12:33:07 +03:00
Andrew Dolgov dcbe36b2a2 fix some remaining old-style viewfeed() calls 2015-08-13 09:51:39 +03:00
Andrew Dolgov 9109e171ee feedtree: don't hide feeds with errors 2015-08-12 21:47:40 +03:00
Andrew Dolgov bf9cc9ad95 combine user edit & user details 2015-08-12 20:19:38 +03:00
Andrew Dolgov f9c1f8b0d4 pref-feeds: check for inactive feeds asynchronously 2015-08-12 16:19:42 +03:00
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
2015-08-12 14:09:46 +03:00
Andrew Dolgov b87744534a add plugin-based filter actions (see example plugin in attic)
bump schema
2015-08-11 23:28:42 +03:00
Andrew Dolgov 6810a1de42 use dijit form widget for attachments dropdown 2015-08-11 14:53:07 +03:00
Andrew Dolgov 176a489e54 use batch-based catching up in cdmExpandArticle() to reduce server load 2015-08-11 12:25:11 +03:00
Andrew Dolgov eaec06f950 prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
a bunch of other related fixes
2015-08-11 12:00:08 +03:00
Andrew Dolgov 95b493d68d partially revert previous because of navigation breakage in expanded mode, durrr 2015-08-11 11:31:50 +03:00
Andrew Dolgov b71add41d5 unfuck catchupbatchedarticles a bit 2015-08-11 10:12:22 +03:00
Andrew Dolgov 8292123ebc assorted fixes for keyboard navigation which hopefully don't break everything else 2015-08-11 10:06:30 +03:00
Andrew Dolgov 231c672c5d fix previous 2015-08-11 09:12:57 +03:00
Andrew Dolgov 837443630f infscroll: preload articles a bit earlier 2015-08-11 09:05:04 +03:00
Andrew Dolgov d8e8e24e34 pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense) 2015-07-31 13:42:05 +03:00
Andrew Dolgov 8691b32abf disable headline appear animation 2015-07-29 18:11:23 +03:00
Andrew Dolgov d46af5a5cf headlines scroll handler: make preloading less aggressive 2015-07-29 16:57:24 +03:00
Andrew Dolgov e7a66d1230 (experimental) disable infscroll requests while marking auto catched up articles as read 2015-07-14 12:50:27 +03:00
Andrew Dolgov 33c4bd8968 fix error feed (i.e. when requested feed no longer exists) not display properly 2015-07-13 22:04:21 +03:00
Andrew Dolgov f17069960c roll back separate headline transport 2015-07-13 22:01:29 +03:00
Andrew Dolgov 57c521df91 maybe speedup headline adding a bit, maybe not 2015-07-13 18:38:39 +03:00
Andrew Dolgov 9ef1985f1b viewfeed.js: cleanup the code a bit 2015-07-13 01:28:02 +03:00
Andrew Dolgov ac4c1383ae bring cdmFeedTitle style in line with the rest of the UI
send headline rows as separate JSON objects
2015-07-13 01:19:52 +03:00
Andrew Dolgov 48fefe2f6b fixes for first_id stuff 2015-07-12 18:08:02 +03:00
Andrew Dolgov 39d488a256 viewfeed: set hsp status when scrolling to the very end 2015-07-12 13:37:24 +03:00
Andrew Dolgov 15ae8cd084 js: remove current_top_id global 2015-07-12 13:30:00 +03:00
Andrew Dolgov 3444020100 report top id changed in headlines buffer 2015-07-12 12:01:34 +03:00
Andrew Dolgov f5a0fb8b64 queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating 2015-07-12 01:29:36 +03:00
Andrew Dolgov 9090b874ab simplify search, remove search_mode as useless
remove dialog to select by tags, simplify browsing by tag query
2015-07-07 15:59:32 +03:00
Andrew Dolgov 5a45821ec9 prevent event propagation when clicking on CDM article footer 2015-06-18 16:00:03 +03:00
Andrew Dolgov a72cd54ce1 bayes: properly reset score when going good -> ugly
article: add helper to refresh article score pic, properly set scorepic title
2015-06-17 22:04:32 +03:00
Andrew Dolgov 86b05f8661 better feed debugger ui for f D 2015-06-12 13:06:36 +03:00
Andrew Dolgov 415a3b50c9 fix some minor typos and stuff 2015-06-07 18:41:18 +03:00
Andrew Dolgov 669fc881f3 add error notification if trying to toggle widescreen in cdm 2015-03-06 15:51:54 +03:00
Andrew Dolgov 40f147df79 feedtree: do not hide special category for reals if configured as such 2015-03-06 14:42:05 +03:00
Andrew Dolgov 119ba03bd4 minor fixes for previous 2015-02-03 14:42:20 +03:00
Andrew Dolgov efcc5d365d add placeholder update checker using git changesets 2015-02-03 14:39:15 +03:00
Andrew Dolgov ed775e4e8d remove obsolete code related to version checking and tarball updater plugin 2015-01-31 15:08:55 +03:00
Anders Kaseorg 5c145bde7a Make the floating title transition smoother
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting.  Now it
appears at the point when its bottom lines up with the real title’s
bottom.  This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.

We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden.  It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.

Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2015-01-30 21:58:44 -05:00
Andrew Dolgov 0d41fd76d3 notify fixes 2014-11-09 20:31:29 +03:00
Andrew Dolgov d9c93ebfdb tweak notifications; use css animations for notifications 2014-11-02 20:58:46 +03:00
Andrew Dolgov 98cbae8dfa hotkey actions: toggle_expand, collapse_article: check if element exists
before acting on it (closes #815)
2014-10-26 10:25:19 +04:00
Andrew Dolgov 38bc9dad22 mail plugin: use dijit.form.ComboBox to allow random email input instead of only predefined ones 2014-08-26 18:11:32 +04:00
Andrew Dolgov 89018afa13 assign stored content-insert height/width in switchPanelMode(); reset stored sizes on widescreen switch 2014-08-11 15:39:14 +04:00
Andrew Dolgov 760183e37d minor spacer/whiteBox appearance tweaks 2014-07-26 22:08:33 +04:00
Andrew Dolgov 1d6191ee0a always create headline-spacer on lazy load 2014-07-26 22:00:33 +04:00
Andrew Dolgov 74217c72a1 adjust scroll amount to trigger auto-opening next unread feed 2014-07-25 15:40:38 +04:00
Andrew Dolgov 22f675e5c4 add a link to headlines-spacer to open next unread feed 2014-07-25 13:54:10 +04:00
Andrew Dolgov 0f85f483e5 another implementation of pull 386 (show next when finished reading) (2) 2014-07-25 12:29:30 +04:00
Andrew Dolgov b7c20a3759 another implementation of pull 386 (show next when finished reading) 2014-07-25 12:14:06 +04:00
Andrew Dolgov 6472dd11a2 Revert "scroll to end to show next feed or category"
This reverts commit 86f32020f6.
2014-07-25 09:20:00 +04:00
wolle 86f32020f6 scroll to end to show next feed or category
only if cmd_auto_catchup and on_catchup_show_next_feed set
2014-06-28 15:04:08 +02:00
André Glüpker d922b09c43 Skip nested Feed when calling getNextUnreadFeed()
This function is only called when using "Mark all as read".
So every time, this function gets called right now, all nested
categories get marked as read as well, so we don't want to jump to them.
Instead we want to the next category with same or higher tier.
2014-06-14 12:37:05 +02:00
Andrew Dolgov e79b401e97 getPreviousFeed: wrap to last feed to be consistent with getNextFeed 2014-06-09 13:23:27 +04:00
Andrew Dolgov bace5e9e6f prevent cdmClicked ctrl-click handler working on article body 2014-05-08 06:41:21 +00:00
Andrew Dolgov 50e04efdc8 expand filtertree display to make filters easier to distinguish 2014-04-02 08:15:33 +00:00
Andrew Dolgov e126fe6a68 exception_error: always stringify ext_info 2014-03-14 15:14:13 +04:00
Andrew Dolgov fb3a2505ac init params debugging: support objects etc 2014-03-14 15:09:50 +04:00
Andrew Dolgov 2f7918ae2e exception_error: support objects in ext_info 2014-03-14 14:49:18 +04:00
Andrew Dolgov cde449b937 update report to tt-rss prompt 2014-03-14 14:40:29 +04:00
Andrew Dolgov 8b91b0beb5 add ttrss version and init params to reports 2014-03-14 14:20:32 +04:00
Andrew Dolgov cbcf6517dc Revert "exception handler: remove report to tt-rss.org"
This reverts commit b55aec078c.
2014-03-14 14:08:32 +04:00
Andrew Dolgov df63125dd7 handle_rpc_json: do not crash if net-alert is somehow unavailable 2014-03-14 14:05:32 +04:00
Andrew Dolgov b55aec078c exception handler: remove report to tt-rss.org 2014-03-14 13:51:53 +04:00
Andrew Dolgov 5c812c2ea4 Revert "add a less intimidating error message when backend times out and/or fails to return valid JSON"
This reverts commit 2ffe7a3b14.
2014-03-11 19:09:33 +04:00
Andrew Dolgov 2ffe7a3b14 add a less intimidating error message when backend times out and/or fails to return valid JSON 2014-03-11 13:59:14 +04:00
Andrew Dolgov 350218f4f8 quickAddFeed: gracefully handle backend timeout/JSON parse problems 2014-03-11 13:38:06 +04:00
Andrew Dolgov 1bffd1068f unify main and headlines toolbar 2014-01-27 22:03:42 +04:00
Andrew Dolgov d728015d48 minor css tweaks 2014-01-27 19:48:16 +04:00
Andrew Dolgov d44f3da4be default theme updates 2014-01-27 19:03:35 +04:00
Andrew Dolgov 0c7e49936a quickAddFilter: if text is currently highlighted, use that instead of active article title for placeholder text 2013-11-12 14:21:28 +04:00
Andrew Dolgov b8fd08d6db do not unpack all visible headlines in collapsed mode because those are unpacked on expand 2013-10-21 16:55:36 +04:00
Andrew Dolgov 24940c3dc9 catchup group: deselect everything before processing 2013-10-20 18:45:24 +04:00
Andrew Dolgov 87065739cd add context menu for cdmFeedTitle; change mark as read prompt for grouped headlines more clear 2013-10-17 13:38:48 +04:00
Andrew Dolgov 8f7a020e1b add notification to subscribe dialog when multiple feeds are detected 2013-10-02 15:24:08 +04:00
Andrew Dolgov 3728377344 Revert "Firefox accessibility.typeaheadfind is triggered for multikey shortcuts."
breaks copy/paste in chrome

This reverts commit d7e4897b8e.
2013-09-27 15:14:20 +04:00
Derek Schrock d7e4897b8e Firefox accessibility.typeaheadfind is triggered for multikey shortcuts.
For multikey shortcuts Firefox accessibility.typeaheadfind is triggered.  Returning false will cause the default event from occuring and prevent the event from bubbling up.
2013-09-20 00:04:33 -04:00
Andrew Dolgov 2e35b3bd6b prevent automatic selection of headlines row first child when scrolling in 3panel mode because it screws with keyboard navigation (closes #752) 2013-09-09 14:38:28 +04:00
Andrew Dolgov 07734eee5a loadMoreHeadlines: use shorter syntax for adaptive offset calculation 2013-09-01 14:07:31 +04:00
Andrew Dolgov 1966e05457 workaround for resetting panel size cookies (closes #756) 2013-07-25 14:20:42 +04:00
Andrew Dolgov 95be6e0c89 fix second row being selected on viewfeed (closes #748) 2013-07-17 12:16:54 +04:00
Andrew Dolgov 00fe7886b6 update floating title unread status when auto catching up 2013-07-16 10:05:48 +04:00
Andrew Dolgov 41d37fb2c3 add experimental hack to show row unread status in floating title 2013-07-16 09:59:14 +04:00
Andrew Dolgov 0971cc619d remove dijit checkbox element from floatingTitle 2013-07-15 09:15:07 +04:00
Andrew Dolgov d9e78984fb viewfeed: properly escape feed in ajax query 2013-07-12 14:15:03 +04:00
Andrew Dolgov 65f0eb01aa support headlines context menu in floating title 2013-07-11 16:49:25 +04:00
Andrew Dolgov 41a7a066ef share: move unsharing all articles into the plugin 2013-07-11 14:11:41 +04:00
Andrew Dolgov 6e3224a26c use correct icons for notifications 2013-07-11 14:11:16 +04:00
Andrew Dolgov 7415fcf212 enable floating title for expandable combined mode, minor expandable mode fixes 2013-07-11 12:28:24 +04:00
Andrew Dolgov 301a09dc55 fix floating title sometimes obscuring next article title 2013-07-11 08:35:12 +04:00
Andrew Dolgov d095f42fa4 floating title: remove cdm auto catchup id hack for the time being 2013-07-10 22:16:10 +04:00
Andrew Dolgov 8ee5e9e5e6 rework floatingtitle 2013-07-10 22:11:24 +04:00
Andrew Dolgov 2f20dd58d2 integrate silk icons by Mark James 2013-07-10 13:09:12 +04:00
Andrew Dolgov 03304fda54 if multiple articles are selected, do not reset active article / selection on scroll if auto catchup is enabled 2013-07-09 12:34:57 +04:00
Andrew Herron c65bd1027a Added alt and meta key handling to hotkeys 2013-07-02 22:36:29 +10:00
Andrew Herron d999bc3eb2 prevent accidental ctrl_key global 2013-07-02 22:29:19 +10:00
Andrew Dolgov 4f62f8f6dc add js hook for floating title 2013-06-28 08:30:35 +04:00
Veit Lehmann d1754390cc only do article update operations once when scrolling
I discovered that DOM operations and function calls were done several times inside the 100px mirror when scrolling through articles. Especially painful on seamless scrolling systems like Mac OS, where dozens of updates would slow down this part dramatically. This change fixes it.
2013-06-25 06:08:44 +03:00