valvin
/
ttrss
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,343 Commits 1 Branch 18 Tags 122 MiB
Commit Graph

687 Commits

Author SHA1 Message Date
Chih-Hsuan Yen f3aceb4648
Fix an error when disabling all user plugins 
If I enabled some user plugins via Preferences -> Plugins and then
disabled all of them, an error occurred:

Jul 16 22:34:20 php[100]: PHP Fatal error:  Uncaught TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in /usr/share/webapps/tt-rss/classes/pref/prefs.php:1027
Jul 16 22:34:20 php[100]: Stack trace:
Jul 16 22:34:20 php[100]: #0 /usr/share/webapps/tt-rss/classes/pref/prefs.php(1027): array_filter()
Jul 16 22:34:20 php[100]: #1 /usr/share/webapps/tt-rss/backend.php(136): Pref_Prefs->setplugins()
Jul 16 22:34:20 php[100]: #2 {main}
Jul 16 22:34:20 php[100]:   thrown in /usr/share/webapps/tt-rss/classes/pref/prefs.php on line 1027

Apparently the issue was elevated from a warning to an error in PHP 8.0
[1].

[1] https://php.watch/versions/8.0/internal-function-exceptions
 2022-07-16 22:50:16 +08:00
Andrew Dolgov 8ef816d8f8
feeds-tree: move external onClick dojo/method to PrefFeedTree class 2022-06-06 09:31:37 +03:00
Andrew Dolgov 6436dd16f9
filter-tree: move external dojo/method to PrefFilterTree class 2022-06-06 09:29:16 +03:00
Andrew Dolgov dd983e5de1 prefs: move external filter tree onload method (which checks for inactive feeds, etc.) to FilterTree class 2022-06-05 11:47:21 +03:00
Andrew Dolgov fc84712135 pref-filters: add a button to hide or show rules in the filter list 2022-06-05 11:41:28 +03:00
Andrew Dolgov 9457bb090a fix PHP8 undefined array key warning when resetting prefs to defaults 2022-06-05 11:14:42 +03:00
David Edler de1e218a83
various fixes vor php 8.1 compatibility 
Cherry-picked from https://git-gitea.tt-rss.org/fox/tt-rss/pulls/56,
while excluding changes in vendor/ (causes compatiblity issues with
PHP<8 [1]) and strftime-related ones (already re-applied in
https://git-gitea.tt-rss.org/fox/tt-rss/pulls/66).

[1] https://community.tt-rss.org/t/support-for-php-8-1/5089/9
 2022-03-09 00:46:15 +08:00
Andrew Dolgov f7e2f62022 fix Feeds::_get_counters() used improperly as a replacement for 
getFeedUnread()
 2022-02-20 12:48:38 +03:00
Andrew Dolgov 77f39d65b5 * Feeds::_get_counters - fix retrieving unread for tags 
* mark several symbols as @deprecated properly
 * replace uses of (deprecated) getFeedUnread() with Feeds::_get_counters()
 2022-02-20 11:04:40 +03:00
Andrew Dolgov 40b2356be2 filters: 
* add filter action to ignore feed-provided tags
 * simplify handling of various filter-provided tags
 * bump schema to 146
 2021-12-20 07:56:16 +03:00
jbaldus 987870074b Fixes declaration of Pref_Prefs::csrf_ignore to match IHandler::csrf_ignore 2021-12-02 20:57:19 +03:00
Andrew Dolgov a201e10ee0 Revert "various fixes vor php 8.1 compatibility" 
This reverts commit 14027ae04e.
 2021-12-01 13:37:35 +03:00
David Edler 14027ae04e various fixes vor php 8.1 compatibility 2021-11-30 21:50:09 +01:00
wn_ d532eb773b Switch from null to false as the default for missing bool params. 2021-11-18 18:25:04 +00:00
wn_ 2422aae577 Consistently handle param string to bool conversions in handlers. 2021-11-18 18:09:47 +00:00
wn_ 6d438c5a77 Address PHPStan warning in 'classes/pref/users.php'. 2021-11-14 20:27:17 +00:00
wn_ 5632d75a45 Address PHPStan warning in 'classes/pref/system.php'. 2021-11-14 20:26:21 +00:00
wn_ abab2a94e8 Address PHPStan warning in 'classes/pref/prefs.php'. 
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
 2021-11-14 20:13:09 +00:00
wn_ b8f0627a0e Address PHPStan warning in 'classes/pref/labels.php'. 2021-11-14 20:13:09 +00:00
wn_ 9326ed605f Address PHPStan warning in 'classes/pref/filters.php'. 2021-11-14 17:59:57 +00:00
Andrew Dolgov af2f4460ce * deal with some phpstan warnings in base plugin class 
* arguably better hack for incompatible plugins causing E_COMPILE_ERROR
 2021-11-14 16:49:10 +03:00
wn_ 5a50c333b2 Address PHPStan warnings in 'classes/pref/filters.php'. 2021-11-14 00:59:19 +00:00
wn_ edd476e7fe minor: correct $cat type in Pref_Feeds#calculate_children_count() 2021-11-13 16:00:59 +00:00
wn_ a18473e4c0 Address PHPStan warnings in 'classes/pref/feeds.php'. 2021-11-13 15:56:31 +00:00
wn_ 5606e38bff Update signature of handler 'csrf_ignore' to include types. 2021-11-12 02:01:31 +00:00
Andrew Dolgov 9e8d69739f add two helper account access levels: 
- read only - can't subscribe to more feeds, feed updates are skipped
 - disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
 2021-11-10 20:44:51 +03:00
wn_ ac5a4f5937 Address PHPStan warning in 'classes/pref/users.php'. 
------ -------------------------------
Line   classes/pref/users.php
------ -------------------------------
170    If condition is always false.
------ -------------------------------
 2021-11-01 21:10:27 +00:00
wn_ a38892d5d7 Address PHPStan warning in 'classes/pref/prefs.php'. 
------ ------------------------------------------------
Line   classes/pref/prefs.php
------ ------------------------------------------------
1328   Expression on left side of ?? is not nullable.
------ ------------------------------------------------
 2021-11-01 21:10:27 +00:00
Philip Klempin aead30a041 Fix undefined array key "output" when adding new label 2021-10-15 23:05:50 +00:00
Andrew Dolgov 36e174750e fix label ordering in feed tree 2021-09-02 08:21:05 +03:00
Andrew Dolgov 5c60254474 Pref_Feeds:calculate_children_count - fix operator precedence 2021-08-23 10:45:34 +03:00
Andrew Dolgov 0808123179 fix broken feed tree generation when categories are disabled 2021-08-18 21:02:58 +03:00
wn_ 23b4152c9e Make prefs feed search case-insensitive. 
Previously the search query had to match lower title or feed_url (i.e. searching w/ uppercase wouldn't match).
 2021-08-17 23:14:14 +00:00
wn_ 992e9cd9e3 Use ORM more in 'classes/pref/feeds.php'. 2021-08-17 23:03:35 +00:00
Andrew Dolgov 73d14338ab fix rendering of category filters on Uncategorized 2021-07-28 12:59:47 +03:00
Andrew Dolgov 8ed8a10965 add settings profile cloning 2021-06-16 14:24:57 +03:00
Andrew Dolgov 0acd33abe3 OTP: generate longer secrets, also make them easier to read/copy 2021-03-29 19:26:04 +03:00
Andrew Dolgov e3c51b0e6c Revert "clip max displayed counter value to 9999 because of container node width" 
This reverts commit c34a4c85bd.
 2021-03-23 11:51:17 +03:00
Andrew Dolgov c34a4c85bd clip max displayed counter value to 9999 because of container node width 2021-03-23 10:47:06 +03:00
Andrew Dolgov 43ea36d030 prefs: allow setting email if it was previously blank 2021-03-17 19:50:04 +03:00
Andrew Dolgov 44b274b6d4 remove published opml (use CLI instead) 2021-03-16 12:27:46 +03:00
Philip Klempin fa22e1bc35 Add coalescing operator to otp_enabled when changing user password 2021-03-12 20:26:24 +01:00
Andrew Dolgov b6033d0bbd grid view tweaks 2021-03-10 11:44:16 +03:00
Andrew Dolgov ddfa39015e experimental: add preference to show combined mode headlines as a 2 column grid 2021-03-10 08:33:56 +03:00
Andrew Dolgov 2160a86092 show E_COMPILE_ERROR in event log at higher severity levels 2021-03-09 17:00:51 +03:00
Andrew Dolgov 4fe2e6bbf1 app password list: fix th/td alignment 2021-03-09 09:04:13 +03:00
wn_ fed5158ec5 Default to null 'rv' for plugin update check. 
Previously 'rv' was returned as an empty JS array, causing 'p.rv.git_status != 0' to evaluate to true and a misleading 'Ready to update' appearing for certain plugins.
 2021-03-08 15:38:52 +00:00
Andrew Dolgov c26f58d8a5 fix some php8 warnings 2021-03-08 11:16:32 +03:00
Andrew Dolgov 603cc89638 check updates one plugin at a time 2021-03-07 20:11:54 +03:00
Andrew Dolgov ffb93d72ac fix previous to actually save enabled plugins 2021-03-07 12:28:24 +03:00