0269c7ce32
Prevent "Undefined index: version" events for git version with open_basedir after 9dabfbfa11
2021-12-02 18:55:08 +01:00
5df8dacf9f
api, getHeadlines: properly accept feed_id 0
2021-12-01 19:04:42 +03:00
a201e10ee0
Revert "various fixes vor php 8.1 compatibility"
...
This reverts commit 14027ae04e
2021-12-01 13:37:35 +03:00
aaebe55456
Revert "replace strftime with date"
...
This reverts commit 72e21f89ce
2021-12-01 13:37:25 +03:00
72e21f89ce
replace strftime with date
2021-11-30 22:07:11 +01:00
14027ae04e
various fixes vor php 8.1 compatibility
2021-11-30 21:50:09 +01:00
409c63dcf8
remove mixed type hints from function arguments because we still support PHP7
2021-11-29 12:30:33 +03:00
28fb571dca
* fix showing headlines for tag-based virtual feeds
...
* API: allow retrieving headlines for tag-based feeds (bump api level to 18)
2021-11-29 10:20:13 +03:00
204f92b926
urlhelper: add debugging output for download attempts
2021-11-24 08:19:04 +03:00
a6cad5cbca
api: don't try to pass null login/password when subscribing to feed
2021-11-23 16:55:21 +03:00
9dabfbfa11
_get_version:
...
- don't bother with git if open_basedir is enabled
- check for SCRIPT_ROOT instead of TTRSS_.. anything because that would be set regardless of install method
2021-11-23 14:46:24 +03:00
3323ae78ce
* sql_bool_to_bool: make parameter nullable
...
* errorhandler: don't try to truncate null strings
* UrlHelper::rewrite_relative: fix undefined offset warnings for URLs
that lack schema/host (data: etc)
2021-11-20 16:11:44 +03:00
e7111e4f14
sanitize: make force_remove_images nullable
2021-11-20 14:02:37 +03:00
2b4ba59a79
feeds/add: force cast category id to integer
2021-11-19 17:02:25 +03:00
0a3a464def
Merge pull request 'Consistently handle param string to bool conversions in handlers.' ( #53 ) from wn/tt-rss:feature/consistent-param-to-bool into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/53
2021-11-19 07:36:15 +03:00
3070933f64
Merge pull request 'Fix Undefined array key "order_by"' ( #54 ) from klempin/tt-rss:master into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/54
2021-11-19 07:35:20 +03:00
e5ec69f45a
Merge pull request 'Don't type DiskCache's $mimeMap.' ( #55 ) from wn/tt-rss:bugfix/diskcache-mimemap-type into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/55
2021-11-19 07:34:26 +03:00
59a09790eb
Don't type DiskCache's $mimeMap.
...
PHP typing of class properties is only supported on PHP 7.4+.
2021-11-18 23:51:36 +00:00
739c3fe760
Fix Undefined array key "order_by"
2021-11-18 22:33:03 +00:00
4a891b20f0
Fix 'view_mode' default in API#getHeadlines()
2021-11-18 21:31:52 +00:00
d532eb773b
Switch from null to false as the default for missing bool params.
2021-11-18 18:25:04 +00:00
cd71292610
Actually, always clean in Handler._param_to_bool()
2021-11-18 18:18:49 +00:00
16a7208893
Clean string params in Handler._param_to_bool()
2021-11-18 18:16:50 +00:00
2422aae577
Consistently handle param string to bool conversions in handlers.
2021-11-18 18:09:47 +00:00
57d9a5e925
config: use phpdoc comments for global options, etc
2021-11-18 20:51:11 +03:00
d6f604c06c
API/catchupFeed: properly pass is_cat as bool
2021-11-18 20:02:24 +03:00
1ea177491f
* base plugin class: correct description of hook_house_keeping()
...
* cache_starred_images: keep status files in a separate cache directory
2021-11-18 19:54:42 +03:00
b2ffc8c2e3
_format_headlines_list: fix phpstan warning properly
2021-11-18 11:03:26 +03:00
9ac67c7973
API: fix unexpected null being passed to _order_to_override_query
2021-11-18 11:01:46 +03:00
b77f6c9a6b
API: force methods to return bool to make wrap() mistakes easier to track
2021-11-18 10:46:06 +03:00
9e469b1642
api: a few more returns in login
2021-11-18 09:04:08 +03:00
10a1d4d879
api: don't return errors on login success
2021-11-18 09:01:44 +03:00
2d830c6281
Minor correction to RSSUtils::cache_enclosures() $enclosures param type.
...
All FeedEnclosure values are currently strings, even though the numeric things get converted to int before getting inserted in 'ttrss_enclosures'.
2021-11-17 20:45:41 +00:00
fb1e85baaf
Switch FeedParser back to described behavior for setting 'error'.
...
Also some formatting.
2021-11-17 19:29:54 +00:00
aeb4137cbd
document a few more plugin hooks
2021-11-17 18:30:32 +03:00
3e273ea527
add descriptions for some plugin hooks
2021-11-17 15:56:58 +03:00
bd66eff7cc
better check for docker
2021-11-17 10:52:37 +03:00
938f7db482
correctly show non-docker git installs as unsupported
2021-11-17 10:36:04 +03:00
5980b3d2cb
pluginhost: set stricter @params
2021-11-16 18:35:13 +03:00
10d1a8c05a
adjust phpdoc tags for hook definitions/constants (make them reference each other)
2021-11-16 16:31:40 +03:00
ad30d39e2a
not dead: Article.assigntolabel etc are exported methods called by frontend (Headlines.js)
2021-11-16 15:45:35 +03:00
4166628c36
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
2021-11-16 09:19:19 +03:00
6a8030fd76
mailer: don't crash if php mail() fails with no reported errors
2021-11-16 09:19:12 +03:00
d78ba7b3a9
Minor fix in 'classes/articles.php'.
...
It looks like these functions are dead code, though. Adding comments for future review.
2021-11-16 02:14:31 +00:00
b2952843f5
* DiskCache: add download() helper
...
* Af_Comics_Gocomics_FarSide: cache linked images because it seems to
be required anyway
2021-11-15 23:22:21 +03:00
109b702ed0
Minor fix to DOMNodeList#item() potential type (null vs false)
2021-11-15 12:24:38 +00:00
aa924d9ee7
deal with several DOMElement-related errors
2021-11-15 08:26:02 +03:00
2493c9cddd
set better matching type hint on virtual feed object
2021-11-15 08:19:44 +03:00
676c5787e7
require virtual feed plugins to implement IVirtualFeed
2021-11-15 07:11:29 +03:00
3bd13b91c8
add IVirtualFeed interface for plugins implementing virtual feeds
2021-11-15 07:08:41 +03:00
07ea364189
Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6
2021-11-15 06:54:04 +03:00
edc7998851
revise phpdoc annotations for hook_search()
2021-11-15 06:53:55 +03:00
fb208bb136
Fix a PHPStan warning in 'UrlHelper::rewrite_relative()'.
2021-11-15 03:28:17 +00:00
41b4eef504
Address PHPStan warnings for FeedEnclosure.
2021-11-15 02:46:19 +00:00
78acf18b70
Address PHPStan warnings in FeedItem classes.
2021-11-15 02:40:45 +00:00
8943604aad
Change the param type for UserHelper::hash_password() $algo to appease PHPStan.
...
PHPStan was complaining in 'plugins/auth_internal/init.php' due to UserHelper::hash_password() being passed a string, rather than a UserHelper::HASH_ALGO_* constant. Just switching the param to string for now.
2021-11-14 22:44:48 +00:00
324d926eb4
Also fix the param signature for Plugin#hook_hotkey_info()
2021-11-14 22:16:16 +00:00
12f9df1066
Fix the return signature for Plugin#hook_hotkey_info()
2021-11-14 22:11:27 +00:00
6d438c5a77
Address PHPStan warning in 'classes/pref/users.php'.
2021-11-14 20:27:17 +00:00
5632d75a45
Address PHPStan warning in 'classes/pref/system.php'.
2021-11-14 20:26:21 +00:00
abab2a94e8
Address PHPStan warning in 'classes/pref/prefs.php'.
...
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
b8f0627a0e
Address PHPStan warning in 'classes/pref/labels.php'.
2021-11-14 20:13:09 +00:00
56cf425e45
revise prototype for hook_enclosure_imported
2021-11-14 23:03:25 +03:00
9326ed605f
Address PHPStan warning in 'classes/pref/filters.php'.
2021-11-14 17:59:57 +00:00
812f5f532e
Address PHPStan warning in 'classes/mailer.php'.
2021-11-14 17:59:57 +00:00
931a7533ce
adjust some return types in urlhelper
2021-11-14 20:53:30 +03:00
afdb4b0072
set phpdoc annotations for auth_base
2021-11-14 20:26:05 +03:00
6bd6a14c20
revise phpdoc annotations for hook_sanitize()
2021-11-14 20:19:12 +03:00
f5c881586b
Handle potentially null link, title, etc. in FeedParser.
2021-11-14 16:59:21 +00:00
7988c79bd4
plugin.php: add some minor method phpdoc corrections
2021-11-14 18:05:31 +03:00
1b5c61ac85
userhelper: add a phpdoc variable class hint
2021-11-14 18:02:20 +03:00
01b39d985c
deal with the rest of warnings in plugin.php
2021-11-14 18:00:03 +03:00
dd7299b6d0
deal with a few more phpstan warnings re: base plugin class
2021-11-14 17:19:35 +03:00
55729b4bbd
fix HOOK_QUERY_HEADLINES being invoked with different argument lists, add some more phpdoc comments for base plugin class
2021-11-14 17:07:47 +03:00
af2f4460ce
* deal with some phpstan warnings in base plugin class
...
* arguably better hack for incompatible plugins causing E_COMPILE_ERROR
2021-11-14 16:49:10 +03:00
15af164f69
pluginhost: add a hack to not crash on an incompatible plugin more than once (per login) - UGLY
2021-11-14 11:50:55 +03:00
0a2dcacbcf
normalize some mismatching hook function definitions to match base Plugin class
2021-11-14 11:11:49 +03:00
81a10f69bc
deal with phpstan warnings related to base authentication modules
2021-11-14 10:48:32 +03:00
5a50c333b2
Address PHPStan warnings in 'classes/pref/filters.php'.
2021-11-14 00:59:19 +00:00
fe5ada7250
set some annotations on Plugin hook methods
2021-11-13 20:07:13 +03:00
5e34fe17a7
experimental: bring back plugin hooks to Plugin base class once (to be improved/fixed with annotations later)
2021-11-13 20:03:28 +03:00
618e96b793
deal with some warnings in plugins/trgm,readability and base plugin class
2021-11-13 19:55:30 +03:00
03d0692268
no need to duplicate annotations
2021-11-13 19:52:47 +03:00
37827427a2
rework previous Plugin changes as phpdoc annotations
2021-11-13 19:41:50 +03:00
9845d5fd15
revert all plugin base class related changes to keep compatibility with extant plugins (for the time being)
2021-11-13 19:36:26 +03:00
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
2021-11-13 16:00:59 +00:00
a18473e4c0
Address PHPStan warnings in 'classes/pref/feeds.php'.
2021-11-13 15:56:31 +00:00
b37a03fb31
Fix the type of Labels::update_cache()
2021-11-13 15:56:31 +00:00
f2323bda81
fix phpstan warnings in classes/plugin-template.php
2021-11-13 18:26:11 +03:00
70051742af
experimental: also don't keep base plugin template as a non-analyzed file
2021-11-13 18:21:04 +03:00
b381e95792
experimental: auto-generate and add all plugin hook methods to Plugin class
2021-11-13 18:18:05 +03:00
8a83f061bf
fix phpstan warnings in classes/sanitizer.php
2021-11-13 17:52:03 +03:00
a7983d475e
fix phpstan warnings in classes/api.php
2021-11-13 17:51:26 +03:00
77b8dc7386
fix phpstan warnings in classes/feedparser.php
2021-11-13 17:48:52 +03:00
45431170b6
fix phpstan warnings in classes/db/migrations.php
2021-11-13 17:31:13 +03:00
3ba8d964b6
Address PHPStan warnings in 'classes/api.php'.
2021-11-13 14:15:20 +00:00
1ec003ce35
Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag).
2021-11-13 14:05:48 +00:00
25775bb407
Fix type of 'check_first_id' in Feeds '_format_headlines_list'.
2021-11-13 04:16:36 +00:00
d3a81f598b
Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0
2021-11-12 21:17:31 +00:00
2c41bc7fbc
Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'.
2021-11-12 06:16:18 +00:00
9db5e402a0
Address PHPStan warnings in 'classes/rpc.php'.
...
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'.
2021-11-12 05:42:55 +00:00
011c941e7c
Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'.
2021-11-12 05:24:02 +00:00
b0eb347839
Fix a warning in 'classes/counters.php'.
2021-11-12 05:04:55 +00:00
763515de79
Address PHPStan warnings in 'classes/feeds.php'.
...
Also some minor related tweaks in other classes.
2021-11-12 04:48:06 +00:00
5606e38bff
Update signature of handler 'csrf_ignore' to include types.
2021-11-12 02:01:31 +00:00
57bf56f794
Address PHPStan warnings in 'classes/article.php'.
...
Also related changes in some other classes.
2021-11-12 01:50:40 +00:00
a0f37c3206
Address PHPStan warnings in 'classes/pluginhost.php'.
2021-11-12 00:06:00 +00:00
95277fd099
Address PHPStan warnings in 'classes/labels.php'.
2021-11-11 22:28:13 +00:00
2d5603b196
Address PHPStan warnings in 'classes/diskcache.php'.
2021-11-11 22:07:32 +00:00
50997df57a
Address PHPStan warnings in 'inclasses/digest.php'.
2021-11-11 21:46:44 +00:00
728a71150a
Fix 'TimeHelper::make_local_datetime()' (null is allowed).
2021-11-11 21:33:12 +00:00
58ea0d4339
Address PHPStan warnings in 'classes/debug.php'.
2021-11-11 21:02:06 +00:00
2e3a9098b9
Address PHPStan warnings in 'classes/userhelper.php'.
2021-11-11 20:25:13 +00:00
f704d25ab1
Address PHPStan warnings in 'classes/timehelper.php'.
2021-11-11 20:12:47 +00:00
03495c11ed
Address PHPStan warnings in 'classes/sanitizer.php'.
...
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
2021-11-11 19:59:25 +00:00
3f8aaffd34
Address PHPStan warnings in 'classes/rssutils.php'.
...
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure).
2021-11-11 18:53:52 +00:00
eb068fbc47
Address PHPStan warnings in 'classes/prefs.php'.
2021-11-11 16:47:51 +00:00
14ca0f2ac0
Address PHPStan warnings in 'classes/counters.php'.
2021-11-11 12:26:30 +00:00
7a919a79d7
Fix some additional PHPStan warnings in UrlHelper.
2021-11-11 11:12:40 +00:00
4cc3374f9f
Initial go at PHPStan rule level 6.
2021-11-10 21:38:25 +00:00
9e8d69739f
add two helper account access levels:
...
- read only - can't subscribe to more feeds, feed updates are skipped
- disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
2021-11-10 20:44:51 +03:00
9dac9c5a0d
Address PHPStan warnings in 'classes/urlhelper.php'.
...
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array.
------ ---------------------------------------------------------------------
Line classes/urlhelper.php
------ ---------------------------------------------------------------------
66 Offset 'path' on array{scheme: string} in isset() does not exist.
165 Parameter #2 $associative of function get_headers expects bool, int
given.
167 Parameter #2 $associative of function get_headers expects bool, int
given.
278 Negated boolean expression is always true.
309 Negated boolean expression is always true.
------ ---------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
ac5a4f5937
Address PHPStan warning in 'classes/pref/users.php'.
...
------ -------------------------------
Line classes/pref/users.php
------ -------------------------------
170 If condition is always false.
------ -------------------------------
2021-11-01 21:10:27 +00:00
a38892d5d7
Address PHPStan warning in 'classes/pref/prefs.php'.
...
------ ------------------------------------------------
Line classes/pref/prefs.php
------ ------------------------------------------------
1328 Expression on left side of ?? is not nullable.
------ ------------------------------------------------
2021-11-01 21:10:27 +00:00
8a920a16e7
Address PHPStan warnings in 'classes/pluginhost.php'.
...
------ --------------------------------------------------------------------
Line classes/pluginhost.php
------ --------------------------------------------------------------------
16 Property PluginHost::$last_registered is never read, only written.
386 If condition is always true.
------ --------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
a7a59fe0e2
Address PHPStan warning in 'classes/logger/sql.php'.
...
------ --------------------------------------
Line classes/logger/sql.php
------ --------------------------------------
4 Property Logger_SQL::$pdo is unused.
------ --------------------------------------
2021-11-01 21:10:27 +00:00
72cf4f1f0d
Address PHPStan warning in 'classes/feeds.php'.
...
------ ------------------------------------
Line classes/feeds.php
------ ------------------------------------
8 Property Feeds::$params is unused.
------ ------------------------------------
2021-11-01 21:10:27 +00:00
5b17c44e70
Address PHPStan warning in 'classes/feeditem/common.php'.
...
------ ---------------------------------------------
Line classes/feeditem/common.php
------ ---------------------------------------------
194 No error to ignore is reported on line 194.
------ ---------------------------------------------
2021-11-01 21:10:27 +00:00
7d8837ca17
Address PHPStan warnings in 'classes/db.php'.
...
------ --------------------------------------------------
Line classes/db.php
------ --------------------------------------------------
7 Property Db::$link is unused.
86 Property Db::pdo (PDO) in empty() is not falsy.
------ --------------------------------------------------
2021-11-01 21:10:27 +00:00
77a98134b8
Address PHPStan warnings in 'classes/config.php'.
...
------ -----------------------------------------------------------------------
Line classes/config.php
------ -----------------------------------------------------------------------
3 Constant Config::_ENVVAR_PREFIX is unused.
177 Constant Config::_DEFAULTS is unused.
237 Property Config::$schema_version is never read, only written.
352 Property Config::$migrations (Db_Migrations) in empty() is not falsy.
------ -----------------------------------------------------------------------
2021-11-01 21:10:26 +00:00
76d8b1bf6f
HOOK_ARTICLE_BUTTON/HOOK_ARTICLE_LEFT_BUTTON: only try to parse markup if its actually there
2021-10-26 15:45:12 +03:00
933913410c
css: make plugin button container a flexbox
...
backend: pass plugin button generated code through domdocument to ensure
its correctness; set data-plugin-name attribute on children to make
them sortable via css
2021-10-24 20:11:49 +03:00
9f734c9050
minor phpstan tweaks
2021-10-22 13:49:08 +03:00
41245da8a6
pluginhost: update comments for HOOK_ constants to use phpdoc syntax; add HOOK_PRE_SUBSCRIBE
2021-10-22 13:24:10 +03:00
aead30a041
Fix undefined array key "output" when adding new label
2021-10-15 23:05:50 +00:00
a936e80630
OPML improvements/fixes:
...
* allow CLI import of OPML files (--opml-import)
* visualize OPML structure when importing
* add strict type hints to most OPML class methods
2021-10-15 10:06:00 +03:00
145fc31625
feed tree context menu: add an entry to open originating website
2021-10-10 22:08:17 +03:00
949e2ab4d2
properly sanitize video poster attribute
2021-09-24 08:40:06 +03:00
8ed927dbd2
OPML: multiple fixes
...
- remove unused integer indexes when exporting filters as JSON
- fix warning when importing filters without rules
- properly assign category IDs for category filter rules
- fix warning: check if outline attributes like xmlUrl are set before trying to use them
- fix warning: don't try to use libxml_disable_entity_loader on PHP 8
2021-09-08 09:04:15 +03:00
78ff7770d1
classes/opml: fix indentation; when importing, don't produce warning
...
on filters with no rules defined.
2021-09-08 08:12:13 +03:00
36e174750e
fix label ordering in feed tree
2021-09-02 08:21:05 +03:00
e8f9567d79
fix password recovery
2021-08-25 18:18:04 +02:00
a1173ab06a
block useless usort() E_DEPRECATED for the time being
2021-08-23 18:38:37 +03:00
2c931df77c
remove SELF_USER_AGENT custom constant, replaced with configurable Config::HTTP_USER_AGENT / Config::get_user_agent()
2021-08-23 10:56:31 +03:00
5c60254474
Pref_Feeds:calculate_children_count - fix operator precedence
2021-08-23 10:45:34 +03:00
0808123179
fix broken feed tree generation when categories are disabled
2021-08-18 21:02:58 +03:00
23b4152c9e
Make prefs feed search case-insensitive.
...
Previously the search query had to match lower title or feed_url (i.e. searching w/ uppercase wouldn't match).
2021-08-17 23:14:14 +00:00
992e9cd9e3
Use ORM more in 'classes/pref/feeds.php'.
2021-08-17 23:03:35 +00:00
73d14338ab
fix rendering of category filters on Uncategorized
2021-07-28 12:59:47 +03:00
14d57d9a14
Rewrite feed entry link as href content
2021-06-19 14:36:04 +02:00
ltGuillaume
Andrew Dolgov
David Edler
fox
wn_
Philip Klempin
jmechnich