Commit Graph

11364 Commits

Author SHA1 Message Date
Andrew Dolgov 3323ae78ce * sql_bool_to_bool: make parameter nullable
* errorhandler: don't try to truncate null strings
 * UrlHelper::rewrite_relative: fix undefined offset warnings for URLs
that lack schema/host (data: etc)
2021-11-20 16:11:44 +03:00
Andrew Dolgov e7111e4f14 sanitize: make force_remove_images nullable 2021-11-20 14:02:37 +03:00
Andrew Dolgov 2b4ba59a79 feeds/add: force cast category id to integer 2021-11-19 17:02:25 +03:00
fox 0a3a464def Merge pull request 'Consistently handle param string to bool conversions in handlers.' (#53) from wn/tt-rss:feature/consistent-param-to-bool into master
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/53
2021-11-19 07:36:15 +03:00
fox 3070933f64 Merge pull request 'Fix Undefined array key "order_by"' (#54) from klempin/tt-rss:master into master
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/54
2021-11-19 07:35:20 +03:00
fox e5ec69f45a Merge pull request 'Don't type DiskCache's $mimeMap.' (#55) from wn/tt-rss:bugfix/diskcache-mimemap-type into master
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/55
2021-11-19 07:34:26 +03:00
wn_ 59a09790eb Don't type DiskCache's $mimeMap.
PHP typing of class properties is only supported on PHP 7.4+.
2021-11-18 23:51:36 +00:00
Philip Klempin 739c3fe760 Fix Undefined array key "order_by" 2021-11-18 22:33:03 +00:00
wn_ 4a891b20f0 Fix 'view_mode' default in API#getHeadlines() 2021-11-18 21:31:52 +00:00
wn_ d532eb773b Switch from null to false as the default for missing bool params. 2021-11-18 18:25:04 +00:00
wn_ cd71292610 Actually, always clean in Handler._param_to_bool() 2021-11-18 18:18:49 +00:00
wn_ 16a7208893 Clean string params in Handler._param_to_bool() 2021-11-18 18:16:50 +00:00
wn_ 2422aae577 Consistently handle param string to bool conversions in handlers. 2021-11-18 18:09:47 +00:00
Andrew Dolgov 57d9a5e925 config: use phpdoc comments for global options, etc 2021-11-18 20:51:11 +03:00
Andrew Dolgov d6f604c06c API/catchupFeed: properly pass is_cat as bool 2021-11-18 20:02:24 +03:00
Andrew Dolgov 1ea177491f * base plugin class: correct description of hook_house_keeping()
* cache_starred_images: keep status files in a separate cache directory
2021-11-18 19:54:42 +03:00
Andrew Dolgov b2ffc8c2e3 _format_headlines_list: fix phpstan warning properly 2021-11-18 11:03:26 +03:00
Andrew Dolgov 9ac67c7973 API: fix unexpected null being passed to _order_to_override_query 2021-11-18 11:01:46 +03:00
Andrew Dolgov b77f6c9a6b API: force methods to return bool to make wrap() mistakes easier to track 2021-11-18 10:46:06 +03:00
Andrew Dolgov 9e469b1642 api: a few more returns in login 2021-11-18 09:04:08 +03:00
Andrew Dolgov 10a1d4d879 api: don't return errors on login success 2021-11-18 09:01:44 +03:00
Andrew Dolgov 63ec5a8965 Merge branch 'wip-phpstan-level6' 2021-11-18 07:32:28 +03:00
wn_ 2d830c6281 Minor correction to RSSUtils::cache_enclosures() $enclosures param type.
All FeedEnclosure values are currently strings, even though the numeric things get converted to int before getting inserted in 'ttrss_enclosures'.
2021-11-17 20:45:41 +00:00
wn_ fb1e85baaf Switch FeedParser back to described behavior for setting 'error'.
Also some formatting.
2021-11-17 19:29:54 +00:00
Andrew Dolgov aeb4137cbd document a few more plugin hooks 2021-11-17 18:30:32 +03:00
Andrew Dolgov 3e273ea527 add descriptions for some plugin hooks 2021-11-17 15:56:58 +03:00
Andrew Dolgov 34f294414f schema: remove default subscription of admin to the forums rss feed 2021-11-17 11:35:40 +03:00
Andrew Dolgov bd66eff7cc better check for docker 2021-11-17 10:52:37 +03:00
Andrew Dolgov 938f7db482 correctly show non-docker git installs as unsupported 2021-11-17 10:36:04 +03:00
Andrew Dolgov 5980b3d2cb pluginhost: set stricter @params 2021-11-16 18:35:13 +03:00
Andrew Dolgov 10d1a8c05a adjust phpdoc tags for hook definitions/constants (make them reference each other) 2021-11-16 16:31:40 +03:00
Andrew Dolgov ad30d39e2a not dead: Article.assigntolabel etc are exported methods called by frontend (Headlines.js) 2021-11-16 15:45:35 +03:00
Andrew Dolgov 4166628c36 Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6 2021-11-16 09:19:19 +03:00
Andrew Dolgov 6a8030fd76 mailer: don't crash if php mail() fails with no reported errors 2021-11-16 09:19:12 +03:00
wn_ d78ba7b3a9 Minor fix in 'classes/articles.php'.
It looks like these functions are dead code, though.  Adding comments for future review.
2021-11-16 02:14:31 +00:00
Andrew Dolgov b2952843f5 * DiskCache: add download() helper
* Af_Comics_Gocomics_FarSide: cache linked images because it seems to
be required anyway
2021-11-15 23:22:21 +03:00
Andrew Dolgov 3a3fde1a2e when uninstall plugins, refresh plugins index instead of reloading entire prefs pane 2021-11-15 20:18:50 +03:00
Andrew Dolgov 8cd69fe15c when uninstall plugins, refresh plugins index instead of reloading entire prefs pane 2021-11-15 20:18:37 +03:00
Andrew Dolgov ef1e2a8b2f update dojo/dijit to 1.16.4 2021-11-15 18:48:47 +03:00
Andrew Dolgov 1db1be7a81 update phpstan to 1.1.2 (composer files) 2021-11-15 18:44:24 +03:00
Andrew Dolgov 4c37fa4b41 update phpstan to 1.1.2; update php-qrcode to 3.4.1 2021-11-15 18:33:35 +03:00
wn_ 109b702ed0 Minor fix to DOMNodeList#item() potential type (null vs false) 2021-11-15 12:24:38 +00:00
Andrew Dolgov 85b974af32 auth_internal: limit password throttling to failed login attempts not using OTP 2021-11-15 13:16:49 +03:00
Andrew Dolgov 26f47c0694 remove themes/Makefile (obsolete, replaced with gulp) 2021-11-15 08:27:49 +03:00
Andrew Dolgov aa924d9ee7 deal with several DOMElement-related errors 2021-11-15 08:26:02 +03:00
Andrew Dolgov a92070da06 unignore several phpstan errors 2021-11-15 08:20:56 +03:00
Andrew Dolgov 2493c9cddd set better matching type hint on virtual feed object 2021-11-15 08:19:44 +03:00
Andrew Dolgov 676c5787e7 require virtual feed plugins to implement IVirtualFeed 2021-11-15 07:11:29 +03:00
Andrew Dolgov 8dfefe7968 add IVirtualFeed interface for plugins implementing virtual feeds 2021-11-15 07:08:52 +03:00
Andrew Dolgov 3bd13b91c8 add IVirtualFeed interface for plugins implementing virtual feeds 2021-11-15 07:08:41 +03:00