Commit Graph

267 Commits

Author SHA1 Message Date
Andrew Dolgov 63f0ed3d9c cdmClicked: do not use event.target.parents to figure out if clicked on a heading 2017-03-06 12:19:13 +03:00
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
2017-03-04 14:34:44 +03:00
Andrew Dolgov b835a52814 rework the way headlines menus identify calling row 2017-02-17 09:01:45 +03:00
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 2017-02-13 23:36:58 +03:00
Andrew Dolgov 20deb5fc32 cdmcollapse/expand: use less convoluted selector queries 2017-02-13 22:45:30 +03:00
Andrew Dolgov 829d478f1b add some protection against opener attacks if external site is opened via window.open() 2017-02-08 15:07:05 +03:00
Andrew Dolgov ad326dbf78 unpackVisibleHeadlines: do not iterate over all RROWs all the time 2017-01-22 20:57:16 +03:00
Andrew Dolgov 3bc1b53772 initHeadlinesMenu: remove unneeded output 2017-01-22 19:58:17 +03:00
Andrew Dolgov 974c6eb523 attach headline menu objects to correct DOM nodes in combined mode 2017-01-22 19:57:16 +03:00
Andrew Dolgov e1f7b05b52 reuse menu objects while appending headline rows 2017-01-22 19:20:23 +03:00
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 16:52:27 -05:00
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 2016-03-22 23:43:32 +03:00
Andrew Dolgov 2d052e42b5 getLoadedArticleIds: consider visible rows only
catchupFeedInGroup: hide articles when catching up, with caveats
2016-03-22 23:22:28 +03:00
Andrew Dolgov 6be118fda1 showArticleInHeadlines: remove unused code 2016-03-22 13:41:55 +03:00
Andrew Dolgov c4e211046e updateFloatingMenu: performance improvements 2016-03-22 13:38:20 +03:00
Andrew Dolgov d7cc5e6cdd fix previous 2016-03-22 12:51:15 +03:00
Andrew Dolgov 63c7446a79 headlines scroll handler: add a rate limit 2016-03-22 12:43:18 +03:00
Andrew Dolgov 7c0d68f207 remove dismiss* functions 2016-03-22 10:28:34 +03:00
Andrew Dolgov 6056d164fa cleanup dismissArticle functions 2016-03-22 10:11:11 +03:00
Kostiantyn Moroz 2757c49387 Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode) 2016-02-07 18:48:24 +00:00
Andrew Dolgov 0b41bd3414 add some hacks to hopefully mitigate headlines memory leaks 2016-01-11 01:11:26 +03:00
Andrew Dolgov a71e571b97 headlines_callback2: force prevent duplicate row ids 2015-10-07 18:14:21 +03:00
Andrew Dolgov a0dbc45acd add edit feed to feed header context menu in grouped mode 2015-09-07 12:49:49 +03:00
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
2015-08-12 14:09:46 +03:00
Andrew Dolgov 6810a1de42 use dijit form widget for attachments dropdown 2015-08-11 14:53:07 +03:00
Andrew Dolgov 176a489e54 use batch-based catching up in cdmExpandArticle() to reduce server load 2015-08-11 12:25:11 +03:00
Andrew Dolgov eaec06f950 prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
a bunch of other related fixes
2015-08-11 12:00:08 +03:00
Andrew Dolgov 95b493d68d partially revert previous because of navigation breakage in expanded mode, durrr 2015-08-11 11:31:50 +03:00
Andrew Dolgov b71add41d5 unfuck catchupbatchedarticles a bit 2015-08-11 10:12:22 +03:00
Andrew Dolgov 8292123ebc assorted fixes for keyboard navigation which hopefully don't break everything else 2015-08-11 10:06:30 +03:00
Andrew Dolgov 231c672c5d fix previous 2015-08-11 09:12:57 +03:00
Andrew Dolgov 837443630f infscroll: preload articles a bit earlier 2015-08-11 09:05:04 +03:00
Andrew Dolgov d8e8e24e34 pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense) 2015-07-31 13:42:05 +03:00
Andrew Dolgov 8691b32abf disable headline appear animation 2015-07-29 18:11:23 +03:00
Andrew Dolgov d46af5a5cf headlines scroll handler: make preloading less aggressive 2015-07-29 16:57:24 +03:00
Andrew Dolgov e7a66d1230 (experimental) disable infscroll requests while marking auto catched up articles as read 2015-07-14 12:50:27 +03:00
Andrew Dolgov 33c4bd8968 fix error feed (i.e. when requested feed no longer exists) not display properly 2015-07-13 22:04:21 +03:00
Andrew Dolgov f17069960c roll back separate headline transport 2015-07-13 22:01:29 +03:00
Andrew Dolgov 57c521df91 maybe speedup headline adding a bit, maybe not 2015-07-13 18:38:39 +03:00
Andrew Dolgov 9ef1985f1b viewfeed.js: cleanup the code a bit 2015-07-13 01:28:02 +03:00
Andrew Dolgov ac4c1383ae bring cdmFeedTitle style in line with the rest of the UI
send headline rows as separate JSON objects
2015-07-13 01:19:52 +03:00
Andrew Dolgov 48fefe2f6b fixes for first_id stuff 2015-07-12 18:08:02 +03:00
Andrew Dolgov 39d488a256 viewfeed: set hsp status when scrolling to the very end 2015-07-12 13:37:24 +03:00
Andrew Dolgov 15ae8cd084 js: remove current_top_id global 2015-07-12 13:30:00 +03:00
Andrew Dolgov 3444020100 report top id changed in headlines buffer 2015-07-12 12:01:34 +03:00
Andrew Dolgov f5a0fb8b64 queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating 2015-07-12 01:29:36 +03:00
Andrew Dolgov 5a45821ec9 prevent event propagation when clicking on CDM article footer 2015-06-18 16:00:03 +03:00
Andrew Dolgov a72cd54ce1 bayes: properly reset score when going good -> ugly
article: add helper to refresh article score pic, properly set scorepic title
2015-06-17 22:04:32 +03:00
Anders Kaseorg 5c145bde7a Make the floating title transition smoother
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting.  Now it
appears at the point when its bottom lines up with the real title’s
bottom.  This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.

We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden.  It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.

Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2015-01-30 21:58:44 -05:00
Andrew Dolgov 760183e37d minor spacer/whiteBox appearance tweaks 2014-07-26 22:08:33 +04:00
Andrew Dolgov 1d6191ee0a always create headline-spacer on lazy load 2014-07-26 22:00:33 +04:00
Andrew Dolgov 74217c72a1 adjust scroll amount to trigger auto-opening next unread feed 2014-07-25 15:40:38 +04:00
Andrew Dolgov 22f675e5c4 add a link to headlines-spacer to open next unread feed 2014-07-25 13:54:10 +04:00
Andrew Dolgov 0f85f483e5 another implementation of pull 386 (show next when finished reading) (2) 2014-07-25 12:29:30 +04:00
Andrew Dolgov b7c20a3759 another implementation of pull 386 (show next when finished reading) 2014-07-25 12:14:06 +04:00
Andrew Dolgov 6472dd11a2 Revert "scroll to end to show next feed or category"
This reverts commit 86f32020f6.
2014-07-25 09:20:00 +04:00
wolle 86f32020f6 scroll to end to show next feed or category
only if cmd_auto_catchup and on_catchup_show_next_feed set
2014-06-28 15:04:08 +02:00
Andrew Dolgov bace5e9e6f prevent cdmClicked ctrl-click handler working on article body 2014-05-08 06:41:21 +00:00
Andrew Dolgov df63125dd7 handle_rpc_json: do not crash if net-alert is somehow unavailable 2014-03-14 14:05:32 +04:00
Andrew Dolgov 1bffd1068f unify main and headlines toolbar 2014-01-27 22:03:42 +04:00
Andrew Dolgov b8fd08d6db do not unpack all visible headlines in collapsed mode because those are unpacked on expand 2013-10-21 16:55:36 +04:00
Andrew Dolgov 24940c3dc9 catchup group: deselect everything before processing 2013-10-20 18:45:24 +04:00
Andrew Dolgov 87065739cd add context menu for cdmFeedTitle; change mark as read prompt for grouped headlines more clear 2013-10-17 13:38:48 +04:00
Andrew Dolgov 2e35b3bd6b prevent automatic selection of headlines row first child when scrolling in 3panel mode because it screws with keyboard navigation (closes #752) 2013-09-09 14:38:28 +04:00
Andrew Dolgov 95be6e0c89 fix second row being selected on viewfeed (closes #748) 2013-07-17 12:16:54 +04:00
Andrew Dolgov 00fe7886b6 update floating title unread status when auto catching up 2013-07-16 10:05:48 +04:00
Andrew Dolgov 41d37fb2c3 add experimental hack to show row unread status in floating title 2013-07-16 09:59:14 +04:00
Andrew Dolgov 0971cc619d remove dijit checkbox element from floatingTitle 2013-07-15 09:15:07 +04:00
Andrew Dolgov 65f0eb01aa support headlines context menu in floating title 2013-07-11 16:49:25 +04:00
Andrew Dolgov 7415fcf212 enable floating title for expandable combined mode, minor expandable mode fixes 2013-07-11 12:28:24 +04:00
Andrew Dolgov 301a09dc55 fix floating title sometimes obscuring next article title 2013-07-11 08:35:12 +04:00
Andrew Dolgov d095f42fa4 floating title: remove cdm auto catchup id hack for the time being 2013-07-10 22:16:10 +04:00
Andrew Dolgov 8ee5e9e5e6 rework floatingtitle 2013-07-10 22:11:24 +04:00
Andrew Dolgov 03304fda54 if multiple articles are selected, do not reset active article / selection on scroll if auto catchup is enabled 2013-07-09 12:34:57 +04:00
Andrew Dolgov 4f62f8f6dc add js hook for floating title 2013-06-28 08:30:35 +04:00
Veit Lehmann d1754390cc only do article update operations once when scrolling
I discovered that DOM operations and function calls were done several times inside the 100px mirror when scrolling through articles. Especially painful on seamless scrolling systems like Mac OS, where dozens of updates would slow down this part dramatically. This change fixes it.
2013-06-25 06:08:44 +03:00
Andrew Dolgov d1343b844d make floating title less cpu intensive 2013-06-25 01:35:07 +04:00
Jeffrey Tolar 3b2605a02e Add some checks to see if the content element exists
This *might* help dismissal not break when not using combined mode.
2013-06-21 23:49:35 -05:00
Jeffrey Tolar 055a37e083 Fix incorrect function name in exception handling 2013-06-21 23:31:59 -05:00
Jeffrey Tolar abba5dd4d4 Remove content when an article is dismissed 2013-06-21 23:30:55 -05:00
Veit Lehmann 5313ae17e4 only update floatingTitle innerHTML if active article changes
This will boost scrolling performance pretty much and avoid flickering of floatingTitle
2013-06-09 02:02:14 +03:00
Andrew Dolgov 5f9699a53f hide floatingTitle when first batch of headlines is received 2013-06-07 10:04:43 +04:00
Andrew Dolgov 19b906b94b block automarking headlines on scroll in unexpanded cdm because it doesn't work so well 2013-06-06 10:09:02 +04:00
Andrew Dolgov 08820be70b add experimental floating title when scrolling long articles in combined mode 2013-06-05 22:20:22 +04:00
Andrew Dolgov 1ffd534f43 fix wrong article context menu item toggle marked (should be toggle starred) 2013-05-29 16:14:32 +04:00
Andrew Dolgov 2a7362596f moveToPost: check for current article element existing before getting its position info (closes #695) 2013-05-27 22:11:20 +04:00
Andrew Dolgov 6e098e5e8c enlarge auto mark offset height 2013-05-16 10:52:33 +04:00
Andrew Dolgov 99d89d10b0 when auto selecting, only select articles actually near the buffer top 2013-05-16 10:50:38 +04:00
Andrew Dolgov 4bc6489a80 previous patch, fix typo 2013-05-16 10:00:29 +04:00
Andrew Dolgov cc8d254a61 previous patch, remove active_found 2013-05-16 09:54:12 +04:00
Andrew Dolgov 48be35ca06 while cdm_auto_catchup is enabled, after scrolling set active article to the topmost visible in the buffer so that n/p hotkeys would not reset scrolling position 2013-05-16 09:53:34 +04:00
Andrew Dolgov c068b98b72 add some subtle css shadows 2013-05-14 15:28:16 +04:00
Andrew Dolgov 2a3e8d7f34 Merge branch 'master' of github.com:gothfox/Tiny-Tiny-RSS 2013-05-04 12:02:08 +04:00
Andrew Dolgov 8d090a910b use css nth-child instead of old even/odd class hacks for normal mode 2013-05-04 12:01:53 +04:00
Jeffrey Tolar b43b92928a Update selected count when collapsing an article 2013-05-02 18:15:41 -05:00
Andrew Dolgov ea18cceaca remove splash before freshfeed is loaded 2013-05-02 09:48:38 +04:00
Andrew Dolgov 204f9b186f remove cdmUnexpandArticle 2013-04-25 14:04:49 +04:00
Andrew Dolgov 2779e22bf5 js: add collapsed and expanded hooks 2013-04-25 10:09:40 +04:00
Andrew Dolgov 06a02265c4 inject headlines-spacer even if cdm auto catchup is disabled 2013-04-25 09:43:36 +04:00
Andrew Dolgov 8d388f321b add a simple JS-based hook host 2013-04-24 19:49:37 +04:00