9845d5fd15
revert all plugin base class related changes to keep compatibility with extant plugins (for the time being)
2021-11-13 19:36:26 +03:00
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
2021-11-13 16:00:59 +00:00
a18473e4c0
Address PHPStan warnings in 'classes/pref/feeds.php'.
2021-11-13 15:56:31 +00:00
b37a03fb31
Fix the type of Labels::update_cache()
2021-11-13 15:56:31 +00:00
f2323bda81
fix phpstan warnings in classes/plugin-template.php
2021-11-13 18:26:11 +03:00
70051742af
experimental: also don't keep base plugin template as a non-analyzed file
2021-11-13 18:21:04 +03:00
b381e95792
experimental: auto-generate and add all plugin hook methods to Plugin class
2021-11-13 18:18:05 +03:00
8a83f061bf
fix phpstan warnings in classes/sanitizer.php
2021-11-13 17:52:03 +03:00
a7983d475e
fix phpstan warnings in classes/api.php
2021-11-13 17:51:26 +03:00
77b8dc7386
fix phpstan warnings in classes/feedparser.php
2021-11-13 17:48:52 +03:00
45431170b6
fix phpstan warnings in classes/db/migrations.php
2021-11-13 17:31:13 +03:00
3ba8d964b6
Address PHPStan warnings in 'classes/api.php'.
2021-11-13 14:15:20 +00:00
1ec003ce35
Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag).
2021-11-13 14:05:48 +00:00
25775bb407
Fix type of 'check_first_id' in Feeds '_format_headlines_list'.
2021-11-13 04:16:36 +00:00
d3a81f598b
Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0
2021-11-12 21:17:31 +00:00
2c41bc7fbc
Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'.
2021-11-12 06:16:18 +00:00
9db5e402a0
Address PHPStan warnings in 'classes/rpc.php'.
...
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'.
2021-11-12 05:42:55 +00:00
011c941e7c
Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'.
2021-11-12 05:24:02 +00:00
b0eb347839
Fix a warning in 'classes/counters.php'.
2021-11-12 05:04:55 +00:00
f0ad5881c0
PHPStan warning fix in 'backend.php'.
2021-11-12 04:53:53 +00:00
734be4ebd1
Minor PHPStand warning fix in 'update.php'.
2021-11-12 04:51:35 +00:00
763515de79
Address PHPStan warnings in 'classes/feeds.php'.
...
Also some minor related tweaks in other classes.
2021-11-12 04:48:06 +00:00
5606e38bff
Update signature of handler 'csrf_ignore' to include types.
2021-11-12 02:01:31 +00:00
57bf56f794
Address PHPStan warnings in 'classes/article.php'.
...
Also related changes in some other classes.
2021-11-12 01:50:40 +00:00
a0f37c3206
Address PHPStan warnings in 'classes/pluginhost.php'.
2021-11-12 00:06:00 +00:00
95277fd099
Address PHPStan warnings in 'classes/labels.php'.
2021-11-11 22:28:13 +00:00
2d5603b196
Address PHPStan warnings in 'classes/diskcache.php'.
2021-11-11 22:07:32 +00:00
50997df57a
Address PHPStan warnings in 'inclasses/digest.php'.
2021-11-11 21:46:44 +00:00
cc220058e0
Address PHPStan warnings in 'include/functions.php'.
2021-11-11 21:37:34 +00:00
728a71150a
Fix 'TimeHelper::make_local_datetime()' (null is allowed).
2021-11-11 21:33:12 +00:00
58ea0d4339
Address PHPStan warnings in 'classes/debug.php'.
2021-11-11 21:02:06 +00:00
00b86bac39
Address PHPStan warnings in 'include/errorhandler.php'.
2021-11-11 20:47:29 +00:00
e4b8e2d063
Address PHPStan warnings in 'include/controls_compat.php'.
2021-11-11 20:47:20 +00:00
d2ccbecea6
Address PHPStan warnings in 'include/controls.php'.
2021-11-11 20:47:12 +00:00
2e3a9098b9
Address PHPStan warnings in 'classes/userhelper.php'.
2021-11-11 20:25:13 +00:00
f704d25ab1
Address PHPStan warnings in 'classes/timehelper.php'.
2021-11-11 20:12:47 +00:00
03495c11ed
Address PHPStan warnings in 'classes/sanitizer.php'.
...
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
2021-11-11 19:59:25 +00:00
3f8aaffd34
Address PHPStan warnings in 'classes/rssutils.php'.
...
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure).
2021-11-11 18:53:52 +00:00
eb068fbc47
Address PHPStan warnings in 'classes/prefs.php'.
2021-11-11 16:47:51 +00:00
bf2bb875ab
Address PHPStan warnings in 'include/sessions.php'.
2021-11-11 15:57:03 +00:00
14ca0f2ac0
Address PHPStan warnings in 'classes/counters.php'.
2021-11-11 12:26:30 +00:00
0f324b77df
Address PHPStan warning and tweak 'tasks'+'interval' handling in 'update_daemon2.php'.
...
This ensures both are of the expected type (int) and meet a reasonable minimum.
2021-11-11 12:11:33 +00:00
7a919a79d7
Fix some additional PHPStan warnings in UrlHelper.
2021-11-11 11:12:40 +00:00
bf53dfa515
Don't use 'mixed' directly (PHP 8+).
2021-11-10 21:53:28 +00:00
4cc3374f9f
Initial go at PHPStan rule level 6.
2021-11-10 21:38:25 +00:00
87a30d88d3
plugin cleanup re: phpstan 1.0 warnings
2021-11-10 20:58:40 +03:00
9e8d69739f
add two helper account access levels:
...
- read only - can't subscribe to more feeds, feed updates are skipped
- disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
2021-11-10 20:44:51 +03:00
7a52560e4e
Merge pull request 'PHPStan 1.0.0 and related warning fixes' ( #49 ) from wn/tt-rss:feature/phpstan-1.0.0-and-fixes into master
...
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/49
2021-11-02 08:37:11 +03:00
57436ee0c1
Address PHPStan warning in 'update.php'.
...
------ --------------------------------------
Line update.php
------ --------------------------------------
213 While loop condition is always true.
------ --------------------------------------
2021-11-01 21:10:27 +00:00
3cc60a0219
Address PHPStan warnings in 'include/colors.php'.
...
------ ------------------------------------------------------------------
Line include/colors.php
------ ------------------------------------------------------------------
215 Variable $out might not be defined.
223 Parameter #3 $pad_string of function str_pad expects string, int
given.
255 Variable $h might not be defined.
317 Variable $img might not be defined.
------ ------------------------------------------------------------------
2021-11-01 21:10:27 +00:00
Andrew Dolgov
wn_
fox