Commit Graph

206 Commits

Author SHA1 Message Date
Andrew Dolgov 1b91bb4564 don't compare result with undefined seq 2018-11-29 21:07:19 +03:00
Andrew Dolgov 4508e3103d some more eslint-related stuff 2018-11-29 21:03:55 +03:00
Andrew Dolgov 8572e0108a declare globals with let 2018-11-29 20:09:25 +03:00
Andrew Dolgov 424e28db6b eslint-related fixes 2018-11-29 20:07:23 +03:00
Andrew Dolgov a3e2f1a9c3 define custom dojo modules with define() instead of require(), update startup module dependencies 2018-08-23 09:56:34 +03:00
wn_ a972ab45bd strict js: various var fixes 2018-03-14 20:02:21 -05:00
Andrew Dolgov 7560e54e39 switchPanelMode: strict-mode fix for article_id 2018-03-14 19:45:10 +03:00
wn_ ad04bbf81d strict js: fix more dialog vars 2018-03-10 07:11:33 -06:00
Andrew Dolgov 3009ecc44f initial for JS strict mode 2018-03-08 18:33:42 +03:00
Andrew Dolgov 0518510814 remove some obsolete stuff, fix minor issues found by code analyzer 2017-12-04 11:02:13 +03:00
Andrew Dolgov 22adcd7466 request counters less times during startup, delay initial request in feedlist_init() a bit 2017-07-30 21:53:11 +03:00
Andrew Dolgov 267bcee32c quickAddFeed: fix legacy feed_id type being passed to newrule 2017-07-02 22:50:44 +03:00
Andrew Dolgov 46b433933e hotkey_handler: one more tiny tweak 2017-05-05 11:46:16 +03:00
Andrew Dolgov a97e8cddf7 hotkey_handler: cleanup things a bit 2017-05-05 11:41:49 +03:00
Andrew Dolgov 0ae7de6d91 hotkey_handler: return true on prefix handled 2017-05-05 11:33:43 +03:00
Andrew Dolgov 0a79531696 hotkey_handler: stop propagation of handled prefix/action events 2017-05-05 10:01:33 +03:00
Andrew Dolgov e0a957b3f6 use try/catch block in updatefeedlist
remove reporting function from exception dialog
2017-03-05 10:30:49 +03:00
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
2017-03-04 14:34:44 +03:00
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 2017-02-13 23:36:58 +03:00
Andrew Dolgov 3188e863b3 handle_rpc_json: fix netalert button never appearing on JSON parse error 2017-02-09 23:04:34 +03:00
Andrew Dolgov 6358d70d5e reset local counter cache when feed count changes 2017-02-04 11:57:31 +03:00
Andrew Dolgov b1a80693b1 collapse_feedlist: also toggle splitter 2017-01-22 17:46:11 +03:00
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2017-01-21 16:52:27 -05:00
Andrew Dolgov 7fbc10c236 force-enable persist for feedTree 2017-01-21 22:21:46 +03:00
Andrew Dolgov 1c4f5e8390 add dependency on dojo/_base/html 2017-01-21 21:47:44 +03:00
Andrew Dolgov 6293d3717c add toggle_sidebar plugin, remove obsolete toggle button
add PluginHost::HOOK_MAIN_TOOLBAR_BUTTON
2017-01-07 15:29:17 +03:00
Andrew Dolgov d39a2f8005 switch modules to new dojo definition format 2016-08-10 13:40:24 +03:00
Andrew Dolgov 546b419f52 catch plugin JS errors 2016-08-10 12:23:35 +03:00
Andrew Dolgov 0dbc20a8d4 load dijit properly, duh 2016-08-10 11:49:05 +03:00
Andrew Dolgov ee5170424e dojo: main UI: load stuff asynchronously 2016-08-10 10:01:05 +03:00
Andrew Dolgov 64c24ecb59 add hotkey for toggling VFEED_GROUP_BY_FEED preference 2016-07-26 15:55:00 +03:00
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 2016-03-22 23:43:32 +03:00
Andrew Dolgov 7c0d68f207 remove dismiss* functions 2016-03-22 10:28:34 +03:00
Andrew Dolgov 791877c39d fix catching up for grouped feeds 2015-09-03 16:41:04 +03:00
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
2015-08-12 14:09:46 +03:00
Andrew Dolgov 9090b874ab simplify search, remove search_mode as useless
remove dialog to select by tags, simplify browsing by tag query
2015-07-07 15:59:32 +03:00
Andrew Dolgov 86b05f8661 better feed debugger ui for f D 2015-06-12 13:06:36 +03:00
Andrew Dolgov 415a3b50c9 fix some minor typos and stuff 2015-06-07 18:41:18 +03:00
Andrew Dolgov 669fc881f3 add error notification if trying to toggle widescreen in cdm 2015-03-06 15:51:54 +03:00
Andrew Dolgov 119ba03bd4 minor fixes for previous 2015-02-03 14:42:20 +03:00
Andrew Dolgov efcc5d365d add placeholder update checker using git changesets 2015-02-03 14:39:15 +03:00
Andrew Dolgov ed775e4e8d remove obsolete code related to version checking and tarball updater plugin 2015-01-31 15:08:55 +03:00
Andrew Dolgov 98cbae8dfa hotkey actions: toggle_expand, collapse_article: check if element exists
before acting on it (closes #815)
2014-10-26 10:25:19 +04:00
Andrew Dolgov 38bc9dad22 mail plugin: use dijit.form.ComboBox to allow random email input instead of only predefined ones 2014-08-26 18:11:32 +04:00
Andrew Dolgov 89018afa13 assign stored content-insert height/width in switchPanelMode(); reset stored sizes on widescreen switch 2014-08-11 15:39:14 +04:00
Andrew Dolgov df63125dd7 handle_rpc_json: do not crash if net-alert is somehow unavailable 2014-03-14 14:05:32 +04:00
Andrew Dolgov 5c812c2ea4 Revert "add a less intimidating error message when backend times out and/or fails to return valid JSON"
This reverts commit 2ffe7a3b14.
2014-03-11 19:09:33 +04:00
Andrew Dolgov 2ffe7a3b14 add a less intimidating error message when backend times out and/or fails to return valid JSON 2014-03-11 13:59:14 +04:00
Andrew Dolgov d728015d48 minor css tweaks 2014-01-27 19:48:16 +04:00
Andrew Dolgov d44f3da4be default theme updates 2014-01-27 19:03:35 +04:00
Andrew Dolgov 3728377344 Revert "Firefox accessibility.typeaheadfind is triggered for multikey shortcuts."
breaks copy/paste in chrome

This reverts commit d7e4897b8e.
2013-09-27 15:14:20 +04:00
Derek Schrock d7e4897b8e Firefox accessibility.typeaheadfind is triggered for multikey shortcuts.
For multikey shortcuts Firefox accessibility.typeaheadfind is triggered.  Returning false will cause the default event from occuring and prevent the event from bubbling up.
2013-09-20 00:04:33 -04:00
Andrew Dolgov 1966e05457 workaround for resetting panel size cookies (closes #756) 2013-07-25 14:20:42 +04:00
Andrew Herron c65bd1027a Added alt and meta key handling to hotkeys 2013-07-02 22:36:29 +10:00
Andrew Herron d999bc3eb2 prevent accidental ctrl_key global 2013-07-02 22:29:19 +10:00
Jeffrey Tolar 3faad714e2 Add missing hotkey handler 2013-06-21 01:50:08 -05:00
Matt Haley a95e14fb4c Load selected feed after a short timeout
Avoid firing multiple server requests if the user is navigating up/down
the tree list with the keyboard. Instead, wait till the user has stopped
navigating for at least 250ms.
2013-06-13 22:39:26 -07:00
Andrew Dolgov b684a2e665 fix crash on feedlist collapse, do not use _COLLAPSED_FEEDLIST pref 2013-06-13 14:51:31 +04:00
Andrew Dolgov 15a829013c remove single-line excerpts in widescreen 3panel mode because it breaks layout 2013-06-06 10:15:17 +04:00
Andrew Dolgov d34a32a80e remove unnecessary bottom border from headlines-frame 2013-05-11 15:09:18 +04:00
Andrew Dolgov c73b739b25 save and restore UI panel configuration in cookies 2013-05-08 09:18:43 +04:00
Andrew Dolgov ea18cceaca remove splash before freshfeed is loaded 2013-05-02 09:48:38 +04:00
Andrew Dolgov 27372ddac6 fix editArticleTags() call broken on archived feed 2013-04-30 20:07:08 +04:00
supahgreg 8ceea119a8 Add JS PluginHost.HOOK_PARAMS_LOADED and PluginHost.HOOK_RUNTIME_INFO_LOADED to notify when interesting info has been created/updated. 2013-04-27 11:10:21 -05:00
Andrew Dolgov 6bfc97da86 add automatic timezone (based on client tz offset) 2013-04-26 10:31:57 +04:00
Andrew Dolgov 204f9b186f remove cdmUnexpandArticle 2013-04-25 14:04:49 +04:00
Andrew Dolgov 8d388f321b add a simple JS-based hook host 2013-04-24 19:49:37 +04:00
Andrew Dolgov da76e61af8 catchupAllFeeds: do not call obsolete callback 2013-04-17 19:59:38 +04:00
supahgreg 3cc5a3cd43 minor typo fix in hash_get() 2013-04-16 20:08:17 -05:00
Andrew Dolgov 40fe2d7382 remove js-based player, better mp3 support detection for html5 audio 2013-04-16 15:44:38 +04:00
Andrew Dolgov 7e27c91409 remove RCHK 2013-04-07 00:52:39 +04:00
Sunjay Cauligi 8b35d17172 Added functionality for navigation without opening articles and toggling expansion of headlines 2013-04-05 18:57:05 -07:00
Andrew Dolgov 1c9bda915b move several methods from dlg; fix displayed tags not updated after editing 2013-04-01 11:14:27 +04:00
Andrew Dolgov fb54e3b188 remove xml stuff from backend/dlg 2013-04-01 10:47:41 +04:00
Andrew Dolgov a2a3d5a3aa add (disabled) per-feed view_settings handling placeholder 2013-04-01 10:09:22 +04:00
Andrew Dolgov 22af123269 make toggling combined mode work without reload 2013-03-30 19:55:52 +04:00
Andrew Dolgov 60b88b254c add hotkey toggle_cdm_expanded (f c) 2013-03-30 14:28:13 +04:00
Andrew Dolgov b9a06a0e39 retire frankly ridiculous sorting by score/title/date/default
keep defaul and oldest first instead of REVERSE_HEADLINES
2013-03-28 20:44:43 +04:00
Andrew Dolgov 67b9d740ae setActiveFeedId: assign feed/is-cat attributes to headlines-frame 2013-03-28 19:20:12 +04:00
Andrew Dolgov b6c2c963ad if hotkey is handled, return false 2013-03-27 16:34:06 +04:00
Daniel Andersson cee09850f1 Default scroll length closer to expected (i.e. browser default). 2013-03-27 12:17:04 +01:00
Philippe Mongeau d725f0ce99 move global hotkey_actions var to the top 2013-03-26 20:48:44 -04:00
Philippe Mongeau 9fabf9fc4a convert hotkey_action switch to a dict
this will permit plugins to register hockey actions.
2013-03-26 20:40:32 -04:00
Andrew Dolgov 4cdb81737a add a knob to disable reload on js change 2013-03-25 16:07:39 +04:00
Andrew Dolgov 99534a3dde remove page title stuff for the time being 2013-03-23 09:51:30 +04:00
Andrew Dolgov 9972b7cdd7 Revert "update SITE_TITLE customization to work without needing to be pre-defined, make it compatible with unread count now being at start of title"
This reverts commit 8d051fa076.
2013-03-23 09:48:15 +04:00
Andrew Dolgov b68dce191f Revert "fix tabs"
This reverts commit d6cb941459.
2013-03-23 09:48:07 +04:00
Andrew Dolgov d6cb941459 fix tabs 2013-03-22 09:40:02 +04:00
Richard Beales 8d051fa076 update SITE_TITLE customization to work without needing to be pre-defined, make it compatible with unread count now being at start of title 2013-03-21 20:24:26 +00:00
Richard Beales 96f19f11d7 Merge remote-tracking branch 'upstream/master' 2013-03-21 18:57:21 +00:00
Andrew Dolgov 3a693fa76f updateTitle: show counter before title 2013-03-21 22:17:32 +04:00
Andrew Dolgov c186beae48 switchPanelMode: don't try to do anything in cdm (closes #609) 2013-03-21 19:01:51 +04:00
Andrew Dolgov 16314ddafe implement basic auto-reload on some dependent file timestamp changing 2013-03-21 18:01:42 +04:00
Andrew Dolgov 2ccc7b8e07 add a e hotkey for embed_original 2013-03-21 16:57:36 +04:00
Richard Beales 04ed8b423a Merge remote-tracking branch 'upstream/master' 2013-03-20 07:26:49 +00:00
Andrew Dolgov 414191d428 make a separate headline button to collapse current article in
unexpanded cdm mode; modify a q hotkey to collapse article in unexpanded
mode and dismiss article in expanded mode
2013-03-20 10:22:15 +04:00
Richard Beales 05809dfdf7 Merge remote-tracking branch 'upstream/master' 2013-03-19 18:19:07 +00:00
Andrew Dolgov d2db81a5f6 improve hotkey buffer scrolling speed; bind viewport scrolling to shift-arrows 2013-03-19 19:14:28 +04:00
Andrew Dolgov 1d5cf085a3 implement mail plugin using mailto: links; deprecate mail plugin 2013-03-19 18:32:49 +04:00
Andrew Dolgov 4b74648909 remove two unnecessary hideOrShowFeeds calls 2013-03-19 16:46:27 +04:00