Commit Graph

11603 Commits

Author SHA1 Message Date
wn_ 029cb8f442 Revert 7ed4fa4c1d and use @var instead.
PHPStan had trouble recognizing that ['items'] might have elements added.
2023-03-05 16:29:51 +00:00
wn_ 42b287e964 Remove unused 'Prefs::_delete()'.
Related to dabb85c7dd.
2023-03-05 15:30:12 +00:00
wn_ dabb85c7dd Address PHPStan warning about unused private method 'Prefs::_delete()'. 2023-03-05 14:20:19 +00:00
wn_ 7ed4fa4c1d Tweak to appease PHPStan in 'Pref_Feeds::_makefeedtree()'.
PHPStan flagged the 'count()' below this with: Comparison operation '>' between 0 and 0 is always false.
2023-03-05 14:20:19 +00:00
wn_ c4b16ca608 Address PHPStan 'right side always true' in 'PluginHost::lookup_command()'.
Since 'PluginHost::add_command()' is currently the only way to add to this private array, and it always sets an array, this is reasonably safe.
2023-03-05 14:20:19 +00:00
wn_ c48dd6a3c4 Address PHPStan 'right side always true' in FeedItem_RSS. 2023-03-05 14:20:19 +00:00
wn_ d34d01fd72 Bump PHPStan from 1.8.2 to 1.10.3
* https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type
* https://phpstan.org/blog/phpstan-1-10-comes-with-lie-detector
2023-03-05 14:20:19 +00:00
Andrew Dolgov d210ae50ad
API:
- sharedToPublished: add optional sanitize parameter (defaults to true)
   if disabled, allows inserting HTML into shared article content;
 - clean() already invokes strip_tags() so it's pointless to do both;
2023-03-05 08:07:55 +03:00
Andrew Dolgov b7a6c948d0
tags display: instead of limiting to 5 tags, limit by container width % 2023-03-01 21:41:52 +03:00
Andrew Dolgov 04c2fa9f15
Merge branch 'master' of git.tt-rss.org:tt-rss/tt-rss 2023-02-25 19:31:07 +03:00
Andrew Dolgov 4d825fa6a6
require PHP to have support for flock() 2023-02-25 19:30:41 +03:00
fox 33c20d42df Merge pull request 'add override links to utility views' (#102) from levito/tt-rss:add-override-links-to-util-views into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/102
2023-02-24 07:10:28 +03:00
Veit Lehmann aa2b770e30 add override links to utility views
This enables `local-overrides.css` and `local-overrides.js` for all utility views, for example to add polyfills, enable responsive styling or to adjust styles globally.
2023-02-24 00:46:40 +01:00
Andrew Dolgov a2af3a6bb4
API: add getFeedIcon endpoint, bump version 2023-02-23 18:00:18 +03:00
fox fcfcb69a2e Merge pull request 'Handle fetch issues in 'RSSUtils::update_basic_info'.' (#101) from wn/tt-rss:bugfix/handle-failed-basic-info-fetch into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/101
2023-02-19 12:03:49 +03:00
wn_ fd55e492c3 Handle fetch issues in 'RSSUtils::update_basic_info'. 2023-02-17 12:10:51 +00:00
fox 7bbe71b818 Merge pull request 'Fix calculating average color for *.ico' (#100) from yan12125/tt-rss:fix-ico-avg-color into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/100
2023-02-13 20:43:04 +03:00
Chih-Hsuan Yen 40afee5d12 Fix calculating average color for *.ico
Currently colorPalette() always fails for *.ico due to a logic error.
It's a regression from 8f749fe61b.
2023-02-10 18:20:42 +08:00
fox 0cd4abe4eb Merge pull request 'Attempt calculating custom favicon avg color, only try calculating once' (#99) from wn/tt-rss:feature/custom-favicon-detect-color into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/99
2023-02-04 10:56:21 +03:00
wn_ 1646aba944 Minor tweak to favicon avg color debug log message. 2023-02-03 01:30:35 +00:00
wn_ b28d339bf2 Don't set 'favicon_avg_color' on feed obj unless it's valid. 2023-02-03 01:28:24 +00:00
wn_ f484988967 Fix logging favicon-related bools in 'RSSUtils::update_rss_feed()'. 2023-02-03 01:17:53 +00:00
wn_ 380624a484 Persist failure to detect favicon average color.
Previously, an empty string returned by '\Colors\calculate_avg_color()' would be set as the 'favicon_avg_color' value, resulting in always reattempting average color calculation.
2023-02-03 01:02:42 +00:00
wn_ f0f7a5f958 Ensure custom favicon color detection happens. 2023-02-03 00:45:04 +00:00
Andrew Dolgov c30b24d09f
deal with type errors in batch feed editor properly, un-deprecate PDO wrapper functions and document them for posterity 2022-12-30 19:51:34 +03:00
Andrew Dolgov 5c0a5da88c
batch feed editor: silence some more php8.1 undefined field warnings 2022-12-30 19:10:41 +03:00
Andrew Dolgov a16acd65fc
batch feed editor:
- fix some field changes not applying because of DB type errors
 - rework to use bound vars instead of sql query concatenation
deprecate: checkbox_to_sql_bool(), bool_to_sql_bool()
2022-12-30 19:07:15 +03:00
Andrew Dolgov 2be8d58509
CI: use local registry php image 2022-12-30 09:48:34 +03:00
Andrew Dolgov 9c0ead3640
show full commit timestamp with version information in prefs footer 2022-12-30 09:46:01 +03:00
Andrew Dolgov 4c94139113
Merge branch 'weblate-integration' 2022-12-28 12:35:07 +03:00
Eike b64ec219b9 Translated using Weblate (German)
Currently translated at 99.2% (696 of 701 strings)

Translation: Tiny Tiny RSS/messages
Translate-URL: https://weblate.tt-rss.org/projects/tt-rss/messages/de/
2022-12-28 09:33:28 +00:00
fox 22f8a22748 Merge pull request 'Fix getting active feeds with errors.' (#97) from wn/tt-rss:bugfix/feeds-with-errors-default-interval into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/97
2022-12-25 08:42:44 +03:00
wn_ 371af1a39c Fix getting active feeds with errors.
fb4bc2615e incorrectly excluded feeds using the default update interval.  This change ignores the unlikely scenario where someone has the default update interval set to 'disabled'.
2022-12-24 21:22:16 +00:00
fox fb4bc2615e Merge pull request 'Only count updating (i.e. enabled) feeds when determining active feeds with errors.' (#96) from wn/tt-rss:feature/only-warn-for-updating-feeds into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/96
2022-12-22 00:13:04 +03:00
wn_ 46e2635869 Only count updating (i.e. enabled) feeds when determining active feeds with errors.
This excludes feeds that had errors and currently have updating disabled (e.g. disabled due to the site being down for a while, getting compromised, etc.).

Disabled / non-updating feeds' error states are still visible when viewed in the feed tree.
2022-12-21 21:05:59 +00:00
fox 423b26afc5 Merge pull request 'Only touch on send for expirable cache files.' (#95) from wn/tt-rss:bugfix/local-cache-feed-icons-ts into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/95
2022-12-20 08:22:21 +03:00
wn_ 8b129626cd Only touch on send for expirable cache files.
With d373b7b452 feed icon modification times get used for cache-busting, but 'Cache_Local' updates that
value on each send.  This change makes it so the modification time only gets updated on files in expirable caches, keeping the value
consistent between sends for files in non-expiring caches.

Also, marking 'Cache_Local::send_local_file()' private since it's unique to that adapter.
2022-12-20 02:16:47 +00:00
Andrew Dolgov c6d21b3196
make phpstan happy 2022-12-19 21:42:34 +03:00
Andrew Dolgov d373b7b452
* bring back cache-busting for feed icons based on timestamp
* DiskCache: use singleton pattern to create less cache object instances
 * DiskCache: implement ETag
2022-12-19 21:36:50 +03:00
Andrew Dolgov 20d6aaa9ab
limit tree expando white color to prefs 2022-12-19 21:19:28 +03:00
Andrew Dolgov 8ea537123d
move af_readability out of master tree 2022-12-13 20:08:43 +03:00
fox 313f12ae93 Merge pull request 'Bump af_readability 'html5-php' dependency to latest.' (#94) from wn/tt-rss:feature/bump-af_readability-masterminds-html5 into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/94
2022-12-13 19:45:50 +03:00
wn_ 457553eeac Add af_readability 'html5-php' Jenkinsfile.
Got missed when updating that dependency.
2022-12-12 22:38:18 +00:00
wn_ 0317828847 Bump af_readability 'html5-php' dependency to latest.
This is to add a couple more 'ReturnTypeWillChange' ( https://dev.tt-rss.org/main/html5-php/pulls/1 ).

Composer 2.4.4 (latest release) also updated some of its files.
2022-12-12 22:31:14 +00:00
Andrew Dolgov 72e64bdb78
phpstan: exclude tests in lib/ 2022-12-11 22:06:49 +03:00
Andrew Dolgov fa9c614ff1
Merge branch 'master' of git.tt-rss.org:tt-rss/tt-rss 2022-12-02 07:35:11 +03:00
Andrew Dolgov 824addbc9d
fix cleanup_feed_icons unlinking nonexistant files, limit it to actual feed icons 2022-12-02 07:34:51 +03:00
fox 292ca86665 Merge pull request 'Consistently get the self URL.' (#92) from wn/tt-rss:bugfix/config-self-url-consistency into master
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/92
2022-11-28 20:43:10 +03:00
wn_ a355221e7f Consistently get the self URL.
This ensures all uses of the self URL get the same normalized/sanitized value.
2022-11-28 17:40:42 +00:00
Andrew Dolgov 94c49399cc
get_self_url: strip all trailing slashes 2022-11-28 19:24:12 +03:00