c779e2ba0d
batch feed editor: don't try to save feed_url or title, those aren't in the dialog
2023-10-04 18:32:35 +03:00
40df94c169
fix feed_language being unnecessarily quoted in batch feed editor
2023-10-04 18:27:31 +03:00
dc25a9cf68
disable app passwords in the UI if auth_internal is not loaded
2023-06-14 20:19:18 +03:00
e18295a364
more tracing
2023-04-09 22:15:16 +03:00
c1b3c99667
some tracer class fixes / unhardcode jaeger IP
2023-04-09 21:20:35 +03:00
8f3646a9c9
exp: jaeger tracing
2023-04-09 20:50:33 +03:00
cddbf5bf5a
Merge pull request 'Replace special feed and category numbers with constants.' ( #104 ) from wn/tt-rss:feature/special-feed-and-cat-consts into master
...
Reviewed-on: https://dev.tt-rss.org/tt-rss/tt-rss/pulls/104
2023-03-07 20:13:10 +03:00
fe08299ec4
Replace special feed and category numbers with constants.
2023-03-05 19:16:48 +00:00
029cb8f442
Revert 7ed4fa4c1d and use @var instead.
...
PHPStan had trouble recognizing that ['items'] might have elements added.
2023-03-05 16:29:51 +00:00
7ed4fa4c1d
Tweak to appease PHPStan in 'Pref_Feeds::_makefeedtree()'.
...
PHPStan flagged the 'count()' below this with: Comparison operation '>' between 0 and 0 is always false.
2023-03-05 14:20:19 +00:00
c30b24d09f
deal with type errors in batch feed editor properly, un-deprecate PDO wrapper functions and document them for posterity
2022-12-30 19:51:34 +03:00
5c0a5da88c
batch feed editor: silence some more php8.1 undefined field warnings
2022-12-30 19:10:41 +03:00
a16acd65fc
batch feed editor:
...
- fix some field changes not applying because of DB type errors
- rework to use bound vars instead of sql query concatenation
deprecate: checkbox_to_sql_bool(), bool_to_sql_bool()
2022-12-30 19:07:15 +03:00
371af1a39c
Fix getting active feeds with errors.
...
fb4bc2615e
2022-12-24 21:22:16 +00:00
46e2635869
Only count updating (i.e. enabled) feeds when determining active feeds with errors.
...
This excludes feeds that had errors and currently have updating disabled (e.g. disabled due to the site being down for a while, getting compromised, etc.).
Disabled / non-updating feeds' error states are still visible when viewed in the feed tree.
2022-12-21 21:05:59 +00:00
d373b7b452
* bring back cache-busting for feed icons based on timestamp
...
* DiskCache: use singleton pattern to create less cache object instances
* DiskCache: implement ETag
2022-12-19 21:36:50 +03:00
a355221e7f
Consistently get the self URL.
...
This ensures all uses of the self URL get the same normalized/sanitized value.
2022-11-28 17:40:42 +00:00
a30b9bb649
rework favicon storage to use DiskCache
2022-11-24 23:31:33 +03:00
d376cd6142
Address upcoming string interpolation deprecation.
...
https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation
2022-11-12 16:20:59 +00:00
f56a049641
fix some PHP8 warnings generated while dragging feed tree items around
2022-10-15 13:44:02 +03:00
c301053965
Use the null coalescing assignment operator in various places.
2022-08-12 18:21:38 +00:00
3487c922b3
Replace use of 'array_merge' with the spread operator and 'array_push' in various places.
...
This isn't supported for arrays with string keys until PHP 8.1.
https://wiki.php.net/rfc/spread_operator_for_array
2022-08-12 17:58:38 +00:00
a63c949a55
Use arrow functions in some places.
2022-08-12 14:41:21 +00:00
93fd85df6f
Switch to direct type declarations of class properties.
2022-08-12 14:13:26 +00:00
26c67dba77
update phpstan to 1.8.2
2022-07-31 13:55:09 +03:00
f3aceb4648
Fix an error when disabling all user plugins
...
If I enabled some user plugins via Preferences -> Plugins and then
disabled all of them, an error occurred:
Jul 16 22:34:20 php[100]: PHP Fatal error: Uncaught TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in /usr/share/webapps/tt-rss/classes/pref/prefs.php:1027
Jul 16 22:34:20 php[100]: Stack trace:
Jul 16 22:34:20 php[100]: #0 /usr/share/webapps/tt-rss/classes/pref/prefs.php(1027): array_filter()
Jul 16 22:34:20 php[100]: #1 /usr/share/webapps/tt-rss/backend.php(136): Pref_Prefs->setplugins()
Jul 16 22:34:20 php[100]: #2 {main}
Jul 16 22:34:20 php[100]: thrown in /usr/share/webapps/tt-rss/classes/pref/prefs.php on line 1027
Apparently the issue was elevated from a warning to an error in PHP 8.0
[1].
[1] https://php.watch/versions/8.0/internal-function-exceptions
2022-07-16 22:50:16 +08:00
8ef816d8f8
feeds-tree: move external onClick dojo/method to PrefFeedTree class
2022-06-06 09:31:37 +03:00
6436dd16f9
filter-tree: move external dojo/method to PrefFilterTree class
2022-06-06 09:29:16 +03:00
dd983e5de1
prefs: move external filter tree onload method (which checks for inactive feeds, etc.) to FilterTree class
2022-06-05 11:47:21 +03:00
fc84712135
pref-filters: add a button to hide or show rules in the filter list
2022-06-05 11:41:28 +03:00
9457bb090a
fix PHP8 undefined array key warning when resetting prefs to defaults
2022-06-05 11:14:42 +03:00
de1e218a83
various fixes vor php 8.1 compatibility
...
Cherry-picked from https://git-gitea.tt-rss.org/fox/tt-rss/pulls/56 ,
while excluding changes in vendor/ (causes compatiblity issues with
PHP<8 [1]) and strftime-related ones (already re-applied in
https://git-gitea.tt-rss.org/fox/tt-rss/pulls/66 ).
[1] https://community.tt-rss.org/t/support-for-php-8-1/5089/9
2022-03-09 00:46:15 +08:00
f7e2f62022
fix Feeds::_get_counters() used improperly as a replacement for
...
getFeedUnread()
2022-02-20 12:48:38 +03:00
77f39d65b5
* Feeds::_get_counters - fix retrieving unread for tags
...
* mark several symbols as @deprecated properly
* replace uses of (deprecated) getFeedUnread() with Feeds::_get_counters()
2022-02-20 11:04:40 +03:00
40b2356be2
filters:
...
* add filter action to ignore feed-provided tags
* simplify handling of various filter-provided tags
* bump schema to 146
2021-12-20 07:56:16 +03:00
987870074b
Fixes declaration of Pref_Prefs::csrf_ignore to match IHandler::csrf_ignore
2021-12-02 20:57:19 +03:00
a201e10ee0
Revert "various fixes vor php 8.1 compatibility"
...
This reverts commit 14027ae04e
2021-12-01 13:37:35 +03:00
14027ae04e
various fixes vor php 8.1 compatibility
2021-11-30 21:50:09 +01:00
d532eb773b
Switch from null to false as the default for missing bool params.
2021-11-18 18:25:04 +00:00
2422aae577
Consistently handle param string to bool conversions in handlers.
2021-11-18 18:09:47 +00:00
6d438c5a77
Address PHPStan warning in 'classes/pref/users.php'.
2021-11-14 20:27:17 +00:00
5632d75a45
Address PHPStan warning in 'classes/pref/system.php'.
2021-11-14 20:26:21 +00:00
abab2a94e8
Address PHPStan warning in 'classes/pref/prefs.php'.
...
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
b8f0627a0e
Address PHPStan warning in 'classes/pref/labels.php'.
2021-11-14 20:13:09 +00:00
9326ed605f
Address PHPStan warning in 'classes/pref/filters.php'.
2021-11-14 17:59:57 +00:00
af2f4460ce
* deal with some phpstan warnings in base plugin class
...
* arguably better hack for incompatible plugins causing E_COMPILE_ERROR
2021-11-14 16:49:10 +03:00
5a50c333b2
Address PHPStan warnings in 'classes/pref/filters.php'.
2021-11-14 00:59:19 +00:00
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
2021-11-13 16:00:59 +00:00
a18473e4c0
Address PHPStan warnings in 'classes/pref/feeds.php'.
2021-11-13 15:56:31 +00:00
5606e38bff
Update signature of handler 'csrf_ignore' to include types.
2021-11-12 02:01:31 +00:00
Andrew Dolgov
fox
wn_
Andrew Dolgov
Chih-Hsuan Yen
David Edler
jbaldus