Commit Graph

11346 Commits

Author SHA1 Message Date
Andrew Dolgov b77f6c9a6b API: force methods to return bool to make wrap() mistakes easier to track 2021-11-18 10:46:06 +03:00
Andrew Dolgov 9e469b1642 api: a few more returns in login 2021-11-18 09:04:08 +03:00
Andrew Dolgov 10a1d4d879 api: don't return errors on login success 2021-11-18 09:01:44 +03:00
Andrew Dolgov 63ec5a8965 Merge branch 'wip-phpstan-level6' 2021-11-18 07:32:28 +03:00
wn_ 2d830c6281 Minor correction to RSSUtils::cache_enclosures() $enclosures param type.
All FeedEnclosure values are currently strings, even though the numeric things get converted to int before getting inserted in 'ttrss_enclosures'.
2021-11-17 20:45:41 +00:00
wn_ fb1e85baaf Switch FeedParser back to described behavior for setting 'error'.
Also some formatting.
2021-11-17 19:29:54 +00:00
Andrew Dolgov aeb4137cbd document a few more plugin hooks 2021-11-17 18:30:32 +03:00
Andrew Dolgov 3e273ea527 add descriptions for some plugin hooks 2021-11-17 15:56:58 +03:00
Andrew Dolgov 34f294414f schema: remove default subscription of admin to the forums rss feed 2021-11-17 11:35:40 +03:00
Andrew Dolgov bd66eff7cc better check for docker 2021-11-17 10:52:37 +03:00
Andrew Dolgov 938f7db482 correctly show non-docker git installs as unsupported 2021-11-17 10:36:04 +03:00
Andrew Dolgov 5980b3d2cb pluginhost: set stricter @params 2021-11-16 18:35:13 +03:00
Andrew Dolgov 10d1a8c05a adjust phpdoc tags for hook definitions/constants (make them reference each other) 2021-11-16 16:31:40 +03:00
Andrew Dolgov ad30d39e2a not dead: Article.assigntolabel etc are exported methods called by frontend (Headlines.js) 2021-11-16 15:45:35 +03:00
Andrew Dolgov 4166628c36 Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6 2021-11-16 09:19:19 +03:00
Andrew Dolgov 6a8030fd76 mailer: don't crash if php mail() fails with no reported errors 2021-11-16 09:19:12 +03:00
wn_ d78ba7b3a9 Minor fix in 'classes/articles.php'.
It looks like these functions are dead code, though.  Adding comments for future review.
2021-11-16 02:14:31 +00:00
Andrew Dolgov b2952843f5 * DiskCache: add download() helper
* Af_Comics_Gocomics_FarSide: cache linked images because it seems to
be required anyway
2021-11-15 23:22:21 +03:00
Andrew Dolgov 3a3fde1a2e when uninstall plugins, refresh plugins index instead of reloading entire prefs pane 2021-11-15 20:18:50 +03:00
Andrew Dolgov 8cd69fe15c when uninstall plugins, refresh plugins index instead of reloading entire prefs pane 2021-11-15 20:18:37 +03:00
Andrew Dolgov ef1e2a8b2f update dojo/dijit to 1.16.4 2021-11-15 18:48:47 +03:00
Andrew Dolgov 1db1be7a81 update phpstan to 1.1.2 (composer files) 2021-11-15 18:44:24 +03:00
Andrew Dolgov 4c37fa4b41 update phpstan to 1.1.2; update php-qrcode to 3.4.1 2021-11-15 18:33:35 +03:00
wn_ 109b702ed0 Minor fix to DOMNodeList#item() potential type (null vs false) 2021-11-15 12:24:38 +00:00
Andrew Dolgov 85b974af32 auth_internal: limit password throttling to failed login attempts not using OTP 2021-11-15 13:16:49 +03:00
Andrew Dolgov 26f47c0694 remove themes/Makefile (obsolete, replaced with gulp) 2021-11-15 08:27:49 +03:00
Andrew Dolgov aa924d9ee7 deal with several DOMElement-related errors 2021-11-15 08:26:02 +03:00
Andrew Dolgov a92070da06 unignore several phpstan errors 2021-11-15 08:20:56 +03:00
Andrew Dolgov 2493c9cddd set better matching type hint on virtual feed object 2021-11-15 08:19:44 +03:00
Andrew Dolgov 676c5787e7 require virtual feed plugins to implement IVirtualFeed 2021-11-15 07:11:29 +03:00
Andrew Dolgov 8dfefe7968 add IVirtualFeed interface for plugins implementing virtual feeds 2021-11-15 07:08:52 +03:00
Andrew Dolgov 3bd13b91c8 add IVirtualFeed interface for plugins implementing virtual feeds 2021-11-15 07:08:41 +03:00
Andrew Dolgov 07ea364189 Merge branch 'wip-phpstan-level6' of git.tt-rss.org:fox/tt-rss into wip-phpstan-level6 2021-11-15 06:54:04 +03:00
Andrew Dolgov edc7998851 revise phpdoc annotations for hook_search() 2021-11-15 06:53:55 +03:00
wn_ fb208bb136 Fix a PHPStan warning in 'UrlHelper::rewrite_relative()'. 2021-11-15 03:28:17 +00:00
wn_ 41b4eef504 Address PHPStan warnings for FeedEnclosure. 2021-11-15 02:46:19 +00:00
wn_ 78acf18b70 Address PHPStan warnings in FeedItem classes. 2021-11-15 02:40:45 +00:00
wn_ 8943604aad Change the param type for UserHelper::hash_password() $algo to appease PHPStan.
PHPStan was complaining in 'plugins/auth_internal/init.php' due to UserHelper::hash_password() being passed a string, rather than a UserHelper::HASH_ALGO_* constant.  Just switching the param to string for now.
2021-11-14 22:44:48 +00:00
wn_ 324d926eb4 Also fix the param signature for Plugin#hook_hotkey_info() 2021-11-14 22:16:16 +00:00
wn_ 12f9df1066 Fix the return signature for Plugin#hook_hotkey_info() 2021-11-14 22:11:27 +00:00
wn_ 8f749fe61b Address PHPStan warnings in 'include/colors.php'.
Also some formatting for readability.
2021-11-14 21:06:06 +00:00
wn_ 6d438c5a77 Address PHPStan warning in 'classes/pref/users.php'. 2021-11-14 20:27:17 +00:00
wn_ 5632d75a45 Address PHPStan warning in 'classes/pref/system.php'. 2021-11-14 20:26:21 +00:00
wn_ abab2a94e8 Address PHPStan warning in 'classes/pref/prefs.php'.
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
wn_ b8f0627a0e Address PHPStan warning in 'classes/pref/labels.php'. 2021-11-14 20:13:09 +00:00
Andrew Dolgov 56cf425e45 revise prototype for hook_enclosure_imported 2021-11-14 23:03:25 +03:00
Andrew Dolgov c3fbf56984 deal with most of warnings in plugins/af_readability 2021-11-14 21:25:56 +03:00
Andrew Dolgov 242cf916ef deal with phpstan warnings in plugins/note, nsfw, and share 2021-11-14 21:20:59 +03:00
Andrew Dolgov 5f808051b2 deal with phpstan warnings in auto_assign_labels and bookmarklets 2021-11-14 21:14:21 +03:00
Andrew Dolgov f537502fce deal with (most of) phpstan warnings in auth_internal and auth_remote 2021-11-14 21:09:53 +03:00