Commit Graph

900 Commits

Author SHA1 Message Date
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
2019-04-13 22:34:57 +02:00
ltGuillaume 4c72d3b4fc Add keyboard shortcut 'g r': Go to Recently read 2019-04-12 07:28:45 +00:00
Andrew Dolgov cc2ac3a86c FeedTree: add feed debugger to per-feed context menu 2019-04-08 15:51:05 +03:00
Andrew Dolgov b1bb7c6001 Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-14 09:08:52 +03:00
Andrew Dolgov 019f4578bc fix feed icon upload not working, rework form to use FormData/ajax 2019-03-14 09:08:44 +03:00
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
2019-03-11 12:01:27 +01:00
Andrew Dolgov a34509c8ae Merge branch 'master' of git.fakecake.org:tt-rss 2019-03-08 10:12:06 +03:00
Andrew Dolgov 19f162dbe3 css: insensitive -> text-muted 2019-03-08 10:11:57 +03:00
Andrew Dolgov 900cdbbb31 Headlines.click: open original article (and mark as read) on alt click on title 2019-03-07 15:40:02 +03:00
Andrew Dolgov ae9ef7fe84 Headlines.click: fix another small issue with expanded mode (2) 2019-03-07 12:16:50 +03:00
Andrew Dolgov 0b8f3909fe Headlines.click: fix another small issue with expanded mode 2019-03-07 12:16:09 +03:00
Andrew Dolgov 84cf95fe8f Headlines.click: open original article when it makes sense to do so 2019-03-07 11:52:10 +03:00
Andrew Dolgov cf6f867feb getRange: handle start == stop 2019-03-07 10:38:50 +03:00
Andrew Dolgov d876cca22a tweak Headlines.click: ctrl-click toggles selection, shift-click selects range 2019-03-07 10:35:48 +03:00
Andrew Dolgov ef6d2b8a4e update notifications to make them more visible
cleanup some minor stuff in pref-users
2019-03-05 20:09:06 +03:00
Andrew Dolgov 70c53257d9 on_catchup_show_next: remove auto-trigger on headlines scroll 2019-02-21 14:22:33 +03:00
Andrew Dolgov 4db13b8a17 simplify preference layout, remove some unnecessary css classes 2019-02-21 12:35:40 +03:00
Andrew Dolgov 6e14e575b3 use separate id for default password warning dialog 2019-02-20 08:39:44 +03:00
Andrew Dolgov 848bb6579c floatingTitle: show collapse button if in expandable mode 2019-02-14 16:20:10 +03:00
Andrew Dolgov 1124c3f00a label display: fix unneeded nested container in headlines, increase overall minimalism, fix label element typo (div1) 2019-02-01 12:42:27 +03:00
Andrew Dolgov dbab03bd4c Feeds.catchupAllFeeds() should be Feeds.catchupAll() 2019-01-31 12:16:56 +03:00
Andrew Dolgov c7c9c5fb0a feedTree: amend previous to check that nodes are actually there (2) 2019-01-28 18:49:58 +03:00
Andrew Dolgov 42e0c7a420 feedTree: amend previous to check that nodes are actually there 2019-01-28 18:48:56 +03:00
Andrew Dolgov 3827e5b944 selectFeed: scroll feed tree to selected row 2019-01-27 23:31:00 +03:00
Andrew Dolgov 8b26b8629f headlines-frame: set is-vfeed attribute if result is virtual feed 2019-01-16 21:33:59 +03:00
Andrew Dolgov c607b7836e onLoaded: clear this.headlines on first page load 2019-01-03 12:36:57 +03:00
Andrew Dolgov f44c6d01b0 fix previous always disabling infscroll 2019-01-03 01:00:09 +03:00
Andrew Dolgov c66db9bde8 headlines onloaded: when appending, check for duplicate IDs 2019-01-02 16:29:08 +03:00
Andrew Dolgov 51b069a1ee display filter tree rules as a list 2018-12-19 12:08:06 +03:00
Andrew Dolgov 8393096947 selectionTogglePublished: fix typo which caused it to mark articles instead 2018-12-18 11:49:26 +03:00
Andrew Dolgov dee210e546 headlines onLoaded: make sure a few more things respect append instead of offset == 0 2018-12-18 07:51:00 +03:00
Andrew Dolgov 8effabd075 append headline buffer if requested, don't just use offset 2018-12-16 21:15:08 +03:00
Andrew Dolgov 957c44d177 rework git update checking to be initiated by frontend, outside of runtime info output 2018-12-16 19:05:37 +03:00
Andrew Dolgov c3b8b6a2a1 also prevent multiple requests 2018-12-16 12:43:53 +03:00
Andrew Dolgov 54ce930b8d delay counters request on promise completion a bit 2018-12-16 12:41:27 +03:00
Andrew Dolgov 8c49689fda filter test results: remove table bloat 2018-12-14 17:44:53 +03:00
Jordan Galby 47b4a262cf fix missing curly brace
Fix the error:
```
SyntaxError: missing } after property list
```
2018-12-13 15:10:32 +01:00
Andrew Dolgov d3885c5883 App.toggleNightMode: add some fadein/fadeout 2018-12-13 10:20:05 +03:00
Andrew Dolgov d53cdaf815 requestCounters: remove cooldown 2018-12-12 20:06:44 +03:00
Andrew Dolgov 4e41db7ed3 Article.unpack: add placeholder   if data-content is empty 2018-12-12 08:56:02 +03:00
Andrew Dolgov eda4ac2a2b add fallback colors for headline feed titles based on feed name if favicon color is not available 2018-12-12 07:57:37 +03:00
Andrew Dolgov be49b77b14 Revert "use codeflask for user css editor"
This reverts commit daa43e0572.
2018-12-11 20:48:17 +03:00
Andrew Dolgov 721f9ad866 requestIdleCallback: remove hard dependency for now 2018-12-11 17:58:10 +03:00
Andrew Dolgov daa43e0572 use codeflask for user css editor 2018-12-11 14:25:41 +03:00
Andrew Dolgov 7a98105960 remove old fatalError(), move everything to App.Error
update exception dialog css
2018-12-11 13:18:38 +03:00
Andrew Dolgov 071ca5aa96 Error.report: use JS template strings 2018-12-11 12:45:05 +03:00
Andrew Dolgov 2cbc2f5261 bring back frontend sanity check w/ App.checkBrowserFeatures() 2018-12-11 12:30:48 +03:00
Andrew Dolgov f3c04fc5d8 sync modified scores via mutation observer 2018-12-11 10:30:32 +03:00
Andrew Dolgov 25ca144bb7 score: get correct classes for rows/score icons on the client 2018-12-11 10:00:54 +03:00
Andrew Dolgov fd6f3e7f07 syncModified: request counters once after all xhr promises resolve 2018-12-11 08:48:24 +03:00
Andrew Dolgov 7cfd04ffb4 xhr helpers: wrap in promises 2018-12-11 08:42:38 +03:00
Andrew Dolgov 36f3299ddf use window.requestIdleCallback to sync observed modifications 2018-12-11 08:25:22 +03:00
Andrew Dolgov ad5a43bf66 sync article selected status via mutation observer
remove all rchk-related hacks
2018-12-10 21:19:33 +03:00
Andrew Dolgov c97c755195 remove _active_article_id; use selector instead 2018-12-10 20:56:09 +03:00
Andrew Dolgov d9bf0f17c6 sync unread state to server via mutation observer 2018-12-10 20:50:44 +03:00
Andrew Dolgov e5efde26ac sync marked and published states to server via mutation observer 2018-12-10 20:18:45 +03:00
Andrew Dolgov 6616c7cf67 keep track of selected prompt and floating title status using headline row mutation observer 2018-12-10 19:51:20 +03:00
Andrew Dolgov f96cdb7d5d renderAgain flag fixes 2018-12-10 16:10:19 +03:00
Andrew Dolgov 109910424c renderAgain: restore marked/published flags 2018-12-10 15:19:56 +03:00
fox cc267217e1 Merge branch 'tree_tooltip_error' of ggrandou/tt-rss into master 2018-12-10 12:07:54 +00:00
Andrew Dolgov 54f02a3b31 add Headlines.renderAgain() to switch between combined/expanded modes faster 2018-12-10 15:06:47 +03:00
Gilles Grandou df05794032 show errors in feedtree's tooltips 2018-12-10 11:38:59 +01:00
Andrew Dolgov 7e5c999146 show alert if recent_log_events > 0 2018-12-10 10:53:11 +03:00
Andrew Dolgov fca78f7417 add qmcToggleNightMode to actions dropdown 2018-12-09 21:20:59 +03:00
Andrew Dolgov 1c8593c1fa add hotkey (a N) to toggle night.css 2018-12-09 21:17:50 +03:00
Andrew Dolgov 95e1038e6d consistency: show author in multipanel headlines row 2018-12-09 16:12:04 +03:00
Andrew Dolgov a1c595687e fix previous to not crash in prefs 2018-12-09 16:09:51 +03:00
Andrew Dolgov 5e007e0090 headlines-spacer: only set 100% height if auto catchup is enabled 2018-12-09 16:02:20 +03:00
Andrew Dolgov 42780ddeb3 in grouped mode, don't display feed titles twice 2018-12-09 13:57:54 +03:00
Andrew Dolgov 302cffb1a7 catchupFeedInGroup: better icon 2018-12-09 13:53:26 +03:00
Andrew Dolgov dc84e10ba1 catchupFeedInGroup: overhaul
1. less hacky way to catchup actually unread headlines
2. don't fade rows away because it's inconsistent with different mark-as-read functions
3. fix stuck progress alert
2018-12-09 13:52:21 +03:00
Andrew Dolgov fa538a6c86 implement year-week sorting window if headlines buffer is grouped by feed titles 2018-12-09 13:35:37 +03:00
fox e338014d99 Merge branch 'pluginhost_fix' of ggrandou/tt-rss into master 2018-12-09 01:34:48 +00:00
Andrew Dolgov c8253f0e64 Article.openInNewWindow: do not crash if window is null 2018-12-09 04:32:41 +03:00
Gilles Grandou 392ad0bd83 fix PluginHost run method.
callbacks have no return value and anyway we should not prevent
to run subsequent plugins because one has failed.
2018-12-08 19:14:40 +01:00
Andrew Dolgov a0d332326c add PluginHost.HOOK_HEADLINE_RENDERED 2018-12-08 20:08:57 +03:00
Andrew Dolgov a400a8ffc1 add PluginHost.HOOK_INIT_COMPLETE (and make no_title_counters use it) 2018-12-08 20:06:07 +03:00
Andrew Dolgov f3737c0b24 update_rss_feed: add log message if article is filtered out
combine filters: fix crash on missing global function
2018-12-08 17:01:30 +03:00
Andrew Dolgov cf1ef002bc show disabled feeds in pref feed tree, use opacity instead of fixed gray color 2018-12-08 16:10:37 +03:00
Andrew Dolgov 4887db9820 update css for disabled filters; remove strikethrough 2018-12-08 15:49:52 +03:00
Michael Kuhn b43b7be9d5 Fix two more typos 2018-12-08 11:02:39 +01:00
Andrew Dolgov 41bf063e46 switchPanelMode: allow modifying layout in combined mode so that widescreen status won't be initially lost if starting in cdm 2018-12-08 09:46:48 +03:00
Andrew Dolgov bd66a9ef28 render article on the client using headlines data 2018-12-08 09:32:14 +03:00
Andrew Dolgov d1efcb7fc0 cdm: put originally_from into footer 2018-12-07 23:24:59 +03:00
Andrew Dolgov c31ae870c9 popupOpenArticle: don't cause an exception if popups are blocked 2018-12-07 22:07:13 +03:00
Andrew Dolgov 6e30af755c viewfeed: bring back comments prompt 2018-12-07 22:05:39 +03:00
Andrew Dolgov 76885fc5ad viewfeed: general code cleanup 2018-12-07 21:22:51 +03:00
Andrew Dolgov 8f75b06835 implement feed grouping display, remove unneeded server vgrlf passing 2018-12-07 21:11:50 +03:00
Andrew Dolgov 9d2caaefe7 viewfeed: show originally from... 2018-12-07 20:42:51 +03:00
Andrew Dolgov 20d460296d fix unread hl styling 2018-12-07 20:36:10 +03:00
Andrew Dolgov e075e6141b json-viewfeed updates 2018-12-07 18:24:56 +03:00
Andrew Dolgov 249c93a228 initial for js templates 2018-12-07 16:00:11 +03:00
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
2018-12-07 14:03:33 +03:00
Andrew Dolgov 7b0f4f1e46 updateFloatingTitle: marginRight correction no longer needed 2018-12-07 10:12:01 +03:00
Andrew Dolgov 7a276f9898 updateFloatingTitle: add safety offset to hide/show because mozilla can't into math 2018-12-07 10:09:37 +03:00
Andrew Dolgov c4b01dd547 updateFloatingTitle: sync row marked/published status 2018-12-07 09:09:09 +03:00
Andrew Dolgov 75666ac7ab Headlines.click: clicking in body of currently active cdm article should mark
it as read, otherwise it's not possible without a kb shortcut or auto catchup
2018-12-06 20:41:15 +03:00
Andrew Dolgov 7805b291b6 update floating title in toggleUnread functions post-xhr 2018-12-06 20:38:55 +03:00
Andrew Dolgov db3c7d2050 remove floating title appear animation for now 2018-12-06 20:34:46 +03:00
Andrew Dolgov 3e4326e34d add ttrss_filters2.last_triggered (bump schema version) 2018-12-06 19:37:20 +03:00
Andrew Dolgov 0b8cbc9156 remove some bitmaps and rework stuff using it to use iconfont instead 2018-12-06 15:22:52 +03:00
Andrew Dolgov d2d2cb7e7d rework scoring display, JS processing and icons 2018-12-06 14:23:45 +03:00
Andrew Dolgov b09a58a570 call Headlines.scrollhandler() on window resize 2018-12-06 13:25:04 +03:00
Andrew Dolgov d99d04a2ae notify: use iconfont, update colors and increase height a bit 2018-12-06 12:52:44 +03:00
Andrew Dolgov 0ea0b606be rework net-alert to use iconfont, move it to toolbar start 2018-12-06 12:30:11 +03:00
Andrew Dolgov f89ecda9b8 Feeds.updateRandom: fix calling wrong RPC method 2018-12-06 12:19:05 +03:00
Andrew Dolgov 0e25f5d512 add Lists.select() and make filter dialogs use it 2018-12-06 09:52:12 +03:00
Andrew Dolgov fbaa5ea857 label editor: fix changing tree color of edited item 2018-12-06 08:35:02 +03:00
Andrew Dolgov 0a41c1a6e1 update label rendering (and editor) 2018-12-06 08:26:52 +03:00
Andrew Dolgov f33cd597be selectionToggleUnread: remove loading... prompt (other similar methods don't have it) 2018-12-06 06:52:08 +03:00
Andrew Dolgov cad6d1d7fd various icon updates; use new icons in feed tree 2018-12-05 20:26:27 +03:00
Andrew Dolgov e7adc7e471 Merge branch 'master' into material-icons 2018-12-05 17:53:26 +03:00
Andrew Dolgov 7edcf6c45f ctrlclick in combined mode shouldn't open two windows 2018-12-05 17:52:55 +03:00
Andrew Dolgov f3e6e12d46 various minor updates re: icons 2018-12-05 16:48:29 +03:00
Andrew Dolgov 2dac797704 floatingTitle-related fixes 2018-12-05 16:26:53 +03:00
Andrew Dolgov b65d8384c2 update headlines to use vector icons 2018-12-05 13:58:18 +03:00
Andrew Dolgov e42d25a361 revert to previous headline ctrl-click behavior (open in new window, mark read) 2018-12-05 10:37:05 +03:00
Andrew Dolgov 05200a3840 rename main toolbar elements to be more consistent 2018-12-05 10:03:58 +03:00
Andrew Dolgov 85adef06f4 onkeydown handlers: fix default keyboard events not being blocked if necessary 2018-12-05 09:11:12 +03:00
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
2018-12-05 07:41:55 +03:00
Andrew Dolgov 2ab097b2e5 initial work for flat modern theme 2018-12-04 22:24:31 +03:00
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 2018-12-04 19:03:42 +03:00
Andrew Dolgov ed1bd992d7 PrefFilterTree: fix obscure crash because of getLabel() not casting data to string 2018-12-04 16:07:24 +03:00
Andrew Dolgov f6e287df11 remove 4px margin of cdm.expanded 2018-12-04 13:40:47 +03:00
Andrew Dolgov 7e7a15136b Headlines.onRowChecked: fix undefined row 2018-12-04 10:32:57 +03:00
Andrew Dolgov 4a0b644f61 Headlines.onRowChecked: fix possible desync in checkbox and row selected state 2018-12-04 10:19:24 +03:00
Andrew Dolgov 6d3092c742 Headlines.openInNewWindow: don't set article active, just window.open() it and set read 2018-12-04 05:57:56 +03:00
Andrew Dolgov d3486b15f9 fix collapse_sidebar hotkey action 2018-12-03 20:49:37 +03:00
Andrew Dolgov d8d3662729 CommonDialogs: refresh proper elements after feed operations in preferences 2018-12-03 20:16:07 +03:00
Andrew Dolgov e76d1fb995 plugins: mail, mailto: remove code from global context 2018-12-03 14:21:50 +03:00
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 2018-12-03 13:38:13 +03:00
Andrew Dolgov a049b5bd88 shorten declaration of PrefHelpers.OPML 2018-12-03 12:57:19 +03:00
Andrew Dolgov 8f1881e12c remove cookie set check 2018-12-03 12:55:07 +03:00
Andrew Dolgov 4d4034091a prefs: Prefs global -> Helpers 2018-12-03 12:46:00 +03:00
Andrew Dolgov b3bc638a9f refactor OPML export/import code to be less horrible 2018-12-03 12:26:49 +03:00
Andrew Dolgov 78cc470193 remove some plugin JS code out of global context 2018-12-03 10:51:14 +03:00
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
2018-12-03 09:33:44 +03:00
wn_ b83ed6c7c4 Fix reference to `PluginHost`.
A `const` doesn't create a property on `window`.
2018-12-02 15:06:28 -06:00
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 2018-12-02 22:08:18 +03:00
Andrew Dolgov ac8361e6f6 add AppBase as a shared ancestor for main and prefs app objects
remove event.observe stuff from startup, unneeded
2018-12-02 21:52:50 +03:00
Andrew Dolgov eeb49d375c uploadIconHandler -> CommonDialogs 2018-12-02 20:57:51 +03:00
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 2018-12-02 20:56:30 +03:00
Andrew Dolgov 495248dd97 add Notify object 2018-12-02 20:44:53 +03:00
wn_ 87850ca1aa Fix 'document.onkeydown' handler 2018-12-02 11:21:37 -06:00
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
2018-12-02 20:07:57 +03:00
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 2018-12-02 18:38:27 +03:00
Andrew Dolgov 807ff07454 split main objects to dojo modules 2018-12-02 17:18:59 +03:00
Andrew Dolgov fda3ad39c8 split several utility objects into separate dojo modules 2018-12-02 17:00:58 +03:00
Andrew Dolgov 35ded4bc84 edit phrasing of some alert()s 2018-12-02 16:30:32 +03:00
Andrew Dolgov 3a6dae9203 prefs: more of the same, really 2018-12-02 16:29:00 +03:00