41b4eef504
Address PHPStan warnings for FeedEnclosure.
2021-11-15 02:46:19 +00:00
78acf18b70
Address PHPStan warnings in FeedItem classes.
2021-11-15 02:40:45 +00:00
8943604aad
Change the param type for UserHelper::hash_password() $algo to appease PHPStan.
...
PHPStan was complaining in 'plugins/auth_internal/init.php' due to UserHelper::hash_password() being passed a string, rather than a UserHelper::HASH_ALGO_* constant. Just switching the param to string for now.
2021-11-14 22:44:48 +00:00
324d926eb4
Also fix the param signature for Plugin#hook_hotkey_info()
2021-11-14 22:16:16 +00:00
12f9df1066
Fix the return signature for Plugin#hook_hotkey_info()
2021-11-14 22:11:27 +00:00
6d438c5a77
Address PHPStan warning in 'classes/pref/users.php'.
2021-11-14 20:27:17 +00:00
5632d75a45
Address PHPStan warning in 'classes/pref/system.php'.
2021-11-14 20:26:21 +00:00
abab2a94e8
Address PHPStan warning in 'classes/pref/prefs.php'.
...
Also update 'select_hash' and 'select_tag' values param, which can have int or string keys.
2021-11-14 20:13:09 +00:00
b8f0627a0e
Address PHPStan warning in 'classes/pref/labels.php'.
2021-11-14 20:13:09 +00:00
56cf425e45
revise prototype for hook_enclosure_imported
2021-11-14 23:03:25 +03:00
9326ed605f
Address PHPStan warning in 'classes/pref/filters.php'.
2021-11-14 17:59:57 +00:00
812f5f532e
Address PHPStan warning in 'classes/mailer.php'.
2021-11-14 17:59:57 +00:00
931a7533ce
adjust some return types in urlhelper
2021-11-14 20:53:30 +03:00
afdb4b0072
set phpdoc annotations for auth_base
2021-11-14 20:26:05 +03:00
6bd6a14c20
revise phpdoc annotations for hook_sanitize()
2021-11-14 20:19:12 +03:00
f5c881586b
Handle potentially null link, title, etc. in FeedParser.
2021-11-14 16:59:21 +00:00
7988c79bd4
plugin.php: add some minor method phpdoc corrections
2021-11-14 18:05:31 +03:00
1b5c61ac85
userhelper: add a phpdoc variable class hint
2021-11-14 18:02:20 +03:00
01b39d985c
deal with the rest of warnings in plugin.php
2021-11-14 18:00:03 +03:00
dd7299b6d0
deal with a few more phpstan warnings re: base plugin class
2021-11-14 17:19:35 +03:00
55729b4bbd
fix HOOK_QUERY_HEADLINES being invoked with different argument lists, add some more phpdoc comments for base plugin class
2021-11-14 17:07:47 +03:00
af2f4460ce
* deal with some phpstan warnings in base plugin class
...
* arguably better hack for incompatible plugins causing E_COMPILE_ERROR
2021-11-14 16:49:10 +03:00
15af164f69
pluginhost: add a hack to not crash on an incompatible plugin more than once (per login) - UGLY
2021-11-14 11:50:55 +03:00
0a2dcacbcf
normalize some mismatching hook function definitions to match base Plugin class
2021-11-14 11:11:49 +03:00
81a10f69bc
deal with phpstan warnings related to base authentication modules
2021-11-14 10:48:32 +03:00
5a50c333b2
Address PHPStan warnings in 'classes/pref/filters.php'.
2021-11-14 00:59:19 +00:00
fe5ada7250
set some annotations on Plugin hook methods
2021-11-13 20:07:13 +03:00
5e34fe17a7
experimental: bring back plugin hooks to Plugin base class once (to be improved/fixed with annotations later)
2021-11-13 20:03:28 +03:00
618e96b793
deal with some warnings in plugins/trgm,readability and base plugin class
2021-11-13 19:55:30 +03:00
03d0692268
no need to duplicate annotations
2021-11-13 19:52:47 +03:00
37827427a2
rework previous Plugin changes as phpdoc annotations
2021-11-13 19:41:50 +03:00
9845d5fd15
revert all plugin base class related changes to keep compatibility with extant plugins (for the time being)
2021-11-13 19:36:26 +03:00
edd476e7fe
minor: correct $cat type in Pref_Feeds#calculate_children_count()
2021-11-13 16:00:59 +00:00
a18473e4c0
Address PHPStan warnings in 'classes/pref/feeds.php'.
2021-11-13 15:56:31 +00:00
b37a03fb31
Fix the type of Labels::update_cache()
2021-11-13 15:56:31 +00:00
f2323bda81
fix phpstan warnings in classes/plugin-template.php
2021-11-13 18:26:11 +03:00
70051742af
experimental: also don't keep base plugin template as a non-analyzed file
2021-11-13 18:21:04 +03:00
b381e95792
experimental: auto-generate and add all plugin hook methods to Plugin class
2021-11-13 18:18:05 +03:00
8a83f061bf
fix phpstan warnings in classes/sanitizer.php
2021-11-13 17:52:03 +03:00
a7983d475e
fix phpstan warnings in classes/api.php
2021-11-13 17:51:26 +03:00
77b8dc7386
fix phpstan warnings in classes/feedparser.php
2021-11-13 17:48:52 +03:00
45431170b6
fix phpstan warnings in classes/db/migrations.php
2021-11-13 17:31:13 +03:00
3ba8d964b6
Address PHPStan warnings in 'classes/api.php'.
2021-11-13 14:15:20 +00:00
1ec003ce35
Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might be tag).
2021-11-13 14:05:48 +00:00
25775bb407
Fix type of 'check_first_id' in Feeds '_format_headlines_list'.
2021-11-13 04:16:36 +00:00
d3a81f598b
Switch class properties from PHP typing to PHPDoc for compatibility with PHP < 7.4.0
2021-11-12 21:17:31 +00:00
2c41bc7fbc
Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and 'classes/pluginhandler.php'.
2021-11-12 06:16:18 +00:00
9db5e402a0
Address PHPStan warnings in 'classes/rpc.php'.
...
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'.
2021-11-12 05:42:55 +00:00
011c941e7c
Fix some PHPStan warnings in 'classes/db/migrations.php', 'classes/db/prefs.php', and 'classes/debug.php'.
2021-11-12 05:24:02 +00:00
b0eb347839
Fix a warning in 'classes/counters.php'.
2021-11-12 05:04:55 +00:00
wn_
Andrew Dolgov