- read only - can't subscribe to more feeds, feed updates are skipped
- disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
------ --------------------------------------
Line update.php
------ --------------------------------------
213 While loop condition is always true.
------ --------------------------------------
------ ------------------------------------------------------------------
Line include/colors.php
------ ------------------------------------------------------------------
215 Variable $out might not be defined.
223 Parameter #3 $pad_string of function str_pad expects string, int
given.
255 Variable $h might not be defined.
317 Variable $img might not be defined.
------ ------------------------------------------------------------------
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array.
------ ---------------------------------------------------------------------
Line classes/urlhelper.php
------ ---------------------------------------------------------------------
66 Offset 'path' on array{scheme: string} in isset() does not exist.
165 Parameter #2 $associative of function get_headers expects bool, int
given.
167 Parameter #2 $associative of function get_headers expects bool, int
given.
278 Negated boolean expression is always true.
309 Negated boolean expression is always true.
------ ---------------------------------------------------------------------
------ -------------------------------
Line classes/pref/users.php
------ -------------------------------
170 If condition is always false.
------ -------------------------------
------ ------------------------------------------------
Line classes/pref/prefs.php
------ ------------------------------------------------
1328 Expression on left side of ?? is not nullable.
------ ------------------------------------------------
------ --------------------------------------------------------------------
Line classes/pluginhost.php
------ --------------------------------------------------------------------
16 Property PluginHost::$last_registered is never read, only written.
386 If condition is always true.
------ --------------------------------------------------------------------
------ ---------------------------------------------
Line classes/feeditem/common.php
------ ---------------------------------------------
194 No error to ignore is reported on line 194.
------ ---------------------------------------------
------ --------------------------------------------------
Line classes/db.php
------ --------------------------------------------------
7 Property Db::$link is unused.
86 Property Db::pdo (PDO) in empty() is not falsy.
------ --------------------------------------------------
------ -----------------------------------------------------------------------
Line classes/config.php
------ -----------------------------------------------------------------------
3 Constant Config::_ENVVAR_PREFIX is unused.
177 Constant Config::_DEFAULTS is unused.
237 Property Config::$schema_version is never read, only written.
352 Property Config::$migrations (Db_Migrations) in empty() is not falsy.
------ -----------------------------------------------------------------------
backend: pass plugin button generated code through domdocument to ensure
its correctness; set data-plugin-name attribute on children to make
them sortable via css
- remove unused integer indexes when exporting filters as JSON
- fix warning when importing filters without rules
- properly assign category IDs for category filter rules
- fix warning: check if outline attributes like xmlUrl are set before trying to use them
- fix warning: don't try to use libxml_disable_entity_loader on PHP 8
wn_
Andrew Dolgov
fox
Philip Klempin
TonyRL