valvin
/
ttrss
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use .closest() instead of .up() to lookup parent by selector

This commit is contained in:
Andrew Dolgov 2021-02-19 07:43:05 +03:00
parent bec35200e9
commit d26269865f
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/Article.js
View File

@ -63,7 +63,7 @@ const Article = {
}
},
setScore: function (id, pic) {
const row = pic.up("div[id*=RROW]");
const row = pic.closest("div[id*=RROW]");
if (row) {
const score_old = row.getAttribute("data-score");

2
js/Headlines.js
View File

@ -1093,7 +1093,7 @@ const Headlines = {
return rv;
},
onRowChecked: function (elem) {
const row = elem.domNode.up("div[id*=RROW]");
const row = elem.domNode.closest("div[id*=RROW]");
// do not allow unchecking active article checkbox
if (row.hasClassName("active")) {

4
js/common.js
View File

@ -164,7 +164,7 @@ const Lists = {
// account for dojo checkboxes
elem = elem.domNode || elem;
const row = elem.up("li");
const row = elem.closest("li");
if (row)
checked ? row.addClassName("Selected") : row.removeClassName("Selected");
@ -194,7 +194,7 @@ const Tables = {
const checked = elem.domNode ? elem.attr("checked") : elem.checked;
elem = elem.domNode || elem;
const row = elem.up("tr");
const row = elem.closest("tr");
if (row)
checked ? row.addClassName("Selected") : row.removeClassName("Selected");