valvin
/
ttrss
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

login: only allow relative URLs in return=

This commit is contained in:
Andrew Dolgov 2019-03-03 07:53:42 +03:00
parent cc57ed3775
commit c68ac04020
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
classes/handler/public.php
View File

@ -712,8 +712,10 @@ class Handler_Public extends Handler {
user_error("Failed login attempt for $login from {$_SERVER['REMOTE_ADDR']}", E_USER_WARNING); user_error("Failed login attempt for $login from {$_SERVER['REMOTE_ADDR']}", E_USER_WARNING);
} }
if (clean($_REQUEST['return'])) { $return = clean($_REQUEST['return']);
header("Location: " . clean($_REQUEST['return']));
if ($return && !is_absolute_url($return)) {
header("Location: " . $return);
} else { } else {
header("Location: " . get_self_url_prefix()); header("Location: " . get_self_url_prefix());
} }

6
include/functions.php
View File

@ -2562,3 +2562,9 @@
return $ts; return $ts;
} }
function is_absolute_url($url) {
$parts = parse_url($url);
return $parts['host'] != '';
}