From b3e3cb06d9980eac5f8ebf21c6b7f14c1f3b15f2 Mon Sep 17 00:00:00 2001 From: wn_ Date: Sat, 27 May 2017 12:25:59 -0500 Subject: [PATCH] Show a blank icon in PrefFeedTree if there is no favicon for a feed. Duplicates behavior of FeedTree. Prevents a broken request to 'false' if a feed doesn't have a favicon. --- js/PrefFeedTree.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/js/PrefFeedTree.js b/js/PrefFeedTree.js index 3cf8257be..0079f0b1b 100644 --- a/js/PrefFeedTree.js +++ b/js/PrefFeedTree.js @@ -23,12 +23,14 @@ require(["dojo/_base/declare", "dojo/dom-construct", "lib/CheckBoxTree"], functi _createTreeNode: function(args) { var tnode = this.inherited(arguments); - if (args.item.icon) { - var icon = dojo.doc.createElement('img'); + var icon = dojo.doc.createElement('img'); + if (args.item.icon && args.item.icon[0]) { icon.src = args.item.icon[0]; - icon.className = 'tinyFeedIcon'; - domConstruct.place(icon, tnode.iconNode, 'only'); + } else { + icon.src = 'images/blank_icon.gif'; } + icon.className = 'tinyFeedIcon'; + domConstruct.place(icon, tnode.iconNode, 'only'); var param = this.model.store.getValue(args.item, 'param');