From 781fe3d636c79c3216a106afbf8ecf7d45c13a99 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Thu, 29 Aug 2019 12:52:22 +0300 Subject: [PATCH] setScore, selectionSetScore: check for numerical values properly --- js/Article.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/Article.js b/js/Article.js index b933ed716..970234818 100644 --- a/js/Article.js +++ b/js/Article.js @@ -32,7 +32,7 @@ define(["dojo/_base/declare"], function (declare) { if (ids.length > 0) { const score = prompt(__("Please enter new score for selected articles:")); - if (parseInt(score) != undefined) { + if (!isNaN(parseInt(score))) { ids.each((id) => { const row = $("RROW-" + id); @@ -66,7 +66,7 @@ define(["dojo/_base/declare"], function (declare) { const score_old = row.getAttribute("data-score"); const score = prompt(__("Please enter new score for this article:"), score_old); - if (parseInt(score) != undefined) { + if (!isNaN(parseInt(score))) { row.setAttribute("data-score", score); const pic = row.select(".icon-score")[0]; @@ -340,4 +340,4 @@ define(["dojo/_base/declare"], function (declare) { } return Article; -}); \ No newline at end of file +});