diff --git a/classes/feeds.php b/classes/feeds.php index b95ade2f5..98a9ed249 100755 --- a/classes/feeds.php +++ b/classes/feeds.php @@ -298,11 +298,7 @@ class Feeds extends Handler_Protected { $this->_mark_timestamp(" tags"); - if (self::_has_icon($feed_id)) { - $line['feed_icon'] = "\"\""; - } else { - $line['feed_icon'] = "rss_feed"; - } + $line['has_icon'] = self::_has_icon($feed_id); //setting feed headline background color, needs to change text color based on dark/light $fav_color = $line['favicon_avg_color'] ?? false; diff --git a/js/Feeds.js b/js/Feeds.js index 01d31f3c1..e9ac5328d 100644 --- a/js/Feeds.js +++ b/js/Feeds.js @@ -633,4 +633,9 @@ const Feeds = { // }); }, + renderIcon: function(feed_id, exists) { + return feed_id && exists ? + `` : + `rss_feed`; + } }; diff --git a/js/Headlines.js b/js/Headlines.js index 60066164f..d086870cf 100755 --- a/js/Headlines.js +++ b/js/Headlines.js @@ -423,7 +423,7 @@ const Headlines = { if (headlines.vfeed_group_enabled && hl.feed_title && this.vgroup_last_feed != hl.feed_id) { const vgrhdr = `
-
${hl.feed_icon}
+
${Feeds.renderIcon(hl.feed_id, hl.has_icon)}
${hl.feed_title} done_all
` @@ -477,7 +477,8 @@ const Headlines = { ${Article.getScorePic(hl.score)} - ${hl.feed_icon} + ${Feeds.renderIcon(hl.feed_id, hl.has_icon)} + @@ -538,7 +539,7 @@ const Headlines = {
${Article.getScorePic(hl.score)} - ${hl.feed_icon} + ${Feeds.renderIcon(hl.feed_id, hl.has_icon)}
`;