rename Headlines.correctHeadlinesOffset() to scrollToArticleId()
invoke it in Article.view() instead of all over the place
This commit is contained in:
parent
05a84ab778
commit
25c8467753
|
@ -139,7 +139,7 @@ define(["dojo/_base/declare"], function (declare) {
|
|||
c.attr('content', article);
|
||||
PluginHost.run(PluginHost.HOOK_ARTICLE_RENDERED, c.domNode);
|
||||
|
||||
Headlines.correctHeadlinesOffset(Article.getActive());
|
||||
//Headlines.correctHeadlinesOffset(Article.getActive());
|
||||
|
||||
try {
|
||||
c.focus();
|
||||
|
@ -198,6 +198,7 @@ define(["dojo/_base/declare"], function (declare) {
|
|||
},
|
||||
view: function (id, noexpand) {
|
||||
this.setActive(id);
|
||||
Headlines.scrollToArticleId(id);
|
||||
|
||||
if (!noexpand) {
|
||||
const hl = Headlines.objectById(id);
|
||||
|
|
|
@ -835,7 +835,6 @@ define(["dojo/_base/declare"], function (declare) {
|
|||
Article.setActive(next_id);
|
||||
Article.cdmMoveToId(next_id, {event: event, noscroll: noscroll});
|
||||
} else {
|
||||
Headlines.correctHeadlinesOffset(next_id);
|
||||
Article.view(next_id, noexpand);
|
||||
}
|
||||
}
|
||||
|
@ -855,7 +854,6 @@ define(["dojo/_base/declare"], function (declare) {
|
|||
}
|
||||
|
||||
} else if (prev_id) {
|
||||
Headlines.correctHeadlinesOffset(prev_id);
|
||||
Article.view(prev_id, noexpand);
|
||||
}
|
||||
}
|
||||
|
@ -1193,7 +1191,7 @@ define(["dojo/_base/declare"], function (declare) {
|
|||
eval(elem.value);
|
||||
elem.attr('value', 'false');
|
||||
},
|
||||
correctHeadlinesOffset: function (id) {
|
||||
scrollToArticleId: function (id) {
|
||||
const container = $("headlines-frame");
|
||||
const row = $("RROW-" + id);
|
||||
|
||||
|
|
Loading…
Reference in New Issue